From: Joe Perches <joe@perches.com>
To: linux-kernel@vger.kernel.org
Cc: Jeff Garzik <jgarzik@pobox.com>,
Paul Gortmaker <p_gortmaker@yahoo.com>,
netdev@vger.kernel.org
Subject: [PATCH 03/11] drivers/net/mac8390.c: Use print_mac
Date: Fri, 14 Dec 2007 14:34:04 -0800 [thread overview]
Message-ID: <1197671652-32492-3-git-send-email-joe@perches.com> (raw)
Message-ID: <a737529b0fd2d0a3ea1dcdf684e5b869a347726c.1197671367.git.joe@perches.com> (raw)
In-Reply-To: <1197671652-32492-2-git-send-email-joe@perches.com>
In-Reply-To: <9fc484fc034428ab68ecb2711c8456df9e98d56d.1197671367.git.joe@perches.com>
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/mac8390.c | 18 ++++++------------
1 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/net/mac8390.c b/drivers/net/mac8390.c
index 9e70074..4eccebb 100644
--- a/drivers/net/mac8390.c
+++ b/drivers/net/mac8390.c
@@ -483,6 +483,7 @@ void cleanup_module(void)
static int __init mac8390_initdev(struct net_device * dev, struct nubus_dev * ndev,
enum mac8390_type type)
{
+ DECLARE_MAC_BUF(mac);
static u32 fwrd4_offsets[16]={
0, 4, 8, 12,
16, 20, 24, 28,
@@ -612,18 +613,11 @@ static int __init mac8390_initdev(struct net_device * dev, struct nubus_dev * nd
/* Good, done, now spit out some messages */
printk(KERN_INFO "%s: %s in slot %X (type %s)\n",
dev->name, ndev->board->name, ndev->board->slot, cardname[type]);
- printk(KERN_INFO "MAC ");
- {
- int i;
- for (i = 0; i < 6; i++) {
- printk("%2.2x", dev->dev_addr[i]);
- if (i < 5)
- printk(":");
- }
- }
- printk(" IRQ %d, %d KB shared memory at %#lx, %d-bit access.\n",
- dev->irq, (int)((dev->mem_end - dev->mem_start)/0x1000) * 4,
- dev->mem_start, access_bitmode?32:16);
+ printk(KERN_INFO "MAC %s IRQ %d, %d KB shared memory at %#lx, "
+ "%d-bit access.\n",
+ print_mac(mac, dev->dev_addr), dev->irq,
+ (int)((dev->mem_end - dev->mem_start)/0x1000) * 4,
+ dev->mem_start, access_bitmode?32:16);
return 0;
}
--
1.5.3.7.949.g2221a6
next prev parent reply other threads:[~2007-12-14 22:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9fc484fc034428ab68ecb2711c8456df9e98d56d.1197671367.git.joe@perches.com>
2007-12-14 22:34 ` [PATCH 01/11] drivers/net/ax88796.c: Use print_mac Joe Perches
[not found] ` <b58808ccb17be357af117065d60049ce06907096.1197671367.git.joe@perches.com>
2007-12-14 22:34 ` [PATCH 02/11] drivers/net/hplance.c: " Joe Perches
[not found] ` <a737529b0fd2d0a3ea1dcdf684e5b869a347726c.1197671367.git.joe@perches.com>
2007-12-14 22:34 ` Joe Perches [this message]
[not found] ` <956426131a609b9dcdce1711c5727c16d68fdf28.1197671367.git.joe@perches.com>
2007-12-14 22:34 ` [PATCH 04/11] drivers/net/mac89x0.c: " Joe Perches
[not found] ` <5766808cd4c25c37bc7b27864be04ca777b59528.1197671367.git.joe@perches.com>
2007-12-14 22:34 ` [PATCH 05/11] drivers/net/niu.c: " Joe Perches
2007-12-20 12:07 ` David Miller
[not found] ` <8fd9b582c10ca4d7ba53b76f68f19b608d755843.1197671367.git.joe@perches.com>
2007-12-14 22:34 ` [PATCH 06/11] drivers/net/pcnet32.c: " Joe Perches
[not found] ` <d1a31f8685a70676de100f9521e9f5b6f4255fe5.1197671367.git.joe@perches.com>
2007-12-14 22:34 ` [PATCH 07/11] drivers/net/smc911x.c: " Joe Perches
[not found] ` <d70fb8ac3a19e2bc8ca4976aeacee3c31dd52073.1197671367.git.joe@perches.com>
2007-12-14 22:34 ` [PATCH 08/11] drivers/net/sunvnet.c: " Joe Perches
2007-12-20 12:06 ` David Miller
[not found] ` <24eddd5027b6ac3b66224dcf50a4ba4eed5aba60.1197671367.git.joe@perches.com>
2007-12-14 22:34 ` [PATCH 09/11] drivers/net/tg3.c: " Joe Perches
2007-12-20 12:07 ` David Miller
[not found] ` <594ca287b8d1ad674515eb3c2e35b8d42430eae5.1197671367.git.joe@perches.com>
2007-12-14 22:34 ` [PATCH 10/11] drivers/net/tulip/de4x5.c: " Joe Perches
[not found] ` <b41dd7dec52cd03cc97893325bfef6a57639a61a.1197671367.git.joe@perches.com>
2007-12-14 22:34 ` [PATCH 11/11] drivers/net/usb/catc.c: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197671652-32492-3-git-send-email-joe@perches.com \
--to=joe@perches.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).