From: Luca Ceresoli <luca@lucaceresoli.net>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
devicetree@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-watchdog@vger.kernel.org,
Chiwoong Byun <woong.byun@samsung.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH 7/8] watchdog: max77714: add driver for the watchdog in the MAX77714 PMIC
Date: Fri, 15 Oct 2021 18:42:05 +0200 [thread overview]
Message-ID: <a78a3f69-d84d-727f-4173-2f0498a4c6f7@lucaceresoli.net> (raw)
In-Reply-To: <319589ca-0dfb-008f-052a-01f0f25d86fa@infradead.org>
Hi,
On 12/10/21 03:18, Randy Dunlap wrote:
> Hi,
>
> On 10/11/21 8:56 AM, Luca Ceresoli wrote:
>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>> index bf59faeb3de1..00bc3f932a6c 100644
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -699,6 +699,15 @@ config MAX77620_WATCHDOG
>> MAX77620 chips. To compile this driver as a module,
>> choose M here: the module will be called max77620_wdt.
>> +config MAX77714_WATCHDOG
>> + tristate "Maxim MAX77714 Watchdog Timer"
>> + depends on MFD_MAX77714 || COMPILE_TEST
>> + help
>> + This is the driver for watchdog timer in the MAX77714 PMIC.
>> + Say 'Y' here to enable the watchdog timer support for
>> + MAX77714 chips. To compile this driver as a module,
>> + choose M here: the module will be called max77714_wdt.
>
> Please follow coding-style for Kconfig files:
>
> (from Documentation/process/coding-style.rst, section 10):
>
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different. Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.
Oh dear, I usually don't make such silly mistakes, apologies.
[...some fast typing later...]
Uhm, now I noticed many entries in that file have that same mistake.
Perhaps I copy-pasted and didn't check. I'll send a patch to fix them too.
--
Luca
next prev parent reply other threads:[~2021-10-15 16:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 15:56 [PATCH 0/8] Add MAX77714 PMIC minimal driver (RTC and watchdog only) Luca Ceresoli
2021-10-11 15:56 ` [PATCH 1/8] mfd: max77686: Correct tab-based alignment of register addresses Luca Ceresoli
2021-10-12 8:00 ` Krzysztof Kozlowski
2021-10-11 15:56 ` [PATCH 2/8] rtc: max77686: convert comments to kernel-doc format Luca Ceresoli
2021-10-12 8:00 ` Krzysztof Kozlowski
2021-10-15 17:29 ` Alexandre Belloni
2021-10-11 15:56 ` [PATCH 3/8] rtc: max77686: rename day-of-month defines Luca Ceresoli
2021-10-12 2:23 ` kernel test robot
2021-10-12 2:58 ` kernel test robot
2021-10-12 8:13 ` Krzysztof Kozlowski
2021-10-11 15:56 ` [PATCH 4/8] rtc: max77686: remove useless variable Luca Ceresoli
2021-10-12 8:01 ` Krzysztof Kozlowski
2021-10-15 17:33 ` Alexandre Belloni
2021-10-15 20:59 ` Luca Ceresoli
2021-10-11 15:56 ` [PATCH 5/8] dt-bindings: mfd: add Maxim MAX77714 PMIC Luca Ceresoli
2021-10-12 8:02 ` Krzysztof Kozlowski
2021-10-13 21:28 ` Luca Ceresoli
2021-10-14 7:38 ` Krzysztof Kozlowski
2021-10-11 15:56 ` [PATCH 6/8] mfd: max77714: Add driver for " Luca Ceresoli
2021-10-11 17:15 ` Guenter Roeck
2021-10-12 7:11 ` kernel test robot
2021-10-12 8:09 ` Krzysztof Kozlowski
2021-10-13 21:49 ` Luca Ceresoli
2021-10-14 7:44 ` Krzysztof Kozlowski
2021-10-12 8:32 ` Krzysztof Kozlowski
2021-10-13 21:39 ` Luca Ceresoli
2021-10-14 7:40 ` Krzysztof Kozlowski
2021-10-14 8:25 ` Luca Ceresoli
2021-10-11 15:56 ` [PATCH 7/8] watchdog: max77714: add driver for the watchdog in the " Luca Ceresoli
2021-10-11 17:17 ` Guenter Roeck
2021-10-15 16:43 ` Luca Ceresoli
2021-10-12 1:18 ` Randy Dunlap
2021-10-15 16:42 ` Luca Ceresoli [this message]
2021-10-15 17:07 ` Randy Dunlap
2021-10-11 20:25 ` [PATCH 8/8] rtc: max77686: add MAX77714 support Luca Ceresoli
2021-10-11 16:12 ` Luca Ceresoli
2021-10-12 8:20 ` Krzysztof Kozlowski
2021-10-15 16:46 ` Luca Ceresoli
2021-10-12 8:29 ` Krzysztof Kozlowski
2021-10-15 17:36 ` Alexandre Belloni
2021-10-12 7:59 ` [PATCH 0/8] Add MAX77714 PMIC minimal driver (RTC and watchdog only) Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a78a3f69-d84d-727f-4173-2f0498a4c6f7@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=woong.byun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).