* [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered
@ 2017-05-01 22:45 Eduardo Molinas
2017-05-01 22:45 ` [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF " Eduardo Molinas
2017-05-02 2:10 ` [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM " Chen-Yu Tsai
0 siblings, 2 replies; 6+ messages in thread
From: Eduardo Molinas @ 2017-05-01 22:45 UTC (permalink / raw)
To: linux-kernel
Cc: jic23, knaack.h, lars, pmeerw, linux-iio, linux-arm-kernel,
Eduardo Molinas
If the driver is built as a module, it won't be autloaded if the devices
are registered via PLATFORM code because the PLATFORM device table
entries are not exported as aliases
Before the patch:
$ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
$
After th patch:
$ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
alias: platform:sun6i-a31-gpadc-iio
alias: platform:sun5i-a13-gpadc-iio
alias: platform:sun4i-a10-gpadc-iio
Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>
---
---
drivers/iio/adc/sun4i-gpadc-iio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/sun4i-gpadc-iio.c b/drivers/iio/adc/sun4i-gpadc-iio.c
index b23527309088..c3d7ba100a48 100644
--- a/drivers/iio/adc/sun4i-gpadc-iio.c
+++ b/drivers/iio/adc/sun4i-gpadc-iio.c
@@ -700,6 +700,7 @@ static const struct platform_device_id sun4i_gpadc_id[] = {
{ "sun6i-a31-gpadc-iio", (kernel_ulong_t)&sun6i_gpadc_data },
{ /* sentinel */ },
};
+MODULE_DEVICE_TABLE(platform, sun4i_gpadc_id);
static struct platform_driver sun4i_gpadc_driver = {
.driver = {
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF devices are registered
2017-05-01 22:45 [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered Eduardo Molinas
@ 2017-05-01 22:45 ` Eduardo Molinas
2017-05-02 2:09 ` Chen-Yu Tsai
2017-05-02 2:10 ` [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM " Chen-Yu Tsai
1 sibling, 1 reply; 6+ messages in thread
From: Eduardo Molinas @ 2017-05-01 22:45 UTC (permalink / raw)
To: linux-kernel
Cc: jic23, knaack.h, lars, pmeerw, linux-iio, linux-arm-kernel,
Eduardo Molinas
If the driver is built as a module, it won't be autloaded if the devices
are registered via OF code because the OF device table
entries are not exported as aliases
Before the patch:
$ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
alias: platform:sun6i-a31-gpadc-iio
alias: platform:sun5i-a13-gpadc-iio
alias: platform:sun4i-a10-gpadc-iio
After the patch:
$ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
alias: of:N*T*Callwinner,sun8i-a33-thsC*
alias: of:N*T*Callwinner,sun8i-a33-ths
alias: platform:sun6i-a31-gpadc-iio
alias: platform:sun5i-a13-gpadc-iio
alias: platform:sun4i-a10-gpadc-iio
Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>
---
---
drivers/iio/adc/sun4i-gpadc-iio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/sun4i-gpadc-iio.c b/drivers/iio/adc/sun4i-gpadc-iio.c
index c3d7ba100a48..1c83b45043bf 100644
--- a/drivers/iio/adc/sun4i-gpadc-iio.c
+++ b/drivers/iio/adc/sun4i-gpadc-iio.c
@@ -712,6 +712,7 @@ static struct platform_driver sun4i_gpadc_driver = {
.probe = sun4i_gpadc_probe,
.remove = sun4i_gpadc_remove,
};
+MODULE_DEVICE_TABLE(of, sun4i_gpadc_of_id);
module_platform_driver(sun4i_gpadc_driver);
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF devices are registered
2017-05-01 22:45 ` [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF " Eduardo Molinas
@ 2017-05-02 2:09 ` Chen-Yu Tsai
2017-05-07 13:46 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Chen-Yu Tsai @ 2017-05-02 2:09 UTC (permalink / raw)
To: Eduardo Molinas
Cc: linux-kernel, Lars-Peter Clausen, linux-iio, Jonathan Cameron,
Peter Meerwald-Stadler, knaack.h, linux-arm-kernel
On Tue, May 2, 2017 at 6:45 AM, Eduardo Molinas <edu.molinas@gmail.com> wrote:
> If the driver is built as a module, it won't be autloaded if the devices
> are registered via OF code because the OF device table
> entries are not exported as aliases
>
> Before the patch:
> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
> alias: platform:sun6i-a31-gpadc-iio
> alias: platform:sun5i-a13-gpadc-iio
> alias: platform:sun4i-a10-gpadc-iio
>
> After the patch:
> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
> alias: of:N*T*Callwinner,sun8i-a33-thsC*
> alias: of:N*T*Callwinner,sun8i-a33-ths
> alias: platform:sun6i-a31-gpadc-iio
> alias: platform:sun5i-a13-gpadc-iio
> alias: platform:sun4i-a10-gpadc-iio
>
> Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Can we merge this as a fix for 4.12?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF devices are registered
2017-05-02 2:09 ` Chen-Yu Tsai
@ 2017-05-07 13:46 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2017-05-07 13:46 UTC (permalink / raw)
To: Chen-Yu Tsai, Eduardo Molinas
Cc: linux-kernel, Lars-Peter Clausen, linux-iio,
Peter Meerwald-Stadler, knaack.h, linux-arm-kernel
On 02/05/17 03:09, Chen-Yu Tsai wrote:
> On Tue, May 2, 2017 at 6:45 AM, Eduardo Molinas <edu.molinas@gmail.com> wrote:
>> If the driver is built as a module, it won't be autloaded if the devices
>> are registered via OF code because the OF device table
>> entries are not exported as aliases
>>
>> Before the patch:
>> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
>> alias: platform:sun6i-a31-gpadc-iio
>> alias: platform:sun5i-a13-gpadc-iio
>> alias: platform:sun4i-a10-gpadc-iio
>>
>> After the patch:
>> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
>> alias: of:N*T*Callwinner,sun8i-a33-thsC*
>> alias: of:N*T*Callwinner,sun8i-a33-ths
>> alias: platform:sun6i-a31-gpadc-iio
>> alias: platform:sun5i-a13-gpadc-iio
>> alias: platform:sun4i-a10-gpadc-iio
>>
>> Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
>
> Can we merge this as a fix for 4.12?
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered
2017-05-01 22:45 [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered Eduardo Molinas
2017-05-01 22:45 ` [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF " Eduardo Molinas
@ 2017-05-02 2:10 ` Chen-Yu Tsai
2017-05-07 13:45 ` Jonathan Cameron
1 sibling, 1 reply; 6+ messages in thread
From: Chen-Yu Tsai @ 2017-05-02 2:10 UTC (permalink / raw)
To: Eduardo Molinas
Cc: linux-kernel, Lars-Peter Clausen, linux-iio, Jonathan Cameron,
Peter Meerwald-Stadler, knaack.h, linux-arm-kernel
On Tue, May 2, 2017 at 6:45 AM, Eduardo Molinas <edu.molinas@gmail.com> wrote:
> If the driver is built as a module, it won't be autloaded if the devices
> are registered via PLATFORM code because the PLATFORM device table
> entries are not exported as aliases
>
> Before the patch:
> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
> $
>
> After th patch:
^^ the
> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
> alias: platform:sun6i-a31-gpadc-iio
> alias: platform:sun5i-a13-gpadc-iio
> alias: platform:sun4i-a10-gpadc-iio
>
> Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Can we merge this as a fix for 4.12?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered
2017-05-02 2:10 ` [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM " Chen-Yu Tsai
@ 2017-05-07 13:45 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2017-05-07 13:45 UTC (permalink / raw)
To: Chen-Yu Tsai, Eduardo Molinas
Cc: linux-kernel, Lars-Peter Clausen, linux-iio,
Peter Meerwald-Stadler, knaack.h, linux-arm-kernel
On 02/05/17 03:10, Chen-Yu Tsai wrote:
> On Tue, May 2, 2017 at 6:45 AM, Eduardo Molinas <edu.molinas@gmail.com> wrote:
>> If the driver is built as a module, it won't be autloaded if the devices
>> are registered via PLATFORM code because the PLATFORM device table
>> entries are not exported as aliases
>>
>> Before the patch:
>> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
>> $
>>
>> After th patch:
>
> ^^ the
>
>> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
>> alias: platform:sun6i-a31-gpadc-iio
>> alias: platform:sun5i-a13-gpadc-iio
>> alias: platform:sun4i-a10-gpadc-iio
>>
>> Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
>
> Can we merge this as a fix for 4.12?
Applied to fixes-togreg branch of iio.git.
Thanks,
Jonathan
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-07 22:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-01 22:45 [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered Eduardo Molinas
2017-05-01 22:45 ` [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF " Eduardo Molinas
2017-05-02 2:09 ` Chen-Yu Tsai
2017-05-07 13:46 ` Jonathan Cameron
2017-05-02 2:10 ` [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM " Chen-Yu Tsai
2017-05-07 13:45 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).