* [PATCH v4] dt-bindings: display: mediatek: clean unnecessary item
@ 2023-03-07 10:07 Alexandre Mergnat
2023-03-07 10:17 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Mergnat @ 2023-03-07 10:07 UTC (permalink / raw)
To: Chun-Kuang Hu, Krzysztof Kozlowski, Daniel Vetter,
Matthias Brugger, AngeloGioacchino Del Regno, Allen-KH Cheng,
Philipp Zabel, Rob Herring, David Airlie
Cc: Alexandre Mergnat, Krzysztof Kozlowski, Rob Herring,
linux-kernel, linux-arm-kernel, linux-mediatek, devicetree,
dri-devel
The item which have the mediatek,mt8192-disp-ccorr as const compatible
already exist above. Merge all compatibles which have the same fallback
under the same item.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
---
Fix MTK color correction binding
The fallback compatible has been duplicated in the 137272ef1b0f commit.
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
To: David Airlie <airlied@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc: Rob Herring <robh@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-mediatek@lists.infradead.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
Changes in v4:
- Reword commit title and message.
- Link to v3: https://lore.kernel.org/r/20230306-ccorr-binding-fix-v3-0-7877613a35cb@baylibre.com
Changes in v3:
- Re-order compatible.
- Link to v2: https://lore.kernel.org/r/20230306-ccorr-binding-fix-v2-0-4822939a837d@baylibre.com
Changes in v2:
- Fix commit title.
- Link to v1: https://lore.kernel.org/r/20230306-ccorr-binding-fix-v1-0-177d81d60c69@baylibre.com
---
.../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
index b04820c95b22..bda86e6857f5 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
@@ -27,13 +27,10 @@ properties:
- const: mediatek,mt8192-disp-ccorr
- items:
- enum:
+ - mediatek,mt8186-disp-ccorr
- mediatek,mt8188-disp-ccorr
- mediatek,mt8195-disp-ccorr
- const: mediatek,mt8192-disp-ccorr
- - items:
- - enum:
- - mediatek,mt8186-disp-ccorr
- - const: mediatek,mt8192-disp-ccorr
reg:
maxItems: 1
---
base-commit: add072536971d7ce891fde3cdbf68c55e7cfa95a
change-id: 20230306-ccorr-binding-fix-718c6d725088
Best regards,
--
Alexandre Mergnat <amergnat@baylibre.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v4] dt-bindings: display: mediatek: clean unnecessary item
2023-03-07 10:07 [PATCH v4] dt-bindings: display: mediatek: clean unnecessary item Alexandre Mergnat
@ 2023-03-07 10:17 ` AngeloGioacchino Del Regno
2023-03-07 10:50 ` Alexandre Mergnat
2023-03-07 12:50 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-07 10:17 UTC (permalink / raw)
To: Alexandre Mergnat, Chun-Kuang Hu, Krzysztof Kozlowski,
Daniel Vetter, Matthias Brugger, Allen-KH Cheng, Philipp Zabel,
Rob Herring, David Airlie
Cc: Krzysztof Kozlowski, Rob Herring, linux-kernel, linux-arm-kernel,
linux-mediatek, devicetree, dri-devel
Il 07/03/23 11:07, Alexandre Mergnat ha scritto:
> The item which have the mediatek,mt8192-disp-ccorr as const compatible
> already exist above. Merge all compatibles which have the same fallback
> under the same item.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
Alexandre, the Acked-by tag from Krzysztof goes *after* your S-o-b :-)
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4] dt-bindings: display: mediatek: clean unnecessary item
2023-03-07 10:17 ` AngeloGioacchino Del Regno
@ 2023-03-07 10:50 ` Alexandre Mergnat
2023-03-07 10:58 ` AngeloGioacchino Del Regno
2023-03-07 12:50 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Alexandre Mergnat @ 2023-03-07 10:50 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: Chun-Kuang Hu, Krzysztof Kozlowski, Daniel Vetter,
Matthias Brugger, Allen-KH Cheng, Philipp Zabel, Rob Herring,
David Airlie, Krzysztof Kozlowski, Rob Herring, linux-kernel,
linux-arm-kernel, linux-mediatek, devicetree, dri-devel
Hi Angelo
Le mar. 7 mars 2023 à 11:17, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a écrit :
>
> Il 07/03/23 11:07, Alexandre Mergnat ha scritto:
> > The item which have the mediatek,mt8192-disp-ccorr as const compatible
> > already exist above. Merge all compatibles which have the same fallback
> > under the same item.
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
>
> Alexandre, the Acked-by tag from Krzysztof goes *after* your S-o-b :-)
This is managed by the B4 tools.
Also, I know this is an unsolved topic in the community, but I agree
with people thinking the last trailer must be the guy in charge of the
commit.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4] dt-bindings: display: mediatek: clean unnecessary item
2023-03-07 10:50 ` Alexandre Mergnat
@ 2023-03-07 10:58 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-07 10:58 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Chun-Kuang Hu, Krzysztof Kozlowski, Daniel Vetter,
Matthias Brugger, Allen-KH Cheng, Philipp Zabel, Rob Herring,
David Airlie, Krzysztof Kozlowski, Rob Herring, linux-kernel,
linux-arm-kernel, linux-mediatek, devicetree, dri-devel
Il 07/03/23 11:50, Alexandre Mergnat ha scritto:
> Hi Angelo
>
> Le mar. 7 mars 2023 à 11:17, AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> a écrit :
>>
>> Il 07/03/23 11:07, Alexandre Mergnat ha scritto:
>>> The item which have the mediatek,mt8192-disp-ccorr as const compatible
>>> already exist above. Merge all compatibles which have the same fallback
>>> under the same item.
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
>>
>> Alexandre, the Acked-by tag from Krzysztof goes *after* your S-o-b :-)
>
> This is managed by the B4 tools.
> Also, I know this is an unsolved topic in the community, but I agree
> with people thinking the last trailer must be the guy in charge of the
> commit.
I was told so multiple times, hence my reply.
I personally do not care much where the tags are put, as long as they are
consistently put in a specific order; if I had strong opinions, I wouldn't
have given you a R-b tag preventively... so... whatever! :-)
Angelo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4] dt-bindings: display: mediatek: clean unnecessary item
2023-03-07 10:17 ` AngeloGioacchino Del Regno
2023-03-07 10:50 ` Alexandre Mergnat
@ 2023-03-07 12:50 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-07 12:50 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Alexandre Mergnat, Chun-Kuang Hu,
Krzysztof Kozlowski, Daniel Vetter, Matthias Brugger,
Allen-KH Cheng, Philipp Zabel, Rob Herring, David Airlie
Cc: Rob Herring, linux-kernel, linux-arm-kernel, linux-mediatek,
devicetree, dri-devel
On 07/03/2023 11:17, AngeloGioacchino Del Regno wrote:
> Il 07/03/23 11:07, Alexandre Mergnat ha scritto:
>> The item which have the mediatek,mt8192-disp-ccorr as const compatible
>> already exist above. Merge all compatibles which have the same fallback
>> under the same item.
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
>
> Alexandre, the Acked-by tag from Krzysztof goes *after* your S-o-b :-)
b4 puts them like this and there is even rationale from Konstantin about
it. Anyway, it's not submitters job to correct b4. Our tools should
implement the process, not us (the users), thus if the result is
incorrect, then the tool should be fixed. Not the user.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-07 12:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-07 10:07 [PATCH v4] dt-bindings: display: mediatek: clean unnecessary item Alexandre Mergnat
2023-03-07 10:17 ` AngeloGioacchino Del Regno
2023-03-07 10:50 ` Alexandre Mergnat
2023-03-07 10:58 ` AngeloGioacchino Del Regno
2023-03-07 12:50 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).