From: Joe Perches <joe@perches.com>
To: Vasyl Gomonovych <gomonovych@gmail.com>, tariqt@nvidia.com
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx4: Use true,false for bool variable
Date: Fri, 11 Dec 2020 21:25:01 -0800 [thread overview]
Message-ID: <a81975ecafefb7aebd087a97780424d5bb9ba280.camel@perches.com> (raw)
In-Reply-To: <20201211100518.29804-1-gomonovych@gmail.com>
On Fri, 2020-12-11 at 11:05 +0100, Vasyl Gomonovych wrote:
> Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable
> Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable
[]
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
[]
> @@ -4462,7 +4462,7 @@ static int __init mlx4_verify_params(void)
> pr_warn("mlx4_core: log_num_vlan - obsolete module param, using %d\n",
> MLX4_LOG_NUM_VLANS);
>
>
> - if (use_prio != 0)
> + if (use_prio != false)
> pr_warn("mlx4_core: use_prio - obsolete module param, ignored\n");
Generally, assuming use_prio is bool, this would be written
if (use_prio)
pr_warn("etc...")
next prev parent reply other threads:[~2020-12-12 5:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 10:05 [PATCH] net/mlx4: Use true,false for bool variable Vasyl Gomonovych
2020-12-12 5:25 ` Joe Perches [this message]
2020-12-12 17:02 ` Jakub Kicinski
2020-12-14 10:30 ` [PATCH v2] " Vasyl Gomonovych
2020-12-14 11:16 ` Leon Romanovsky
2020-12-14 19:03 ` Jakub Kicinski
2020-12-14 19:15 ` Joe Perches
2020-12-15 5:18 ` Leon Romanovsky
2020-12-15 5:37 ` Joe Perches
2020-12-15 6:18 ` Leon Romanovsky
2020-12-15 12:27 ` Vasyl
2020-12-14 23:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a81975ecafefb7aebd087a97780424d5bb9ba280.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gomonovych@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).