From: Vasyl <gomonovych@gmail.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Joe Perches <joe@perches.com>, Jakub Kicinski <kuba@kernel.org>,
tariqt@nvidia.com, "David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
linux-rdma@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net/mlx4: Use true,false for bool variable
Date: Tue, 15 Dec 2020 13:27:28 +0100 [thread overview]
Message-ID: <CAHYXAnJZrxOPTttd4Z1v4f1ixwarxsJpz8YYZNDL_5r4_SkyeQ@mail.gmail.com> (raw)
In-Reply-To: <20201215061847.GL5005@unreal>
Hi,
Ouuu it was fixed recently in net-next.
Sorry, I missed that.
Thanks for submitting policy clarification I am going to adapt to it.
Thanks
On Tue, Dec 15, 2020 at 7:18 AM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Mon, Dec 14, 2020 at 09:37:34PM -0800, Joe Perches wrote:
> > On Tue, 2020-12-15 at 07:18 +0200, Leon Romanovsky wrote:
> > > On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote:
> > > > I prefer revisions to single patches (as opposed to large patch series)
> > > > in the same thread.
> > >
> > > It depends which side you are in that game. From the reviewer point of
> > > view, such submission breaks flow very badly. It unfolds the already
> > > reviewed thread, messes with the order and many more little annoying
> > > things.
> >
> > This is where I disagree with you. I am a reviewer here.
>
> It is ok, different people have different views.
>
> >
> > Not having context to be able to inspect vN -> vN+1 is made
> > more difficult not having the original patch available and
> > having to search history for it.
>
> I'm following after specific subsystems and see all patches there,
> so for me and Jakub context already exists.
>
> Bottom line, it depends on the workflow.
>
> >
> > Almost no one adds URL links to older submissions below the ---.
>
> Too bad, maybe it is time to enforce it.
>
> >
> > Were that a standard mechanism below the --- line, then it would
> > be OK.
>
> So let's me summarize, we (RDMA and netdev subsystems) would like to ask
> do not submit new patch revisions as reply-to.
>
> Thanks
--
Доброї вам пори дня.
next prev parent reply other threads:[~2020-12-15 12:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 10:05 [PATCH] net/mlx4: Use true,false for bool variable Vasyl Gomonovych
2020-12-12 5:25 ` Joe Perches
2020-12-12 17:02 ` Jakub Kicinski
2020-12-14 10:30 ` [PATCH v2] " Vasyl Gomonovych
2020-12-14 11:16 ` Leon Romanovsky
2020-12-14 19:03 ` Jakub Kicinski
2020-12-14 19:15 ` Joe Perches
2020-12-15 5:18 ` Leon Romanovsky
2020-12-15 5:37 ` Joe Perches
2020-12-15 6:18 ` Leon Romanovsky
2020-12-15 12:27 ` Vasyl [this message]
2020-12-14 23:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYXAnJZrxOPTttd4Z1v4f1ixwarxsJpz8YYZNDL_5r4_SkyeQ@mail.gmail.com \
--to=gomonovych@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).