linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Anders Roxell <anders.roxell@linaro.org>,
	miquel.raynal@bootlin.com, boris.brezillon@bootlin.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/memory/Kconfig: Add CONFIG_OF dependency
Date: Sat, 21 Jul 2018 14:53:47 -0700	[thread overview]
Message-ID: <a83ff193-be57-f566-cafb-132075025b56@infradead.org> (raw)
In-Reply-To: <20180721200049.7553-1-anders.roxell@linaro.org>

On 07/21/2018 01:00 PM, Anders Roxell wrote:
> JZ4780_NEMC doesn't depend on OF, and if OF isn't enabled we get this
> error:
> drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
> drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of
>  function ‘of_read_number’; did you mean ‘down_read_nested’?
>  [-Werror=implicit-function-declaration]
>    bank = of_read_number(prop, 1);
>           ^~~~~~~~~~~~~~
>           down_read_nested
> 
> Make JZ4780_NEMC depend on OF.
> 
> Fixes: ab99e11062c1 ("memory: jz4780-nemc: Allow selection of this driver when COMPILE_TEST=y")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/memory/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index a642552dfdc9..63389f075f1d 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -123,7 +123,7 @@ config JZ4780_NEMC
>  	bool "Ingenic JZ4780 SoC NEMC driver"
>  	default y
>  	depends on MACH_JZ4780 || COMPILE_TEST
> -	depends on HAS_IOMEM
> +	depends on HAS_IOMEM && OF
>  	help
>  	  This driver is for the NAND/External Memory Controller (NEMC) in
>  	  the Ingenic JZ4780. This controller is used to handle external
> 


-- 
~Randy

  reply	other threads:[~2018-07-21 21:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-21 20:00 Anders Roxell
2018-07-21 21:53 ` Randy Dunlap [this message]
2018-07-22  6:29   ` Boris Brezillon
2018-07-23  9:34     ` Arnd Bergmann
2018-07-23  9:41       ` Boris Brezillon
2018-07-23 15:40         ` Arnd Bergmann
2018-07-23 16:04           ` Arnd Bergmann
2018-07-23 16:14             ` Boris Brezillon
2018-07-23 18:39               ` Arnd Bergmann
2018-07-23 16:12           ` Boris Brezillon
2018-07-26 23:25         ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a83ff193-be57-f566-cafb-132075025b56@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=anders.roxell@linaro.org \
    --cc=boris.brezillon@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --subject='Re: [PATCH] drivers/memory/Kconfig: Add CONFIG_OF dependency' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).