From: "Handrigan, Paul" <Paul.Handrigan@cirrus.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"Austin, Brian" <Brian.Austin@cirrus.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: cs53l30: Do not ignore errors if mclk is specified
Date: Fri, 29 Jul 2016 18:21:50 +0000 [thread overview]
Message-ID: <a85c897c-66c7-4703-998d-822eb9f77163@EX4.ad.cirrus.com> (raw)
In-Reply-To: <1469745781-31057-1-git-send-email-nicoleotsuka@gmail.com>
On 7/28/16, 5:43 PM, "Nicolin Chen" <nicoleotsuka@gmail.com> wrote:
>When the clock is specified, there could be other errors besides
>the EPROBE_DEFER so don't ignore them.
>
>Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
>---
> sound/soc/codecs/cs53l30.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
>index 2c0d9c4..227c556 100644
>--- a/sound/soc/codecs/cs53l30.c
>+++ b/sound/soc/codecs/cs53l30.c
>@@ -999,8 +999,8 @@ static int cs53l30_i2c_probe(struct i2c_client
>*client,
> /* Check if MCLK provided */
> cs53l30->mclk = devm_clk_get(dev, "mclk");
> if (IS_ERR(cs53l30->mclk)) {
>- if (PTR_ERR(cs53l30->mclk) == -EPROBE_DEFER) {
>- ret = -EPROBE_DEFER;
>+ if (PTR_ERR(cs53l30->mclk) != -ENOENT) {
>+ ret = PTR_ERR(cs53l30->mclk);
> goto error;
> }
> /* Otherwise mark the mclk pointer to NULL */
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
next prev parent reply other threads:[~2016-07-29 18:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 22:43 [PATCH] ASoC: cs53l30: Do not ignore errors if mclk is specified Nicolin Chen
2016-07-29 18:21 ` Handrigan, Paul [this message]
2016-08-01 17:07 ` Applied "ASoC: cs53l30: Do not ignore errors if mclk is specified" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a85c897c-66c7-4703-998d-822eb9f77163@EX4.ad.cirrus.com \
--to=paul.handrigan@cirrus.com \
--cc=Brian.Austin@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).