From: Neil Armstrong <narmstrong@baylibre.com>
To: Huqiang Qin <huqiang.qin@amlogic.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h
Date: Mon, 29 Aug 2022 09:41:24 +0200 [thread overview]
Message-ID: <a9072e3a-2ea5-9da0-a1ba-2be67857e1ba@baylibre.com> (raw)
In-Reply-To: <e32a8c39-1e47-cad1-e093-2cabb2dd37a4@amlogic.com>
On 26/08/2022 13:32, Huqiang Qin wrote:
> Hi Krzysztof,
>
> On 2022/8/25 20:02, Krzysztof Kozlowski wrote:
>> Why? We can see what you did here, but commit msg should explain why you
>> do it...
>
> Sorry, I didn't describe this commit message clearly.
>
> In the future, meson-s4.dtsi will have some nodes that need
> to use the meson-s4-gpio.h file.
>
> e.g.
> (1) Bluetooth enable pin:
> bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
> (2) Audio mute pin:
> spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
> (3) ...
>
> So, this patch was born.
We understand, but since the Upstream linux codebase want to avoid dead code
as much as possible, please defer this patch when node will actually use these gpio defines.
Neil
>
> Best regards,
> Huqiang
>
next prev parent reply other threads:[~2022-08-29 7:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 11:32 [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h Huqiang Qin
2022-08-29 7:41 ` Neil Armstrong [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-29 8:48 Huqiang Qin
2022-08-25 11:51 Huqiang Qin
2022-08-25 12:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9072e3a-2ea5-9da0-a1ba-2be67857e1ba@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=huqiang.qin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).