Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h

Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h

[Huqiang Qin]

Hi Krzysztof,

On 2022/8/25 20:02, Krzysztof Kozlowski wrote:
> Why? We can see what you did here, but commit msg should explain why you
> do it...

Sorry, I didn't describe this commit message clearly.

In the future, meson-s4.dtsi will have some nodes that need
to use the meson-s4-gpio.h file.

e.g.
	(1) Bluetooth enable pin:
		bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
	(2) Audio mute pin:
		spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
	(3) ...

So, this patch was born.

Best regards,
Huqiang

Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h

[Neil Armstrong]

On 26/08/2022 13:32, Huqiang Qin wrote:
> Hi Krzysztof,
> 
> On 2022/8/25 20:02, Krzysztof Kozlowski wrote:
>> Why? We can see what you did here, but commit msg should explain why you
>> do it...
> 
> Sorry, I didn't describe this commit message clearly.
> 
> In the future, meson-s4.dtsi will have some nodes that need
> to use the meson-s4-gpio.h file.
> 
> e.g.
>      (1) Bluetooth enable pin:
>          bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
>      (2) Audio mute pin:
>          spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
>      (3) ...
> 
> So, this patch was born.

We understand, but since the Upstream linux codebase want to avoid dead code
as much as possible, please defer this patch when node will actually use these gpio defines.

Neil

> 
> Best regards,
> Huqiang
> 

Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h

[Huqiang Qin]

Hi Neil,

On 2022/8/29 15:41, Neil Armstrong wrote:
> We understand, but since the Upstream linux codebase want to avoid dead 
> code
> as much as possible, please defer this patch when node will actually use 
> these gpio defines.

Thanks for your explanation, I know what to do.

Best regards,
Huqiang

Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h

[Krzysztof Kozlowski]

On 25/08/2022 14:51, Huqiang Qin wrote:
> Add the included meson-s4-gpio.h in the meson-s4.dtsi
> 

Why? We can see what you did here, but commit msg should explain why you
do it...

Best regards,
Krzysztof

[PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h

[Huqiang Qin]

Add the included meson-s4-gpio.h in the meson-s4.dtsi

Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
---
 arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
index ad50cba42d19..44cce8b0fcef 100644
--- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
@@ -6,6 +6,7 @@
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/gpio/meson-s4-gpio.h>
 
 / {
 	cpus {
-- 
2.37.1