linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jens Axboe <axboe@kernel.dk>,
	Colin Ian King <colin.king@canonical.com>,
	Dan Schatzberg <schatzberg.dan@gmail.com>,
	linux-block@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call
Date: Fri, 19 Mar 2021 10:59:22 +0100	[thread overview]
Message-ID: <a99533a9-d96e-4e45-502b-066fe9286a42@kernel.org> (raw)
In-Reply-To: <d32641ca-e34a-2bfd-9b86-28c95546f434@kernel.dk>

On 18/03/2021 21:42, Jens Axboe wrote:
> On 3/18/21 2:24 PM, Colin Ian King wrote:
>> On 18/03/2021 20:12, Jens Axboe wrote:
>>> On 3/18/21 9:16 AM, Colin King wrote:
>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>
>>>> The 3rd argument to alloc_workqueue should be the max_active count,
>>>> however currently it is the lo->lo_number that is intended for the
>>>> loop%d number. Fix this by adding in the missing max_active count.
>>>
>>> Dan, please fold this (or something similar) in when you're redoing the
>>> series.
>>>
>> Appreciate this fix being picked up. Are we going to lose the SoB?
> 
> If it's being redone, would be silly to have that error in there. Do
> we have a tag that's appropriate for this? I often wonder when I'm
> folding in a fix. Ala Fixes-by: or something like that.

Why it is being redone if it was put into next? And even then, several
other maintainers just apply a fix on top (I think Andrew Morton, Greg
KH, Mark Brown) to avoid rebasing, preserve the history and also give
credits to the fixer.

Anyway, if it is going to be squashed at least SoB would be nice (as Dan
will take Colin's code).

Best regards,
Krzysztof

  parent reply	other threads:[~2021-03-19 10:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 15:16 [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call Colin King
2021-03-18 19:18 ` Muhammad Usama Anjum
2021-03-18 20:12 ` Jens Axboe
2021-03-18 20:24   ` Colin Ian King
2021-03-18 20:42     ` Jens Axboe
2021-03-19  9:47       ` Dan Carpenter
2021-03-19 10:03         ` Krzysztof Kozlowski
2021-03-19 13:02         ` Jens Axboe
2021-03-19  9:59       ` Krzysztof Kozlowski [this message]
2021-03-19 13:05         ` Jens Axboe
2021-03-19 15:51   ` Dan Schatzberg
2021-03-19 15:54 ` Dan Schatzberg
2021-03-19 15:56   ` Colin Ian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a99533a9-d96e-4e45-502b-066fe9286a42@kernel.org \
    --to=krzk@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schatzberg.dan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).