linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] AppArmor: Fix kernel-doc
@ 2022-10-08  6:34 Jiapeng Chong
  2022-10-08  6:34 ` [PATCH 2/3] LSM: " Jiapeng Chong
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Jiapeng Chong @ 2022-10-08  6:34 UTC (permalink / raw)
  To: john.johansen
  Cc: paul, jmorris, serge, apparmor, linux-security-module,
	linux-kernel, Jiapeng Chong, Abaci Robot

security/apparmor/audit.c:93: warning: expecting prototype for audit_base(). Prototype was for audit_pre() instead.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2339
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 security/apparmor/audit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/audit.c b/security/apparmor/audit.c
index 8dfdda98fbf1..5a7978aa4b19 100644
--- a/security/apparmor/audit.c
+++ b/security/apparmor/audit.c
@@ -83,7 +83,7 @@ static const char *const aa_class_names[] = {
  */
 
 /**
- * audit_base - core AppArmor function.
+ * audit_pre() - core AppArmor function.
  * @ab: audit buffer to fill (NOT NULL)
  * @ca: audit structure containing data to audit (NOT NULL)
  *
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] LSM: Fix kernel-doc
  2022-10-08  6:34 [PATCH 1/3] AppArmor: Fix kernel-doc Jiapeng Chong
@ 2022-10-08  6:34 ` Jiapeng Chong
  2022-10-11  2:07   ` John Johansen
  2022-10-08  6:34 ` [PATCH 3/3] AppArmor: " Jiapeng Chong
  2022-10-11  2:07 ` [PATCH 1/3] " John Johansen
  2 siblings, 1 reply; 6+ messages in thread
From: Jiapeng Chong @ 2022-10-08  6:34 UTC (permalink / raw)
  To: john.johansen
  Cc: paul, jmorris, serge, apparmor, linux-security-module,
	linux-kernel, Jiapeng Chong, Abaci Robot

security/apparmor/lsm.c:753: warning: expecting prototype for apparmor_bprm_committed_cred(). Prototype was for apparmor_bprm_committed_creds() instead.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2338
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 security/apparmor/lsm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index cc83cbf2ce20..c56afd1307c1 100644
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -746,7 +746,7 @@ static void apparmor_bprm_committing_creds(struct linux_binprm *bprm)
 }
 
 /**
- * apparmor_bprm_committed_cred - do cleanup after new creds committed
+ * apparmor_bprm_committed_creds() - do cleanup after new creds committed
  * @bprm: binprm for the exec  (NOT NULL)
  */
 static void apparmor_bprm_committed_creds(struct linux_binprm *bprm)
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/3] AppArmor: Fix kernel-doc
  2022-10-08  6:34 [PATCH 1/3] AppArmor: Fix kernel-doc Jiapeng Chong
  2022-10-08  6:34 ` [PATCH 2/3] LSM: " Jiapeng Chong
@ 2022-10-08  6:34 ` Jiapeng Chong
  2022-10-11  2:08   ` John Johansen
  2022-10-11  2:07 ` [PATCH 1/3] " John Johansen
  2 siblings, 1 reply; 6+ messages in thread
From: Jiapeng Chong @ 2022-10-08  6:34 UTC (permalink / raw)
  To: john.johansen
  Cc: paul, jmorris, serge, apparmor, linux-security-module,
	linux-kernel, Jiapeng Chong, Abaci Robot

security/apparmor/ipc.c:53: warning: expecting prototype for audit_cb(). Prototype was for audit_signal_cb() instead.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2337
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 security/apparmor/ipc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/ipc.c b/security/apparmor/ipc.c
index 1d4099385bdf..5acde746775f 100644
--- a/security/apparmor/ipc.c
+++ b/security/apparmor/ipc.c
@@ -45,7 +45,7 @@ static const char *audit_signal_mask(u32 mask)
 }
 
 /**
- * audit_cb - call back for signal specific audit fields
+ * audit_signal_cb() - call back for signal specific audit fields
  * @ab: audit_buffer  (NOT NULL)
  * @va: audit struct to audit values of  (NOT NULL)
  */
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/3] AppArmor: Fix kernel-doc
  2022-10-08  6:34 [PATCH 1/3] AppArmor: Fix kernel-doc Jiapeng Chong
  2022-10-08  6:34 ` [PATCH 2/3] LSM: " Jiapeng Chong
  2022-10-08  6:34 ` [PATCH 3/3] AppArmor: " Jiapeng Chong
@ 2022-10-11  2:07 ` John Johansen
  2 siblings, 0 replies; 6+ messages in thread
From: John Johansen @ 2022-10-11  2:07 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: paul, jmorris, serge, apparmor, linux-security-module,
	linux-kernel, Abaci Robot

On 10/7/22 23:34, Jiapeng Chong wrote:
> security/apparmor/audit.c:93: warning: expecting prototype for audit_base(). Prototype was for audit_pre() instead.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2339
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Acked-by: John Johansen <john.johansen@canonical.com>

I have pulled this into my tree

> ---
>   security/apparmor/audit.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/audit.c b/security/apparmor/audit.c
> index 8dfdda98fbf1..5a7978aa4b19 100644
> --- a/security/apparmor/audit.c
> +++ b/security/apparmor/audit.c
> @@ -83,7 +83,7 @@ static const char *const aa_class_names[] = {
>    */
>   
>   /**
> - * audit_base - core AppArmor function.
> + * audit_pre() - core AppArmor function.
>    * @ab: audit buffer to fill (NOT NULL)
>    * @ca: audit structure containing data to audit (NOT NULL)
>    *


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/3] LSM: Fix kernel-doc
  2022-10-08  6:34 ` [PATCH 2/3] LSM: " Jiapeng Chong
@ 2022-10-11  2:07   ` John Johansen
  0 siblings, 0 replies; 6+ messages in thread
From: John Johansen @ 2022-10-11  2:07 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: paul, jmorris, serge, apparmor, linux-security-module,
	linux-kernel, Abaci Robot

On 10/7/22 23:34, Jiapeng Chong wrote:
> security/apparmor/lsm.c:753: warning: expecting prototype for apparmor_bprm_committed_cred(). Prototype was for apparmor_bprm_committed_creds() instead.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2338
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Acked-by: John Johansen <john.johansen@canonical.com>

I have pulled this into my tree

> ---
>   security/apparmor/lsm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index cc83cbf2ce20..c56afd1307c1 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -746,7 +746,7 @@ static void apparmor_bprm_committing_creds(struct linux_binprm *bprm)
>   }
>   
>   /**
> - * apparmor_bprm_committed_cred - do cleanup after new creds committed
> + * apparmor_bprm_committed_creds() - do cleanup after new creds committed
>    * @bprm: binprm for the exec  (NOT NULL)
>    */
>   static void apparmor_bprm_committed_creds(struct linux_binprm *bprm)


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 3/3] AppArmor: Fix kernel-doc
  2022-10-08  6:34 ` [PATCH 3/3] AppArmor: " Jiapeng Chong
@ 2022-10-11  2:08   ` John Johansen
  0 siblings, 0 replies; 6+ messages in thread
From: John Johansen @ 2022-10-11  2:08 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: paul, jmorris, serge, apparmor, linux-security-module,
	linux-kernel, Abaci Robot

On 10/7/22 23:34, Jiapeng Chong wrote:
> security/apparmor/ipc.c:53: warning: expecting prototype for audit_cb(). Prototype was for audit_signal_cb() instead.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2337
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Acked-by: John Johansen <john.johansen@canonical.com>

I have pulled this into my tree

> ---
>   security/apparmor/ipc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/ipc.c b/security/apparmor/ipc.c
> index 1d4099385bdf..5acde746775f 100644
> --- a/security/apparmor/ipc.c
> +++ b/security/apparmor/ipc.c
> @@ -45,7 +45,7 @@ static const char *audit_signal_mask(u32 mask)
>   }
>   
>   /**
> - * audit_cb - call back for signal specific audit fields
> + * audit_signal_cb() - call back for signal specific audit fields
>    * @ab: audit_buffer  (NOT NULL)
>    * @va: audit struct to audit values of  (NOT NULL)
>    */


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-10-11  2:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-08  6:34 [PATCH 1/3] AppArmor: Fix kernel-doc Jiapeng Chong
2022-10-08  6:34 ` [PATCH 2/3] LSM: " Jiapeng Chong
2022-10-11  2:07   ` John Johansen
2022-10-08  6:34 ` [PATCH 3/3] AppArmor: " Jiapeng Chong
2022-10-11  2:08   ` John Johansen
2022-10-11  2:07 ` [PATCH 1/3] " John Johansen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).