linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the net tree
@ 2021-07-08 21:31 Stephen Rothwell
  2021-07-08 21:38 ` Florian Fainelli
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2021-07-08 21:31 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Florian Fainelli, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

Hi all,

In commit

  9615fe36b31d ("skbuff: Fix build with SKB extensions disabled")

Fixes tag

  Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")

has these problem(s):

  - No SHA1 recognised

Not worth rebasing for, just more care next time.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2021-07-08 21:31 linux-next: Fixes tag needs some work in the net tree Stephen Rothwell
@ 2021-07-08 21:38 ` Florian Fainelli
  2021-07-08 21:44   ` Eric Dumazet
  0 siblings, 1 reply; 73+ messages in thread
From: Florian Fainelli @ 2021-07-08 21:38 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

On 7/8/21 2:31 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   9615fe36b31d ("skbuff: Fix build with SKB extensions disabled")
> 
> Fixes tag
> 
>   Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> Not worth rebasing for, just more care next time.

It is there though:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=8550ff8d8c75416e984d9c4b082845e57e560984

and has the proper format AFAICT, what am I missing?
-- 
Florian

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2021-07-08 21:38 ` Florian Fainelli
@ 2021-07-08 21:44   ` Eric Dumazet
  2021-07-08 21:45     ` Florian Fainelli
  0 siblings, 1 reply; 73+ messages in thread
From: Eric Dumazet @ 2021-07-08 21:44 UTC (permalink / raw)
  To: Florian Fainelli, Stephen Rothwell, David Miller, Networking
  Cc: Linux Kernel Mailing List, Linux Next Mailing List



On 7/8/21 11:38 PM, Florian Fainelli wrote:
> On 7/8/21 2:31 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>>   9615fe36b31d ("skbuff: Fix build with SKB extensions disabled")
>>
>> Fixes tag
>>
>>   Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
>>
>> has these problem(s):
>>
>>   - No SHA1 recognised
>>
>> Not worth rebasing for, just more care next time.
> 
> It is there though:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=8550ff8d8c75416e984d9c4b082845e57e560984
> 
> and has the proper format AFAICT, what am I missing?
> 

This commit was the first commit, adding the bug.

Your commit changelog had :

    Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Reviewed-by: Roi Dayan <roid@nvidia.com>
    Reviewed-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

See the extra Fixes: word ?


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2021-07-08 21:44   ` Eric Dumazet
@ 2021-07-08 21:45     ` Florian Fainelli
  0 siblings, 0 replies; 73+ messages in thread
From: Florian Fainelli @ 2021-07-08 21:45 UTC (permalink / raw)
  To: Eric Dumazet, Stephen Rothwell, David Miller, Networking
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

On 7/8/21 2:44 PM, Eric Dumazet wrote:
> 
> 
> On 7/8/21 11:38 PM, Florian Fainelli wrote:
>> On 7/8/21 2:31 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>>   9615fe36b31d ("skbuff: Fix build with SKB extensions disabled")
>>>
>>> Fixes tag
>>>
>>>   Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
>>>
>>> has these problem(s):
>>>
>>>   - No SHA1 recognised
>>>
>>> Not worth rebasing for, just more care next time.
>>
>> It is there though:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=8550ff8d8c75416e984d9c4b082845e57e560984
>>
>> and has the proper format AFAICT, what am I missing?
>>
> 
> This commit was the first commit, adding the bug.
> 
> Your commit changelog had :
> 
>     Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
>     Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>     Reviewed-by: Roi Dayan <roid@nvidia.com>
>     Reviewed-by: Eric Dumazet <edumazet@google.com>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> See the extra Fixes: word ?

Doh! yes, sorry about that.
-- 
Florian

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-11-22 21:00 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2021-11-22 21:00 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Wen Gu, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Hi all,

In commit

  7a61432dc813 ("net/smc: Avoid warning of possible recursive locking")

Fixes tag

  Fixes: 2153bd1e3d3d ("Transfer remaining wait queue entries during fallback")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-10-27 20:42 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2021-10-27 20:42 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Jie Wang, Guangbin Huang, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Hi all,

In commit

  6754614a787c ("net: hns3: add more string spaces for dumping packets number of queue info in debugfs")

Fixes tag

  Fixes: e44c495d95e ("net: hns3: refactor queue info of debugfs")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-09-10 12:50 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2021-09-10 12:50 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Ariel Elior, Shai Malin, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

Hi all,

In commit

  20e100f52730 ("qed: Handle management FW error")

Fixes tag

  Fixes: tag 5e7ba042fd05 ("qed: Fix reading stale configuration information")

has these problem(s):

  - No SHA1 recognised

In the future, just use:

  git log -1 --format='Fixes: %h ("%s")' <commit>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2021-08-24  2:12 ` Shreyansh Chouhan
@ 2021-08-24  2:29   ` Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2021-08-24  2:29 UTC (permalink / raw)
  To: Shreyansh Chouhan
  Cc: David Miller, Networking, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

Hi Shreyansh,

On Tue, 24 Aug 2021 07:42:31 +0530 Shreyansh Chouhan <chouhan.shreyansh630@gmail.com> wrote:
>
> Apologies for the wrong fixes tag.
> 
> Since the patch is already in the tree, (and since this is the first
> time I am facing this,) I wanted to ask if I should resend the patch
> with the correct fixes tag to fix this.

The only way it can be fixed is to rebase the tree it is in.  However,
Dave does not rebase his trees, so you should just take this as a
learning experience and remember for next time.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2021-08-22 21:54 Stephen Rothwell
@ 2021-08-24  2:12 ` Shreyansh Chouhan
  2021-08-24  2:29   ` Stephen Rothwell
  0 siblings, 1 reply; 73+ messages in thread
From: Shreyansh Chouhan @ 2021-08-24  2:12 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Kernel Mailing List,
	Linux Next Mailing List

Hi Stephen,

Apologies for the wrong fixes tag.

Since the patch is already in the tree, (and since this is the first
time I am facing this,) I wanted to ask if I should resend the patch
with the correct fixes tag to fix this.

Thank you for your review.

Regards,
Shreyansh Chouhan

On Mon, Aug 23, 2021 at 07:54:32AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   9cf448c200ba ("ip6_gre: add validation for csum_start")
> 
> Fixes tag
> 
>   Fixes: Fixes: b05229f44228 ("gre6: Cleanup GREv6 transmit path, call common
> 
> has these problem(s):
> 
>   - Extra word "Fixes:"
> 
> Also, please do not split Fixes tags over more than one line.
> 
> -- 
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-08-22 21:54 Stephen Rothwell
  2021-08-24  2:12 ` Shreyansh Chouhan
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2021-08-22 21:54 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Shreyansh Chouhan, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

Hi all,

In commit

  9cf448c200ba ("ip6_gre: add validation for csum_start")

Fixes tag

  Fixes: Fixes: b05229f44228 ("gre6: Cleanup GREv6 transmit path, call common

has these problem(s):

  - Extra word "Fixes:"

Also, please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-08-16 21:56 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2021-08-16 21:56 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Xin Long, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

Hi all,

In commit

  7387a72c5f84 ("tipc: call tipc_wait_for_connect only when dlen is not 0")

Fixes tag

  Fixes: 36239dab6da7 ("tipc: fix implicit-connect for SYN+")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: f8dd60de1948 ("tipc: fix implicit-connect for SYN+")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2021-07-13 22:26 Stephen Rothwell
@ 2021-07-14  8:29 ` Pavel Skripkin
  0 siblings, 0 replies; 73+ messages in thread
From: Pavel Skripkin @ 2021-07-14  8:29 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Kernel Mailing List,
	Linux Next Mailing List

On Wed, 14 Jul 2021 08:26:53 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   deb7178eb940 ("net: fddi: fix UAF in fza_probe")
> 
> Fixes tag
> 
>   Fixes: 61414f5ec983 ("FDDI: defza: Add support for DEC
> FDDIcontroller 700
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 

Hi, Stephen and net developers!

This is definitely my fault, I am sorry for that :(

What can I do about it? Should I send revert and v2 or maybe some
addition steps needed?

> Please do not split Fixes tags over more than one line.
> 


With regards,
Pavel Skripkin


^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-07-13 22:26 Stephen Rothwell
  2021-07-14  8:29 ` Pavel Skripkin
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2021-07-13 22:26 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Pavel Skripkin, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

Hi all,

In commit

  deb7178eb940 ("net: fddi: fix UAF in fza_probe")

Fixes tag

  Fixes: 61414f5ec983 ("FDDI: defza: Add support for DEC FDDIcontroller 700

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-06-24 21:45 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2021-06-24 21:45 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Sukadev Bhattiprolu, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

Hi all,

In commit

  0ec13aff058a ("Revert "ibmvnic: simplify reset_long_term_buff function"")

Fixes tag

  Fixes: 1c7d45e7b2c ("ibmvnic: simplify reset_long_term_buff function")

has these problem(s):

  - SHA1 should be at least 12 digits long

This can be fixed for the future by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2021-06-08  6:23 ` Ido Schimmel
@ 2021-06-08  8:53   ` Petr Machata
  0 siblings, 0 replies; 73+ messages in thread
From: Petr Machata @ 2021-06-08  8:53 UTC (permalink / raw)
  To: Ido Schimmel
  Cc: Stephen Rothwell, David Miller, Networking, Petr Machata,
	Linux Kernel Mailing List, Linux Next Mailing List


Ido Schimmel <idosch@nvidia.com> writes:

> On Tue, Jun 08, 2021 at 08:53:25AM +1000, Stephen Rothwell wrote:
>> Hi all,
>> 
>> In commit
>> 
>>   d566ed04e42b ("mlxsw: spectrum_qdisc: Pass handle, not band number to find_class()")
>> 
>> Fixes tag
>> 
>>   Fixes: 28052e618b04 ("mlxsw: spectrum_qdisc: Track children per qdisc")
>> 
>> has these problem(s):
>> 
>>   - Target SHA1 does not exist
>> 
>> Maybe you meant
>> 
>> Fixes: 51d52ed95550 ("mlxsw: spectrum_qdisc: Track children per qdisc")
>
> Yes, correct. Sorry about that. The first was an internal tag. Will
> double-check next time.

My mistake. I must have been looking into the wrong checkout when I was
hunting for the reference.

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2021-06-07 22:53 Stephen Rothwell
@ 2021-06-08  6:23 ` Ido Schimmel
  2021-06-08  8:53   ` Petr Machata
  0 siblings, 1 reply; 73+ messages in thread
From: Ido Schimmel @ 2021-06-08  6:23 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Petr Machata,
	Linux Kernel Mailing List, Linux Next Mailing List

On Tue, Jun 08, 2021 at 08:53:25AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   d566ed04e42b ("mlxsw: spectrum_qdisc: Pass handle, not band number to find_class()")
> 
> Fixes tag
> 
>   Fixes: 28052e618b04 ("mlxsw: spectrum_qdisc: Track children per qdisc")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 51d52ed95550 ("mlxsw: spectrum_qdisc: Track children per qdisc")

Yes, correct. Sorry about that. The first was an internal tag. Will
double-check next time.

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-06-07 22:53 Stephen Rothwell
  2021-06-08  6:23 ` Ido Schimmel
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2021-06-07 22:53 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Petr Machata, Ido Schimmel, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

Hi all,

In commit

  d566ed04e42b ("mlxsw: spectrum_qdisc: Pass handle, not band number to find_class()")

Fixes tag

  Fixes: 28052e618b04 ("mlxsw: spectrum_qdisc: Track children per qdisc")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 51d52ed95550 ("mlxsw: spectrum_qdisc: Track children per qdisc")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-05-25 22:33 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2021-05-25 22:33 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Yang Li, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi all,

In commit

  c1cf1afd8b0f ("net: hns: Fix kernel-doc")

Fixes tag

  Fixes: 'commit 262b38cdb3e4 ("net: ethernet: hisilicon: hns: use phydev

has these problem(s):

  - No SHA1 recognised

Please just use

git log -1 --format='Fixes: %h ("%s")' <commit>

and dont split FIxes tags over more than one line.

So

Fixes: 262b38cdb3e4 ("net: ethernet: hisilicon: hns: use phydev from struct net_device")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-05-04 21:57 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2021-05-04 21:57 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Or Cohen, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

In commit

  c61760e6940d ("net/nfc: fix use-after-free llcp_sock_bind/connect")

Fixes tag

  Fixes: c33b1cc62 ("nfc: fix refcount leak in llcp_sock_bind()")

has these problem(s):

  - SHA1 should be at least 12 digits long

This is probably not worth rebasing to fix.  In the future this can be
avoided by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-03-21 20:48 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2021-03-21 20:48 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Corentin Labbe, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

Hi all,

In commit

  014dfa26ce1c ("net: stmmac: dwmac-sun8i: Provide TX and RX fifo sizes")

Fixes tag

  Fixes: 9f93ac8d408 ("net-next: stmmac: Add dwmac-sun8i")

has these problem(s):

  - SHA1 should be at least 12 digits long

I don't think this is worth rebasing to fix, but it can be fixed for
future commits by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-03-15 21:57 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2021-03-15 21:57 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Alexander Ovechkin, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

Hi all,

In commit

  7233da86697e ("tcp: relookup sock for RST+ACK packets handled by obsolete req sock")

Fixes tag

  Fixes: e0f9759f530 ("tcp: try to keep packet if SYN_RCV race is lost")

has these problem(s):

  - SHA1 should be at least 12 digits long

This is not worth rebasing for, but can be avoided in the future by
setting core.abbrev to 12 (or more) or (for git v2.11 or later) just
making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2021-03-04  3:19 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2021-03-04  3:19 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Atish Patra, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

Hi all,

In commit

  b12422362ce9 ("net: macb: Add default usrio config to default gem config")

Fixes tag

  Fixes: edac63861db7 ("add userio bits as platform configuration")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes: edac63861db7 ("net: macb: add userio bits as platform configuration")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2020-09-20 19:59 Stephen Rothwell
@ 2020-09-21  6:04 ` Sven Eckelmann
  0 siblings, 0 replies; 73+ messages in thread
From: Sven Eckelmann @ 2020-09-21  6:04 UTC (permalink / raw)
  To: David Miller, Networking, Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Linus Lüssing, Simon Wunderlich

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

On Sunday, 20 September 2020 21:59:19 CEST Stephen Rothwell wrote:
> Hi all,

Yes, I've accidentally swapped the IDs while adding them to the various patches.

The correct ones should have been:

* 097930e85f90 ("batman-adv: bla: fix type misuse for backbone_gw hash indexing")

  Fixes: 07568d0369f9 ("batman-adv: don't rely on positions in struct for hashing")
  (seems to be correct)

* 7dda5b338412 ("batman-adv: mcast/TT: fix wrongly dropped or rerouted packets")

  Fixes: 279e89b2281a ("batman-adv: bla: use netif_rx_ni when not in interrupt context")
  (seems to be correct)

* 4bba9dab86b6 ("batman-adv: Add missing include for in_interrupt()")

  Fixes: 279e89b2281a ("batman-adv: bla: use netif_rx_ni when not in interrupt context")
  (seems to be correct)

* 3236d215ad38 ("batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN")

  Fixes: a44ebeff6bbd ("batman-adv: Fix multicast TT issues with bogus ROAM flags")
  (this was wrong)

* 74c09b727512 ("batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh")

  Fixes: 2d3f6ccc4ea5 ("batman-adv: check incoming packet type for bla")
  (this was wrong)

* 2369e8270469 ("batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh")

  Fixes: fe2da6ff27c7 ("batman-adv: add broadcast duplicate check")
  (this was wrong)

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2020-09-20 19:59 Stephen Rothwell
  2020-09-21  6:04 ` Sven Eckelmann
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2020-09-20 19:59 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Linus Lüssing, Simon Wunderlich, Sven Eckelmann

[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]

Hi all,

In commit

  2369e8270469 ("batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh")

Fixes tag

  Fixes: 279e89b2281a ("batman-adv: add broadcast duplicate check")

has these problem(s):

  - Subject does not match target commit subject

Did you mean:

Fixes: 279e89b2281a ("batman-adv: bla: use netif_rx_ni when not in interrupt context")

or

Fixes: fe2da6ff27c7 ("batman-adv: add broadcast duplicate check")


In commit

  74c09b727512 ("batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh")

Fixes tag

  Fixes: fe2da6ff27c7 ("batman-adv: check incoming packet type for bla")

has these problem(s):

  - Subject does not match target commit subject

Did you mean

Fixes: fe2da6ff27c7 ("batman-adv: add broadcast duplicate check")

or

Fixes 2d3f6ccc4ea5 ("batman-adv: check incoming packet type for bla")


In commit

  3236d215ad38 ("batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN")

Fixes tag

  Fixes: 2d3f6ccc4ea5 ("batman-adv: Modified forwarding behaviour for multicast packets")

has these problem(s):

  - Subject does not match target commit subject

Did you mean

Fixes 2d3f6ccc4ea5 ("batman-adv: check incoming packet type for bla")
(I could find no commit with subject "batman-adv: Modified forwarding
behaviour for multicast packets".)
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2020-08-17  5:53 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2020-08-17  5:53 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Florian Westphal

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Hi all,

In commit

  b3b2854dcf70 ("mptcp: sendmsg: reset iter on error redux")

Fixes tag

  Fixes: 35759383133f64d "(mptcp: sendmsg: reset iter on error)"

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2020-04-22 22:06 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2020-04-22 22:06 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Yuiko Oshino

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi all,

In commit

  63edbcceef61 ("net: phy: microchip_t1: add lan87xx_phy_init to initialize the lan87xx phy.")

Fixes tag

  Fixes: 3e50d2da5850 ("Add driver for Microchip LAN87XX T1 PHYs")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2020-04-02 20:59 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2020-04-02 20:59 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, kbuild test robot

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi all,

n commit

  bf88dc327de8 ("net: dsa: dsa_bridge_mtu_normalization() can be static")

Fixes tag

  Fixes: f41071407c85 ("net: dsa: implement auto-normalization of MTU for bridge hardware datapath")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: bff33f7e2ae2 ("net: dsa: implement auto-normalization of MTU for bridge hardware datapath")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2020-03-04  5:08 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2020-03-04  5:08 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jacob Keller

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi all,

In commit

  707518348ae7 ("devlink: remove trigger command from devlink-region.rst")

Fixes tag

  Fixes: 0b0f945f5458 ("devlink: add a file documenting devlink regions", 2020-01-10)

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2020-02-19 20:33 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2020-02-19 20:33 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Hamdan Igbaria, Alex Vesker, Saeed Mahameed

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

n commit

  52d214976d4f ("net/mlx5: DR, Fix matching on vport gvmi")

Fixes tag

  Fixes: 26d688e3 ("net/mlx5: DR, Add Steering entry (STE) utilities")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2020-02-18 20:45 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2020-02-18 20:45 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Michal Kalderon, Ariel Elior

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi all,

In commit

  af6565adb02d ("qede: Fix race between rdma destroy workqueue and link change event")

Fixes tag

  Fixes: cee9fbd8e2e ("qede: Add qedr framework")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2020-01-19  1:06 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2020-01-19  1:06 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Florian Fainelli

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hi all,

In commit

  8f1880cbe8d0 ("net: dsa: bcm_sf2: Configure IMP port for 2Gb/sec")

Fixes tag

  Fixes: 01b0ac07589e ("net: dsa: bcm_sf2: Add support for optional reset controller line")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: eee87e4377a4 ("net: dsa: bcm_sf2: Add support for optional reset controller line")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2020-01-10  8:15 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2020-01-10  8:15 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Radoslaw Tyl

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

Hi all,

In commit

  aa604651d523 ("ixgbevf: Remove limit of 10 entries for unicast filter list")

Fixes tag

  Fixes: 46ec20ff7d ("ixgbevf: Add macvlan support in the set rx mode op")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2020-01-08 10:10 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2020-01-08 10:10 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jiping Ma

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi all,

In commit

  481a7d154cbb ("stmmac: debugfs entry name is not be changed when udev rename device name.")

Fixes tag

  Fixes: b6601323ef9e ("net: stmmac: debugfs entry name is not be changed when udev rename")

has these problem(s):

  - Target SHA1 does not exist

Also, please keep all the commit message tags together at the end of
the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2020-01-03  3:38 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2020-01-03  3:38 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Baruch Siach

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

Hi all,

In commit

  f7a48b68abd9 ("net: dsa: mv88e6xxx: force cmode write on 6141/6341")

Fixes tag

  Fixes: 7a3007d22e8 ("net: dsa: mv88e6xxx: fully support SERDES on Topaz family")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2019-11-20  9:50 Stephen Rothwell
@ 2019-11-20 14:14 ` Willem de Bruijn
  0 siblings, 0 replies; 73+ messages in thread
From: Willem de Bruijn @ 2019-11-20 14:14 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List

On Wed, Nov 20, 2019 at 4:50 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> n commit
>
>   d4ffb02dee2f ("net/tls: enable sk_msg redirect to tls socket egress")
>
> Fixes tag
>
>   Fixes: f3de19af0f5b ("Revert \"net/tls: remove unused function tls_sw_sendpage_locked\"")
>
> has these problem(s):
>
>   - Subject does not match target commit subject
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'
>
> Did you mean:
>
> Fixes: f3de19af0f5b ("net/tls: remove unused function tls_sw_sendpage_locked")

Indeed. I messed up the subject line, sorry. That is what it should
have looked line.

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-11-20  9:50 Stephen Rothwell
  2019-11-20 14:14 ` Willem de Bruijn
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2019-11-20  9:50 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Willem de Bruijn

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Hi all,

n commit

  d4ffb02dee2f ("net/tls: enable sk_msg redirect to tls socket egress")

Fixes tag

  Fixes: f3de19af0f5b ("Revert \"net/tls: remove unused function tls_sw_sendpage_locked\"")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean:

Fixes: f3de19af0f5b ("net/tls: remove unused function tls_sw_sendpage_locked")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-11-07 10:04 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-11-07 10:04 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Dmytro Linkin, Saeed Mahameed

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

Hi all,

In commit

  950d3af70ea8 ("net/mlx5e: Use correct enum to determine uplink port")

Fixes tag

  Fixes: bb204dcf39fe ("net/mlx5e: Determine source port properly for vlan push action")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: d5dbcc4e87bc ("net/mlx5e: Determine source port properly for vlan push action")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-10-30  7:37 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-10-30  7:37 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Xin Long

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Hi all,

In commit

  2eb8d6d2910c ("erspan: fix the tun_info options_len check for erspan")

Fixes tag

  Fixes: 1a66a836da ("gre: add collect_md mode to ERSPAN tunnel")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-10-27 20:13 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-10-27 20:13 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, wenxu,
	Pablo Neira Ayuso

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Hi all,

In commit

  a69a85da458f ("netfilter: nft_payload: fix missing check for matching length in offloads")

Fixes tag

  Fixes: 92ad6325cb89 ("netfilter: nf_tables: add hardware offload support")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: c9626a2cbdb2 ("netfilter: nf_tables: add hardware offload support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* RE: linux-next: Fixes tag needs some work in the net tree
  2019-10-11  4:11 Stephen Rothwell
@ 2019-10-11 20:06 ` Keller, Jacob E
  0 siblings, 0 replies; 73+ messages in thread
From: Keller, Jacob E @ 2019-10-11 20:06 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jakub Kicinski

> -----Original Message-----
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On
> Behalf Of Stephen Rothwell
> Sent: Thursday, October 10, 2019 9:11 PM
> To: David Miller <davem@davemloft.net>; Networking
> <netdev@vger.kernel.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Keller, Jacob E <jacob.e.keller@intel.com>;
> Jakub Kicinski <jakub.kicinski@netronome.com>
> Subject: linux-next: Fixes tag needs some work in the net tree
> 
> Hi all,
> 
> In commit
> 
>   2168da459404 ("net: update net_dim documentation after rename")
> 
> Fixes tag
> 
>   Fixes: 8960b38932be ("linux/dim: Rename externally used net_dim members",
> 2019-06-25)
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Fixes tag
> 
>   Fixes: c002bd529d71 ("linux/dim: Rename externally exposed macros", 2019-06-
> 25)
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Right, that was my mistake. I have an alias for this that is what was used by other projects (which prefer adding the date), and it's supposed to be set to only this in my local tree for the kernel, but not sure what happened there.

> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-10-11  4:11 Stephen Rothwell
  2019-10-11 20:06 ` Keller, Jacob E
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2019-10-11  4:11 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jacob Keller,
	Jakub Kicinski

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

Hi all,

In commit

  2168da459404 ("net: update net_dim documentation after rename")

Fixes tag

  Fixes: 8960b38932be ("linux/dim: Rename externally used net_dim members", 2019-06-25)

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Fixes tag

  Fixes: c002bd529d71 ("linux/dim: Rename externally exposed macros", 2019-06-25)

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-09-28 18:51 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-09-28 18:51 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Kevin(Yudong) Yang

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Hi all,

In commit

  6b3656a60f20 ("tcp_bbr: fix quantization code to not raise cwnd if not probing bandwidth")

Fixes tag

  Fixes: 3c346b233c68 ("tcp_bbr: fix bw probing to raise in-flight data for very small BDPs")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 383d470936c0 ("tcp_bbr: fix bw probing to raise in-flight data for very small BDPs")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-08-18 21:33 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-08-18 21:33 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Vasundhara Volam, Michael Chan

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Hi all,

In commit

  dd2ebf3404c7 ("bnxt_en: Fix handling FRAG_ERR when NVM_INSTALL_UPDATE cmd fails")

Fixes tag

  Fixes: cb4d1d626145 ("bnxt_en: Retry failed NVM_INSTALL_UPDATE with defragmentation flag enabled.")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-08-11 21:33 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-08-11 21:33 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Roman Mashak

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

Hi all,

In commit

  e1fea322fc6d ("net sched: update skbedit action for batched events operations")

Fixes tag

  Fixes: ca9b0e27e ("pkt_action: add new action skbedit")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This Can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-08-06 21:22 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-08-06 21:22 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Roman Mashak

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

Hi all,

In commit

  b35475c5491a ("net sched: update vlan action for batched events operations")

Fixes tag

  Fixes: c7e2b9689 ("sched: introduce vlan action")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2019-07-14 12:15   ` Stephen Rothwell
@ 2019-07-14 12:17     ` Tariq Toukan
  0 siblings, 0 replies; 73+ messages in thread
From: Tariq Toukan @ 2019-07-14 12:17 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Saeed Mahameed



On 7/14/2019 3:15 PM, Stephen Rothwell wrote:
> Hi Tariq,
> 
> On Sun, 14 Jul 2019 07:55:48 +0000 Tariq Toukan <tariqt@mellanox.com> wrote:
>>
>> How do you think we should handle this?
> 
> Dave doesn't rebase his trees, so all you can really do is learn from
> it and not do it again :-)
> 

Sure.
My bad, used the SHA1 I had on my internal branch.

Thanks,
Tariq

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2019-07-14  7:55 ` Tariq Toukan
@ 2019-07-14 12:15   ` Stephen Rothwell
  2019-07-14 12:17     ` Tariq Toukan
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2019-07-14 12:15 UTC (permalink / raw)
  To: Tariq Toukan
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Saeed Mahameed

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

Hi Tariq,

On Sun, 14 Jul 2019 07:55:48 +0000 Tariq Toukan <tariqt@mellanox.com> wrote:
>
> How do you think we should handle this?

Dave doesn't rebase his trees, so all you can really do is learn from
it and not do it again :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2019-07-12  6:50 Stephen Rothwell
@ 2019-07-14  7:55 ` Tariq Toukan
  2019-07-14 12:15   ` Stephen Rothwell
  0 siblings, 1 reply; 73+ messages in thread
From: Tariq Toukan @ 2019-07-14  7:55 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Saeed Mahameed



On 7/12/2019 9:50 AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    c93dfec10f1d ("net/mlx5e: Fix compilation error in TLS code")
> 
> Fixes tag
> 
>    Fixes: 90687e1a9a50 ("net/mlx5: Kconfig, Better organize compilation flags")
> 
> has these problem(s):
> 
>    - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: e2869fb2068b ("net/mlx5: Kconfig, Better organize compilation flags")
> 

Right.
Thank you Stephen!
How do you think we should handle this?

Tariq

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-07-12  6:50 Stephen Rothwell
  2019-07-14  7:55 ` Tariq Toukan
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2019-07-12  6:50 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Tariq Toukan,
	Saeed Mahameed

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Hi all,

In commit

  c93dfec10f1d ("net/mlx5e: Fix compilation error in TLS code")

Fixes tag

  Fixes: 90687e1a9a50 ("net/mlx5: Kconfig, Better organize compilation flags")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: e2869fb2068b ("net/mlx5: Kconfig, Better organize compilation flags")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* RE: linux-next: Fixes tag needs some work in the net tree
  2019-06-23 21:47 Stephen Rothwell
@ 2019-06-24  1:51 ` Voon, Weifeng
  0 siblings, 0 replies; 73+ messages in thread
From: Voon, Weifeng @ 2019-06-24  1:51 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ong, Boon Leong

> Hi all,
> 
> In commit
> 
>   d0bb82fd6018 ("net: stmmac: set IC bit when transmitting frames with
> HW timestamp")
> 
> Fixes tag
> 
>   Fixes: f748be531d70 ("net: stmmac: Rework coalesce timer and fix
> multi-queue races")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Fixes: f748be531d70 ("stmmac: support new GMAC4")
> 
> or did you mean
> 
> Fixes: 8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-
> queue races")
> 

Sorry for the confusion, what I meant is:
Fixes: 8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-
queue races")

Regards,
Weifeng

> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-06-23 21:47 Stephen Rothwell
  2019-06-24  1:51 ` Voon, Weifeng
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2019-06-23 21:47 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Roland Hii,
	Ong Boon Leong, Voon Weifeng

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

Hi all,

In commit

  d0bb82fd6018 ("net: stmmac: set IC bit when transmitting frames with HW timestamp")

Fixes tag

  Fixes: f748be531d70 ("net: stmmac: Rework coalesce timer and fix multi-queue races")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Fixes: f748be531d70 ("stmmac: support new GMAC4")

or did you mean

Fixes: 8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-queue races")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-06-10 18:37 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-06-10 18:37 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Alexander Dahl, Marc Kleine-Budde

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Hi all,

In commit

  0ed89d777dd6 ("can: usb: Kconfig: Remove duplicate menu entry")

Fixes tag

  Fixes: ffbdd9172ee2f53020f763574b4cdad8d9760a4f

has these problem(s):

  - missing subject

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-05-30 21:52 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-05-30 21:52 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Parav Pandit,
	Saeed Mahameed

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

Hi all,

In commit

  9414277a5df3 ("net/mlx5: Avoid double free in fs init error unwinding path")

Fixes tag

  Fixes: 40c3eebb49e51 ("net/mlx5: Add support in RDMA RX steering")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 905f6bd30bb6 ("net/mlx5: Avoid double free of root ns in the error flow path")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-05-23 21:35 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-05-23 21:35 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Raju Rangoju

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi all,

In commit

  b5730061d105 ("cxgb4: offload VLAN flows regardless of VLAN ethtype")

Fixes tag

  Fixes: ad9af3e09c (cxgb4: add tc flower match support for vlan)

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-05-19  1:55 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-05-19  1:55 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Junwei Hu

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

Hi all,

In commit

  532b0f7ece4c ("tipc: fix modprobe tipc failed after switch order of device registration")

Fixes tag

  Fixes: 7e27e8d6130c

has these problem(s):

  - missing subject

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-05-05 21:23 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-05-05 21:23 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, David Ahern

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

Hi all,

In commit

  64c6f4bbca74 ("neighbor: Reset gc_entries counter if new entry is released before insert")

Fixes tag

  Fixes: 58956317c8d ("neighbor: Improve garbage collection")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-04-28  6:49 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-04-28  6:49 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Eric Dumazet

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Hi all,

In commit

  c1c477217882 ("l2tp: use rcu_dereference_sk_user_data() in l2tp_udp_encap_recv()")

Fixes tag

  Fixes: d00fa9adc528 ("il2tp: fix races with tunnel socket close")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: d00fa9adc528 ("l2tp: fix races with tunnel socket close")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2019-04-11 21:12 Stephen Rothwell
@ 2019-04-12  7:19 ` Ursula Braun
  0 siblings, 0 replies; 73+ messages in thread
From: Ursula Braun @ 2019-04-12  7:19 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Karsten Graul



On 4/11/19 11:12 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   8ef659f1a840 ("net/smc: fix return code from FLUSH command")
> 
> Fixes tag
> 
>   Fixes: a9d8b0b1e3d6 ("net/smc: add pnet table namespace support")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
> 

Sorry, my fault. And yes, we meant
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")


^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-04-11 21:12 Stephen Rothwell
  2019-04-12  7:19 ` Ursula Braun
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2019-04-11 21:12 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Karsten Graul, Ursula Braun

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Hi all,

In commit

  8ef659f1a840 ("net/smc: fix return code from FLUSH command")

Fixes tag

  Fixes: a9d8b0b1e3d6 ("net/smc: add pnet table namespace support")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2019-04-11  7:37   ` David Miller
@ 2019-04-11  7:56     ` Jason Wang
  0 siblings, 0 replies; 73+ messages in thread
From: Jason Wang @ 2019-04-11  7:56 UTC (permalink / raw)
  To: David Miller; +Cc: sfr, netdev, linux-next, linux-kernel


On 2019/4/11 下午3:37, David Miller wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Thu, 11 Apr 2019 15:24:59 +0800
>
>> My bad, need I respin or just leave it as is this time?
> You can't fix it if it's already in my tree.


I see. Thanks


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2019-04-11  7:24 ` Jason Wang
@ 2019-04-11  7:37   ` David Miller
  2019-04-11  7:56     ` Jason Wang
  0 siblings, 1 reply; 73+ messages in thread
From: David Miller @ 2019-04-11  7:37 UTC (permalink / raw)
  To: jasowang; +Cc: sfr, netdev, linux-next, linux-kernel

From: Jason Wang <jasowang@redhat.com>
Date: Thu, 11 Apr 2019 15:24:59 +0800

> My bad, need I respin or just leave it as is this time?

You can't fix it if it's already in my tree.

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2019-04-11  6:58 Stephen Rothwell
@ 2019-04-11  7:24 ` Jason Wang
  2019-04-11  7:37   ` David Miller
  0 siblings, 1 reply; 73+ messages in thread
From: Jason Wang @ 2019-04-11  7:24 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List


On 2019/4/11 下午2:58, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>    813dbeb656d6 ("vhost: reject zero size iova range")
>
> Fixes tag
>
>    Fixes: 6b1e6cc7 ("vhost: new device IOTLB API")
>
> has these problem(s):
>
>    - SHA1 should be at least 12 digits long
>      Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>      or later) just making sure it is not set (or set to "auto").
>

My bad, need I respin or just leave it as is this time?

Thanks


^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-04-11  6:58 Stephen Rothwell
  2019-04-11  7:24 ` Jason Wang
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2019-04-11  6:58 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jason Wang

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

Hi all,

In commit

  813dbeb656d6 ("vhost: reject zero size iova range")

Fixes tag

  Fixes: 6b1e6cc7 ("vhost: new device IOTLB API")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2019-03-29  3:26 Stephen Rothwell
@ 2019-03-29 16:46 ` Jeff Kirsher
  0 siblings, 0 replies; 73+ messages in thread
From: Jeff Kirsher @ 2019-03-29 16:46 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Arvind Sankar

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

On Fri, 2019-03-29 at 14:26 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   dabb8338be53 ("igb: Fix WARN_ONCE on runtime suspend")
> 
> Fixes tag
> 
>   Fixes: fb29f76cc566 ("igb: Fix an issue that PME is not enabled during
> runtime suspend")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean:
> 
> Fixes: 1fb3a7a75e2e ("igb: Fix an issue that PME is not enabled during
> runtime suspend")
> 

Yes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-03-29  3:26 Stephen Rothwell
  2019-03-29 16:46 ` Jeff Kirsher
  0 siblings, 1 reply; 73+ messages in thread
From: Stephen Rothwell @ 2019-03-29  3:26 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Arvind Sankar, Jeff Kirsher

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

Hi all,

In commit

  dabb8338be53 ("igb: Fix WARN_ONCE on runtime suspend")

Fixes tag

  Fixes: fb29f76cc566 ("igb: Fix an issue that PME is not enabled during runtime suspend")

has these problem(s):

  - Target SHA1 does not exist

Did you mean:

Fixes: 1fb3a7a75e2e ("igb: Fix an issue that PME is not enabled during runtime suspend")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2019-03-19 21:15 Stephen Rothwell
  2019-03-20  7:26 ` Kalle Valo
@ 2019-03-20  9:45 ` Lorenzo Bianconi
  1 sibling, 0 replies; 73+ messages in thread
From: Lorenzo Bianconi @ 2019-03-20  9:45 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Lorenzo Bianconi, Kalle Valo,
	Wireless

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

> Hi all,
> 
> In commit
> 
>   13f61dfc5235 ("mt76: fix schedule while atomic in mt76x02_reset_state")
> 
> Fixes tag
> 
>   Fixes: e4ebb8b403d1 ("mt76: mt76x2: implement full device restart on watchdog reset")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean:
> 
>   004960423fe1 ("mt76: mt76x2: implement full device restart on watchdog reset")

Hi Stephen,

yes, the right Fixes tag is:
004960423fe1 ("mt76: mt76x2: implement full device restart on watchdog reset")

Sorry for the mistake.

Regards,
Lorenzo

> 
> -- 
> Cheers,
> Stephen Rothwell



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: linux-next: Fixes tag needs some work in the net tree
  2019-03-19 21:15 Stephen Rothwell
@ 2019-03-20  7:26 ` Kalle Valo
  2019-03-20  9:45 ` Lorenzo Bianconi
  1 sibling, 0 replies; 73+ messages in thread
From: Kalle Valo @ 2019-03-20  7:26 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Lorenzo Bianconi, Wireless

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> In commit
>
>   13f61dfc5235 ("mt76: fix schedule while atomic in mt76x02_reset_state")
>
> Fixes tag
>
>   Fixes: e4ebb8b403d1 ("mt76: mt76x2: implement full device restart on watchdog reset")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Did you mean:
>
>   004960423fe1 ("mt76: mt76x2: implement full device restart on watchdog reset")

Sorry, I missed this but too late to fix now.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-03-19 21:15 Stephen Rothwell
  2019-03-20  7:26 ` Kalle Valo
  2019-03-20  9:45 ` Lorenzo Bianconi
  0 siblings, 2 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-03-19 21:15 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Lorenzo Bianconi, Kalle Valo, Wireless

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Hi all,

In commit

  13f61dfc5235 ("mt76: fix schedule while atomic in mt76x02_reset_state")

Fixes tag

  Fixes: e4ebb8b403d1 ("mt76: mt76x2: implement full device restart on watchdog reset")

has these problem(s):

  - Target SHA1 does not exist

Did you mean:

  004960423fe1 ("mt76: mt76x2: implement full device restart on watchdog reset")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-03-19  5:20 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-03-19  5:20 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Yoshiki Komachi

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hi all,

In commit

  18bed89107a4 ("af_packet: fix the tx skb protocol in raw sockets with ETH_P_ALL")

Fixes tag

  Fixes: 75c65772c3 ("net/packet: Ask driver for protocol if not provided by user")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-02-28 20:32 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-02-28 20:32 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sheng Lan,
	Eric Dumazet

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

Hi all,

In commit

  5845f706388a ("net: netem: fix skb length BUG_ON in __skb_to_sgvec")

Fixes tag

  Fixes: 35d889d1 ("sch_netem: fix skb leak in netem_enqueue()")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-02-12 20:04 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-02-12 20:04 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Li RongQing

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

Hi all,

In commit

  d1f20798a119 ("ipv6: propagate genlmsg_reply return code")

Fixes tag

  Fixes: 915d7e5e593 ("ipv6: sr: add code base for control plane support of SR-IPv6")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-02-10 20:14 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-02-10 20:14 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ursula Braun

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

Hi all,

In commit

  ccc8ca9b90ac ("net/smc: fix byte_order for rx_curs_confirmed")

Fixes tag

  Fixes: b8649efad879 ("net/smc: fix sender_free computation") (net-tree)

has these problem(s):

  - The trailing '(net-tree)' is unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

* linux-next: Fixes tag needs some work in the net tree
@ 2019-01-20  4:10 Stephen Rothwell
  0 siblings, 0 replies; 73+ messages in thread
From: Stephen Rothwell @ 2019-01-20  4:10 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Eli Britstein, Oz Shlomo

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

Hi all,

In commit

  25f2d0e7791e ("net/mlx5e: Fix cb_ident duplicate in indirect block register")

Fixes tag

  Fixes: f5bc2c5de101 ("net/mlx5e: Support TC indirect block notifications

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

The Fixes tag line was split over 2 lines.  Please, in the future, try
to keep it on a single line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 73+ messages in thread

end of thread, other threads:[~2021-11-22 21:01 UTC | newest]

Thread overview: 73+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 21:31 linux-next: Fixes tag needs some work in the net tree Stephen Rothwell
2021-07-08 21:38 ` Florian Fainelli
2021-07-08 21:44   ` Eric Dumazet
2021-07-08 21:45     ` Florian Fainelli
  -- strict thread matches above, loose matches on Subject: below --
2021-11-22 21:00 Stephen Rothwell
2021-10-27 20:42 Stephen Rothwell
2021-09-10 12:50 Stephen Rothwell
2021-08-22 21:54 Stephen Rothwell
2021-08-24  2:12 ` Shreyansh Chouhan
2021-08-24  2:29   ` Stephen Rothwell
2021-08-16 21:56 Stephen Rothwell
2021-07-13 22:26 Stephen Rothwell
2021-07-14  8:29 ` Pavel Skripkin
2021-06-24 21:45 Stephen Rothwell
2021-06-07 22:53 Stephen Rothwell
2021-06-08  6:23 ` Ido Schimmel
2021-06-08  8:53   ` Petr Machata
2021-05-25 22:33 Stephen Rothwell
2021-05-04 21:57 Stephen Rothwell
2021-03-21 20:48 Stephen Rothwell
2021-03-15 21:57 Stephen Rothwell
2021-03-04  3:19 Stephen Rothwell
2020-09-20 19:59 Stephen Rothwell
2020-09-21  6:04 ` Sven Eckelmann
2020-08-17  5:53 Stephen Rothwell
2020-04-22 22:06 Stephen Rothwell
2020-04-02 20:59 Stephen Rothwell
2020-03-04  5:08 Stephen Rothwell
2020-02-19 20:33 Stephen Rothwell
2020-02-18 20:45 Stephen Rothwell
2020-01-19  1:06 Stephen Rothwell
2020-01-10  8:15 Stephen Rothwell
2020-01-08 10:10 Stephen Rothwell
2020-01-03  3:38 Stephen Rothwell
2019-11-20  9:50 Stephen Rothwell
2019-11-20 14:14 ` Willem de Bruijn
2019-11-07 10:04 Stephen Rothwell
2019-10-30  7:37 Stephen Rothwell
2019-10-27 20:13 Stephen Rothwell
2019-10-11  4:11 Stephen Rothwell
2019-10-11 20:06 ` Keller, Jacob E
2019-09-28 18:51 Stephen Rothwell
2019-08-18 21:33 Stephen Rothwell
2019-08-11 21:33 Stephen Rothwell
2019-08-06 21:22 Stephen Rothwell
2019-07-12  6:50 Stephen Rothwell
2019-07-14  7:55 ` Tariq Toukan
2019-07-14 12:15   ` Stephen Rothwell
2019-07-14 12:17     ` Tariq Toukan
2019-06-23 21:47 Stephen Rothwell
2019-06-24  1:51 ` Voon, Weifeng
2019-06-10 18:37 Stephen Rothwell
2019-05-30 21:52 Stephen Rothwell
2019-05-23 21:35 Stephen Rothwell
2019-05-19  1:55 Stephen Rothwell
2019-05-05 21:23 Stephen Rothwell
2019-04-28  6:49 Stephen Rothwell
2019-04-11 21:12 Stephen Rothwell
2019-04-12  7:19 ` Ursula Braun
2019-04-11  6:58 Stephen Rothwell
2019-04-11  7:24 ` Jason Wang
2019-04-11  7:37   ` David Miller
2019-04-11  7:56     ` Jason Wang
2019-03-29  3:26 Stephen Rothwell
2019-03-29 16:46 ` Jeff Kirsher
2019-03-19 21:15 Stephen Rothwell
2019-03-20  7:26 ` Kalle Valo
2019-03-20  9:45 ` Lorenzo Bianconi
2019-03-19  5:20 Stephen Rothwell
2019-02-28 20:32 Stephen Rothwell
2019-02-12 20:04 Stephen Rothwell
2019-02-10 20:14 Stephen Rothwell
2019-01-20  4:10 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).