From: Chris Metcalf <cmetcalf@mellanox.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Russell King <linux@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Aaron Tomlin <atomlin@redhat.com>, Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@osdl.org>,
Daniel Thompson <daniel.thompson@linaro.org>, <x86@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-arch@vger.kernel.org>
Subject: Re: [PATCH v8 4/4] nmi_backtrace: generate one-line reports for idle cpus
Date: Mon, 29 Aug 2016 11:46:52 -0400 [thread overview]
Message-ID: <aa556fe4-901c-196b-d3a1-ab92a701cbaa@mellanox.com> (raw)
In-Reply-To: <20160818151211.GN13300@pathway.suse.cz>
On 8/18/2016 11:12 AM, Petr Mladek wrote:
> On Tue 2016-08-16 15:50:24, Chris Metcalf wrote:
>> [...]
>> -static inline void native_safe_halt(void)
>> +static __always_inline void native_safe_halt(void)
>> {
>> asm volatile("sti; hlt": : :"memory");
>> }
> Ah, the __always_inline stuff did not helped here. It was
> not inlined:
>
> $> nm -n vmlinux | grep native_safe_halt
> ffffffff81050bc0 t native_safe_halt
>
> The reason seems to be that it is called via
> PVOP_VCALL0(pv_irq_ops.safe_halt);, see below
> in the disassembly.
>
> I guess that it is because I have
> CONFIG_PARAVIRT=y
I fixed this by reverting to using __cpuidle instead of __always_inline.
As you discovered, we can't use <linux/cpu.h> here, but I chose to
just duplicate the #define of __cpuidle in <asm/irqflags.h> instead
since I think that's cleaner.
--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com
next prev parent reply other threads:[~2016-08-29 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1471377024-2244-1-git-send-email-cmetcalf@mellanox.com>
2016-08-16 19:50 ` [PATCH v8 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-08-18 14:12 ` Petr Mladek
2016-08-20 1:54 ` Chris Metcalf
2016-08-22 8:33 ` Petr Mladek
2016-08-16 19:50 ` [PATCH v8 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-08-16 19:50 ` [PATCH v8 3/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-08-16 19:50 ` [PATCH v8 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-08-18 15:12 ` Petr Mladek
2016-08-29 15:46 ` Chris Metcalf [this message]
2016-08-18 15:46 ` [PATCH v8 0/4] improvements to the nmi_backtrace code Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa556fe4-901c-196b-d3a1-ab92a701cbaa@mellanox.com \
--to=cmetcalf@mellanox.com \
--cc=akpm@osdl.org \
--cc=atomlin@redhat.com \
--cc=daniel.thompson@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).