From: Stefan Wahren <stefan.wahren@i2se.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Adrian Hunter <adrian.hunter@intel.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Matthias Brugger <mbrugger@suse.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
wahrenst@gmx.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711
Date: Fri, 4 Oct 2019 15:07:50 +0200 [thread overview]
Message-ID: <aacf6c56-e156-41b4-40b9-e8228ab63fcd@i2se.com> (raw)
In-Reply-To: <0b544f5bc31857fef2d13bd16275cf09ace58b89.camel@suse.de>
Am 04.10.19 um 14:59 schrieb Nicolas Saenz Julienne:
> On Fri, 2019-10-04 at 14:52 +0200, Nicolas Saenz Julienne wrote:
>> The Raspberry Pi 4 SDHCI hardware seems to automatically issue CMD12
>> after multiblock reads even when ACMD12 is disabled. This triggers
>> spurious interrupts after the data transfer is done with the following
>> message:
>>
>> mmc1: Got data interrupt 0x00000002 even though no data operation was in
>> progress.
>> mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
>> mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00001002
>> mmc1: sdhci: Blk size: 0x00007200 | Blk cnt: 0x00000000
>> mmc1: sdhci: Argument: 0x00000000 | Trn mode: 0x00000033
>> mmc1: sdhci: Present: 0x1fff0000 | Host ctl: 0x00000017
>> mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000080
>> mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
>> mmc1: sdhci: Timeout: 0x00000000 | Int stat: 0x00000000
>> mmc1: sdhci: Int enab: 0x03ff100b | Sig enab: 0x03ff100b
>> mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
>> mmc1: sdhci: Caps: 0x45ee6432 | Caps_1: 0x0000a525
>> mmc1: sdhci: Cmd: 0x00000c1a | Max curr: 0x00080008
>> mmc1: sdhci: Resp[0]: 0x00000b00 | Resp[1]: 0x00edc87f
>> mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00400e00
>> mmc1: sdhci: Host ctl2: 0x00000001
>> mmc1: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xf3025208
>> mmc1: sdhci: ============================================
>>
>> Enable SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable ACMD12 on multiblock
>> reads and suppress the spurious interrupts.
>>
>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>> Tested-by: Matthias Brugger <mbrugger@suse.com>
> Forgot to add:
>
> Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM2711")
>
> I'll resend if needed.
Yes, please and you can add my:
Acked-by: Stefan Wahren <wahrenst@gmx.net>
>
> Regards,
> Nicolas
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-04 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 12:52 [PATCH] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711 Nicolas Saenz Julienne
2019-10-04 12:59 ` Nicolas Saenz Julienne
2019-10-04 13:07 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aacf6c56-e156-41b4-40b9-e8228ab63fcd@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=adrian.hunter@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=ulf.hansson@linaro.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).