* [PATCH] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711
@ 2019-10-04 12:52 Nicolas Saenz Julienne
2019-10-04 12:59 ` Nicolas Saenz Julienne
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Saenz Julienne @ 2019-10-04 12:52 UTC (permalink / raw)
To: Adrian Hunter, Ray Jui, Scott Branden, bcm-kernel-feedback-list
Cc: wahrenst, Nicolas Saenz Julienne, Matthias Brugger, Ulf Hansson,
linux-mmc, linux-arm-kernel, linux-kernel
The Raspberry Pi 4 SDHCI hardware seems to automatically issue CMD12
after multiblock reads even when ACMD12 is disabled. This triggers
spurious interrupts after the data transfer is done with the following
message:
mmc1: Got data interrupt 0x00000002 even though no data operation was in progress.
mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00001002
mmc1: sdhci: Blk size: 0x00007200 | Blk cnt: 0x00000000
mmc1: sdhci: Argument: 0x00000000 | Trn mode: 0x00000033
mmc1: sdhci: Present: 0x1fff0000 | Host ctl: 0x00000017
mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000080
mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
mmc1: sdhci: Timeout: 0x00000000 | Int stat: 0x00000000
mmc1: sdhci: Int enab: 0x03ff100b | Sig enab: 0x03ff100b
mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
mmc1: sdhci: Caps: 0x45ee6432 | Caps_1: 0x0000a525
mmc1: sdhci: Cmd: 0x00000c1a | Max curr: 0x00080008
mmc1: sdhci: Resp[0]: 0x00000b00 | Resp[1]: 0x00edc87f
mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00400e00
mmc1: sdhci: Host ctl2: 0x00000001
mmc1: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xf3025208
mmc1: sdhci: ============================================
Enable SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable ACMD12 on multiblock
reads and suppress the spurious interrupts.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Tested-by: Matthias Brugger <mbrugger@suse.com>
---
drivers/mmc/host/sdhci-iproc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 2b9cdcd1dd9d..f4f5f0a70cda 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -262,6 +262,7 @@ static const struct sdhci_iproc_data bcm2835_data = {
};
static const struct sdhci_pltfm_data sdhci_bcm2711_pltfm_data = {
+ .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
.ops = &sdhci_iproc_32only_ops,
};
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711
2019-10-04 12:52 [PATCH] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711 Nicolas Saenz Julienne
@ 2019-10-04 12:59 ` Nicolas Saenz Julienne
2019-10-04 13:07 ` Stefan Wahren
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Saenz Julienne @ 2019-10-04 12:59 UTC (permalink / raw)
To: Adrian Hunter, Ray Jui, Scott Branden, bcm-kernel-feedback-list
Cc: wahrenst, Matthias Brugger, Ulf Hansson, linux-mmc,
linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]
On Fri, 2019-10-04 at 14:52 +0200, Nicolas Saenz Julienne wrote:
> The Raspberry Pi 4 SDHCI hardware seems to automatically issue CMD12
> after multiblock reads even when ACMD12 is disabled. This triggers
> spurious interrupts after the data transfer is done with the following
> message:
>
> mmc1: Got data interrupt 0x00000002 even though no data operation was in
> progress.
> mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
> mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00001002
> mmc1: sdhci: Blk size: 0x00007200 | Blk cnt: 0x00000000
> mmc1: sdhci: Argument: 0x00000000 | Trn mode: 0x00000033
> mmc1: sdhci: Present: 0x1fff0000 | Host ctl: 0x00000017
> mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000080
> mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
> mmc1: sdhci: Timeout: 0x00000000 | Int stat: 0x00000000
> mmc1: sdhci: Int enab: 0x03ff100b | Sig enab: 0x03ff100b
> mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
> mmc1: sdhci: Caps: 0x45ee6432 | Caps_1: 0x0000a525
> mmc1: sdhci: Cmd: 0x00000c1a | Max curr: 0x00080008
> mmc1: sdhci: Resp[0]: 0x00000b00 | Resp[1]: 0x00edc87f
> mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00400e00
> mmc1: sdhci: Host ctl2: 0x00000001
> mmc1: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xf3025208
> mmc1: sdhci: ============================================
>
> Enable SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable ACMD12 on multiblock
> reads and suppress the spurious interrupts.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Tested-by: Matthias Brugger <mbrugger@suse.com>
Forgot to add:
Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM2711")
I'll resend if needed.
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711
2019-10-04 12:59 ` Nicolas Saenz Julienne
@ 2019-10-04 13:07 ` Stefan Wahren
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Wahren @ 2019-10-04 13:07 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Adrian Hunter, Ray Jui, Scott Branden,
bcm-kernel-feedback-list
Cc: Ulf Hansson, Matthias Brugger, linux-mmc, linux-kernel, wahrenst,
linux-arm-kernel
Am 04.10.19 um 14:59 schrieb Nicolas Saenz Julienne:
> On Fri, 2019-10-04 at 14:52 +0200, Nicolas Saenz Julienne wrote:
>> The Raspberry Pi 4 SDHCI hardware seems to automatically issue CMD12
>> after multiblock reads even when ACMD12 is disabled. This triggers
>> spurious interrupts after the data transfer is done with the following
>> message:
>>
>> mmc1: Got data interrupt 0x00000002 even though no data operation was in
>> progress.
>> mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
>> mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00001002
>> mmc1: sdhci: Blk size: 0x00007200 | Blk cnt: 0x00000000
>> mmc1: sdhci: Argument: 0x00000000 | Trn mode: 0x00000033
>> mmc1: sdhci: Present: 0x1fff0000 | Host ctl: 0x00000017
>> mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000080
>> mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
>> mmc1: sdhci: Timeout: 0x00000000 | Int stat: 0x00000000
>> mmc1: sdhci: Int enab: 0x03ff100b | Sig enab: 0x03ff100b
>> mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
>> mmc1: sdhci: Caps: 0x45ee6432 | Caps_1: 0x0000a525
>> mmc1: sdhci: Cmd: 0x00000c1a | Max curr: 0x00080008
>> mmc1: sdhci: Resp[0]: 0x00000b00 | Resp[1]: 0x00edc87f
>> mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00400e00
>> mmc1: sdhci: Host ctl2: 0x00000001
>> mmc1: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xf3025208
>> mmc1: sdhci: ============================================
>>
>> Enable SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable ACMD12 on multiblock
>> reads and suppress the spurious interrupts.
>>
>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>> Tested-by: Matthias Brugger <mbrugger@suse.com>
> Forgot to add:
>
> Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM2711")
>
> I'll resend if needed.
Yes, please and you can add my:
Acked-by: Stefan Wahren <wahrenst@gmx.net>
>
> Regards,
> Nicolas
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-04 13:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 12:52 [PATCH] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711 Nicolas Saenz Julienne
2019-10-04 12:59 ` Nicolas Saenz Julienne
2019-10-04 13:07 ` Stefan Wahren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).