From: Waiman Long <llong@redhat.com>
To: Boqun Feng <boqun.feng@gmail.com>, Xiongwei Song <sxwjean@gmail.com>
Cc: Waiman Long <llong@redhat.com>, Xiongwei Song <sxwjean@me.com>,
peterz@infradead.org, mingo@redhat.com, will@kernel.org,
corbet@lwn.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] docs: lockdep-design: correct the notation for writer
Date: Mon, 24 May 2021 09:42:20 -0400 [thread overview]
Message-ID: <ab3c5c38-1447-99e1-ee22-9e5af906d8b4@redhat.com> (raw)
In-Reply-To: <YKuAvt3WXBVASuhY@boqun-archlinux>
On 5/24/21 6:32 AM, Boqun Feng wrote:
> On Mon, May 24, 2021 at 12:24:00PM +0800, Xiongwei Song wrote:
>> On Fri, May 21, 2021 at 11:17 PM Waiman Long <llong@redhat.com> wrote:
>>> On 5/21/21 2:29 AM, Xiongwei Song wrote:
>>>> From: Xiongwei Song <sxwjean@gmail.com>
>>>>
>>>> The block condition matrix is using 'E' as the writer noation here, so it
>>>> would be better to use 'E' as the reminder rather than 'W'.
>>>>
>>>> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
>>>> ---
>>>> Documentation/locking/lockdep-design.rst | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
>>>> index 9f3cfca..c3b923a 100644
>>>> --- a/Documentation/locking/lockdep-design.rst
>>>> +++ b/Documentation/locking/lockdep-design.rst
>>>> @@ -462,7 +462,7 @@ Block condition matrix, Y means the row blocks the column, and N means otherwise
>>>> | R | Y | Y | N |
>>>> +---+---+---+---+
>>>>
>>>> - (W: writers, r: non-recursive readers, R: recursive readers)
>>>> + (E: writers, r: non-recursive readers, R: recursive readers)
>>>>
>>>>
>>>> acquired recursively. Unlike non-recursive read locks, recursive read locks
>>> I would say it should be the other way around. Both W and E refer to the
>>> same type of lockers. W emphasizes writer aspect of it and E for
>>> exclusive. I think we should change the block condition matrix to use W
>>> instead of E.
>> The doc uses 'E' to describe dependency egdes too. Should we change them
>> to 'W'? Personally, both 'W' and 'E' are fine.
>>
> I also think Waiman's suggestion is solid, there are two ways to
> classify locks:
>
> 1. W (Writers), R (Recursive Readers), r (Non-recursive Readers)
>
> 2. E (Exclusive locks), S (Shared locks), R (Recursive Readers),
> N (Non-recursive locks)
>
> And the relations between them are as follow:
>
> E = W
> R = R
> N = W \/ r
> S = R \/ r
>
> , where "\/" is the set union.
>
> The story is that I used the way #1 at first, and later on realized way
> #2 is better for BFS implementation, also for reasoning, so here came
> this leftover..
>
My suggestion was based on the fact that it is harder to associate E
with writer. So from a readability perspective, it is better to change
the block condition matrix to use 'W' to make it more readable.
Cheers,
Longman
next prev parent reply other threads:[~2021-05-24 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 6:29 [PATCH] docs: lockdep-design: correct the notation for writer Xiongwei Song
2021-05-21 8:55 ` Boqun Feng
2021-05-21 11:05 ` Peter Zijlstra
2021-05-21 15:17 ` Waiman Long
2021-05-24 4:24 ` Xiongwei Song
2021-05-24 10:32 ` Boqun Feng
2021-05-24 13:17 ` Xiongwei Song
2021-05-24 13:42 ` Waiman Long [this message]
2021-05-24 14:52 ` Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab3c5c38-1447-99e1-ee22-9e5af906d8b4@redhat.com \
--to=llong@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).