From: Waiman Long <llong@redhat.com>
To: Xiongwei Song <sxwjean@me.com>,
peterz@infradead.org, mingo@redhat.com, will@kernel.org,
boqun.feng@gmail.com, corbet@lwn.net
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Xiongwei Song <sxwjean@gmail.com>
Subject: Re: [PATCH] docs: lockdep-design: correct the notation for writer
Date: Fri, 21 May 2021 11:17:32 -0400 [thread overview]
Message-ID: <e0c0302f-e63f-7eba-872b-85e21b0b1622@redhat.com> (raw)
In-Reply-To: <1621578594-13237-1-git-send-email-sxwjean@me.com>
On 5/21/21 2:29 AM, Xiongwei Song wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
>
> The block condition matrix is using 'E' as the writer noation here, so it
> would be better to use 'E' as the reminder rather than 'W'.
>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
> ---
> Documentation/locking/lockdep-design.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
> index 9f3cfca..c3b923a 100644
> --- a/Documentation/locking/lockdep-design.rst
> +++ b/Documentation/locking/lockdep-design.rst
> @@ -462,7 +462,7 @@ Block condition matrix, Y means the row blocks the column, and N means otherwise
> | R | Y | Y | N |
> +---+---+---+---+
>
> - (W: writers, r: non-recursive readers, R: recursive readers)
> + (E: writers, r: non-recursive readers, R: recursive readers)
>
>
> acquired recursively. Unlike non-recursive read locks, recursive read locks
I would say it should be the other way around. Both W and E refer to the
same type of lockers. W emphasizes writer aspect of it and E for
exclusive. I think we should change the block condition matrix to use W
instead of E.
Cheers,
Longman
next prev parent reply other threads:[~2021-05-21 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 6:29 [PATCH] docs: lockdep-design: correct the notation for writer Xiongwei Song
2021-05-21 8:55 ` Boqun Feng
2021-05-21 11:05 ` Peter Zijlstra
2021-05-21 15:17 ` Waiman Long [this message]
2021-05-24 4:24 ` Xiongwei Song
2021-05-24 10:32 ` Boqun Feng
2021-05-24 13:17 ` Xiongwei Song
2021-05-24 13:42 ` Waiman Long
2021-05-24 14:52 ` Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0c0302f-e63f-7eba-872b-85e21b0b1622@redhat.com \
--to=llong@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).