* [PATCH 0/2] i2c-puv3: Adjustments for puv3_i2c_probe()
@ 2018-02-02 15:00 SF Markus Elfring
2018-02-02 15:01 ` [PATCH 1/2] i2c-puv3: Delete an error message for a failed memory allocation in puv3_i2c_probe() SF Markus Elfring
2018-02-02 15:02 ` [PATCH 2/2] i2c-puv3: Improve a size determination " SF Markus Elfring
0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2018-02-02 15:00 UTC (permalink / raw)
To: linux-i2c, Guan Xuetao, Wolfram Sang; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 15:54:32 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/i2c/busses/i2c-puv3.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
2.16.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] i2c-puv3: Delete an error message for a failed memory allocation in puv3_i2c_probe()
2018-02-02 15:00 [PATCH 0/2] i2c-puv3: Adjustments for puv3_i2c_probe() SF Markus Elfring
@ 2018-02-02 15:01 ` SF Markus Elfring
2018-02-02 15:02 ` [PATCH 2/2] i2c-puv3: Improve a size determination " SF Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: SF Markus Elfring @ 2018-02-02 15:01 UTC (permalink / raw)
To: linux-i2c, Guan Xuetao, Wolfram Sang; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 15:41:26 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/i2c/busses/i2c-puv3.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-puv3.c b/drivers/i2c/busses/i2c-puv3.c
index 287088b8c4c8..5bd001d01bef 100644
--- a/drivers/i2c/busses/i2c-puv3.c
+++ b/drivers/i2c/busses/i2c-puv3.c
@@ -198,7 +198,6 @@ static int puv3_i2c_probe(struct platform_device *pdev)
adapter = kzalloc(sizeof(struct i2c_adapter), GFP_KERNEL);
if (adapter == NULL) {
- dev_err(&pdev->dev, "can't allocate interface!\n");
rc = -ENOMEM;
goto fail_nomem;
}
--
2.16.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] i2c-puv3: Improve a size determination in puv3_i2c_probe()
2018-02-02 15:00 [PATCH 0/2] i2c-puv3: Adjustments for puv3_i2c_probe() SF Markus Elfring
2018-02-02 15:01 ` [PATCH 1/2] i2c-puv3: Delete an error message for a failed memory allocation in puv3_i2c_probe() SF Markus Elfring
@ 2018-02-02 15:02 ` SF Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: SF Markus Elfring @ 2018-02-02 15:02 UTC (permalink / raw)
To: linux-i2c, Guan Xuetao, Wolfram Sang; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 15:43:21 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/i2c/busses/i2c-puv3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-puv3.c b/drivers/i2c/busses/i2c-puv3.c
index 5bd001d01bef..929fd12b92de 100644
--- a/drivers/i2c/busses/i2c-puv3.c
+++ b/drivers/i2c/busses/i2c-puv3.c
@@ -196,7 +196,7 @@ static int puv3_i2c_probe(struct platform_device *pdev)
if (!request_mem_region(mem->start, resource_size(mem), "puv3_i2c"))
return -EBUSY;
- adapter = kzalloc(sizeof(struct i2c_adapter), GFP_KERNEL);
+ adapter = kzalloc(sizeof(*adapter), GFP_KERNEL);
if (adapter == NULL) {
rc = -ENOMEM;
goto fail_nomem;
--
2.16.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-02 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-02 15:00 [PATCH 0/2] i2c-puv3: Adjustments for puv3_i2c_probe() SF Markus Elfring
2018-02-02 15:01 ` [PATCH 1/2] i2c-puv3: Delete an error message for a failed memory allocation in puv3_i2c_probe() SF Markus Elfring
2018-02-02 15:02 ` [PATCH 2/2] i2c-puv3: Improve a size determination " SF Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).