* [PATCH] pstore: fix return type of pstore_is_mounted
@ 2015-10-22 8:02 Geliang Tang
2015-10-22 16:30 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Geliang Tang @ 2015-10-22 8:02 UTC (permalink / raw)
To: Anton Vorontsov, Colin Cross, Kees Cook, Tony Luck
Cc: Geliang Tang, linux-kernel
This patch changes return type of pstore_is_mounted from int to bool.
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
fs/pstore/inode.c | 2 +-
fs/pstore/internal.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
index 3586491..d8c439d 100644
--- a/fs/pstore/inode.c
+++ b/fs/pstore/inode.c
@@ -288,7 +288,7 @@ static const struct super_operations pstore_ops = {
static struct super_block *pstore_sb;
-int pstore_is_mounted(void)
+bool pstore_is_mounted(void)
{
return pstore_sb != NULL;
}
diff --git a/fs/pstore/internal.h b/fs/pstore/internal.h
index 96253c4..e38a22b 100644
--- a/fs/pstore/internal.h
+++ b/fs/pstore/internal.h
@@ -63,6 +63,6 @@ extern int pstore_mkfile(enum pstore_type_id, char *psname, u64 id,
int count, char *data, bool compressed,
size_t size, struct timespec time,
struct pstore_info *psi);
-extern int pstore_is_mounted(void);
+extern bool pstore_is_mounted(void);
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pstore: fix return type of pstore_is_mounted
2015-10-22 8:02 [PATCH] pstore: fix return type of pstore_is_mounted Geliang Tang
@ 2015-10-22 16:30 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2015-10-22 16:30 UTC (permalink / raw)
To: Geliang Tang; +Cc: Anton Vorontsov, Colin Cross, Tony Luck, LKML
On Thu, Oct 22, 2015 at 1:02 AM, Geliang Tang <geliangtang@163.com> wrote:
> This patch changes return type of pstore_is_mounted from int to bool.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
Sure! :)
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> fs/pstore/inode.c | 2 +-
> fs/pstore/internal.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
> index 3586491..d8c439d 100644
> --- a/fs/pstore/inode.c
> +++ b/fs/pstore/inode.c
> @@ -288,7 +288,7 @@ static const struct super_operations pstore_ops = {
>
> static struct super_block *pstore_sb;
>
> -int pstore_is_mounted(void)
> +bool pstore_is_mounted(void)
> {
> return pstore_sb != NULL;
> }
> diff --git a/fs/pstore/internal.h b/fs/pstore/internal.h
> index 96253c4..e38a22b 100644
> --- a/fs/pstore/internal.h
> +++ b/fs/pstore/internal.h
> @@ -63,6 +63,6 @@ extern int pstore_mkfile(enum pstore_type_id, char *psname, u64 id,
> int count, char *data, bool compressed,
> size_t size, struct timespec time,
> struct pstore_info *psi);
> -extern int pstore_is_mounted(void);
> +extern bool pstore_is_mounted(void);
>
> #endif
> --
> 1.9.1
>
>
--
Kees Cook
Chrome OS Security
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-22 16:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-22 8:02 [PATCH] pstore: fix return type of pstore_is_mounted Geliang Tang
2015-10-22 16:30 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).