* [PATCH] arm64: dts: ti: k3-am642-main: fix ports mac properties
@ 2021-06-08 18:49 Grygorii Strashko
2021-06-09 5:12 ` Vignesh Raghavendra
2021-06-11 19:01 ` Nishanth Menon
0 siblings, 2 replies; 3+ messages in thread
From: Grygorii Strashko @ 2021-06-08 18:49 UTC (permalink / raw)
To: Nishanth Menon, Vignesh Raghavendra, Lokesh Vutla, Tero Kristo
Cc: linux-kernel, devicetree, linux-arm-kernel, Grygorii Strashko
The current device tree CPSW3g node adds non-zero "mac-address" property to
the ports, which prevents random MAC address assignment to network devices
if bootloader failed to update DT. This may cause more then one host to
have the same MAC in the network.
mac-address = [00 00 de ad be ef];
mac-address = [00 01 de ad be ef];
In addition, there is one MAC address available in eFuse registers which
can be used for default port 1.
Hence, fix ports MAC properties by:
- resetting "mac-address" property to 0
- adding ti,syscon-efuse = <&main_conf 0x200> to Port 1
Fixes: 3753b12877b6 ("arm64: dts: ti: k3-am64-main: Add CPSW DT node")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index effb9d2e3c25..7f7178a7a055 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -514,7 +514,8 @@
ti,mac-only;
label = "port1";
phys = <&phy_gmii_sel 1>;
- mac-address = [00 00 de ad be ef];
+ mac-address = [00 00 00 00 00 00];
+ ti,syscon-efuse = <&main_conf 0x200>;
};
cpsw_port2: port@2 {
@@ -522,7 +523,7 @@
ti,mac-only;
label = "port2";
phys = <&phy_gmii_sel 2>;
- mac-address = [00 01 de ad be ef];
+ mac-address = [00 00 00 00 00 00];
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-am642-main: fix ports mac properties
2021-06-08 18:49 [PATCH] arm64: dts: ti: k3-am642-main: fix ports mac properties Grygorii Strashko
@ 2021-06-09 5:12 ` Vignesh Raghavendra
2021-06-11 19:01 ` Nishanth Menon
1 sibling, 0 replies; 3+ messages in thread
From: Vignesh Raghavendra @ 2021-06-09 5:12 UTC (permalink / raw)
To: Grygorii Strashko, Nishanth Menon, Lokesh Vutla, Tero Kristo
Cc: linux-kernel, devicetree, linux-arm-kernel
On 6/9/21 12:19 AM, Grygorii Strashko wrote:
> The current device tree CPSW3g node adds non-zero "mac-address" property to
> the ports, which prevents random MAC address assignment to network devices
> if bootloader failed to update DT. This may cause more then one host to
> have the same MAC in the network.
>
> mac-address = [00 00 de ad be ef];
> mac-address = [00 01 de ad be ef];
>
> In addition, there is one MAC address available in eFuse registers which
> can be used for default port 1.
>
> Hence, fix ports MAC properties by:
> - resetting "mac-address" property to 0
> - adding ti,syscon-efuse = <&main_conf 0x200> to Port 1
>
> Fixes: 3753b12877b6 ("arm64: dts: ti: k3-am64-main: Add CPSW DT node")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index effb9d2e3c25..7f7178a7a055 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -514,7 +514,8 @@
> ti,mac-only;
> label = "port1";
> phys = <&phy_gmii_sel 1>;
> - mac-address = [00 00 de ad be ef];
> + mac-address = [00 00 00 00 00 00];
> + ti,syscon-efuse = <&main_conf 0x200>;
> };
>
> cpsw_port2: port@2 {
> @@ -522,7 +523,7 @@
> ti,mac-only;
> label = "port2";
> phys = <&phy_gmii_sel 2>;
> - mac-address = [00 01 de ad be ef];
> + mac-address = [00 00 00 00 00 00];
> };
> };
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-am642-main: fix ports mac properties
2021-06-08 18:49 [PATCH] arm64: dts: ti: k3-am642-main: fix ports mac properties Grygorii Strashko
2021-06-09 5:12 ` Vignesh Raghavendra
@ 2021-06-11 19:01 ` Nishanth Menon
1 sibling, 0 replies; 3+ messages in thread
From: Nishanth Menon @ 2021-06-11 19:01 UTC (permalink / raw)
To: Grygorii Strashko, Vignesh Raghavendra, Tero Kristo, Lokesh Vutla
Cc: Nishanth Menon, linux-arm-kernel, linux-kernel, devicetree
On Tue, 8 Jun 2021 21:49:40 +0300, Grygorii Strashko wrote:
> The current device tree CPSW3g node adds non-zero "mac-address" property to
> the ports, which prevents random MAC address assignment to network devices
> if bootloader failed to update DT. This may cause more then one host to
> have the same MAC in the network.
>
> mac-address = [00 00 de ad be ef];
> mac-address = [00 01 de ad be ef];
>
> [...]
Hi Grygorii Strashko,
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[1/1] arm64: dts: ti: k3-am642-main: fix ports mac properties
commit: e04f89c15ea84967fae355d335c5df14349d038d
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-11 19:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 18:49 [PATCH] arm64: dts: ti: k3-am642-main: fix ports mac properties Grygorii Strashko
2021-06-09 5:12 ` Vignesh Raghavendra
2021-06-11 19:01 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).