* [PATCH V2] mlx5: Fix formats with line continuation whitespace
@ 2018-11-01 7:24 Joe Perches
2018-11-01 7:34 ` Leon Romanovsky
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2018-11-01 7:24 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky
Cc: David S. Miller, netdev, linux-rdma, linux-kernel
The line continuations unintentionally add whitespace so
instead use coalesced formats to remove the whitespace.
Signed-off-by: Joe Perches <joe@perches.com>
---
v2: Remove excess space after %u
drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/rl.c b/drivers/net/ethernet/mellanox/mlx5/core/rl.c
index bc86dffdc43c..377b7e65ecf1 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/rl.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/rl.c
@@ -188,8 +188,7 @@ int mlx5_rl_add_rate(struct mlx5_core_dev *dev, u16 *index,
/* new rate limit */
err = mlx5_set_pp_rate_limit_cmd(dev, entry->index, rl);
if (err) {
- mlx5_core_err(dev, "Failed configuring rate limit(err %d): \
- rate %u, max_burst_sz %u, typical_pkt_sz %u\n",
+ mlx5_core_err(dev, "Failed configuring rate limit(err %d): rate %u, max_burst_sz %u, typical_pkt_sz %u\n",
err, rl->rate, rl->max_burst_sz,
rl->typical_pkt_sz);
goto out;
@@ -218,8 +217,7 @@ void mlx5_rl_remove_rate(struct mlx5_core_dev *dev, struct mlx5_rate_limit *rl)
mutex_lock(&table->rl_lock);
entry = find_rl_entry(table, rl);
if (!entry || !entry->refcount) {
- mlx5_core_warn(dev, "Rate %u, max_burst_sz %u typical_pkt_sz %u \
- are not configured\n",
+ mlx5_core_warn(dev, "Rate %u, max_burst_sz %u typical_pkt_sz %u are not configured\n",
rl->rate, rl->max_burst_sz, rl->typical_pkt_sz);
goto out;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2] mlx5: Fix formats with line continuation whitespace
2018-11-01 7:24 [PATCH V2] mlx5: Fix formats with line continuation whitespace Joe Perches
@ 2018-11-01 7:34 ` Leon Romanovsky
2018-11-06 21:34 ` Doug Ledford
0 siblings, 1 reply; 6+ messages in thread
From: Leon Romanovsky @ 2018-11-01 7:34 UTC (permalink / raw)
To: Joe Perches
Cc: Saeed Mahameed, David S. Miller, netdev, linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
On Thu, Nov 01, 2018 at 12:24:08AM -0700, Joe Perches wrote:
> The line continuations unintentionally add whitespace so
> instead use coalesced formats to remove the whitespace.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> v2: Remove excess space after %u
>
> drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] mlx5: Fix formats with line continuation whitespace
2018-11-01 7:34 ` Leon Romanovsky
@ 2018-11-06 21:34 ` Doug Ledford
2019-08-02 18:09 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Doug Ledford @ 2018-11-06 21:34 UTC (permalink / raw)
To: Leon Romanovsky, Joe Perches
Cc: Saeed Mahameed, David S. Miller, netdev, linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
On Thu, 2018-11-01 at 09:34 +0200, Leon Romanovsky wrote:
> On Thu, Nov 01, 2018 at 12:24:08AM -0700, Joe Perches wrote:
> > The line continuations unintentionally add whitespace so
> > instead use coalesced formats to remove the whitespace.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> >
> > v2: Remove excess space after %u
> >
> > drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Applied, thanks.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] mlx5: Fix formats with line continuation whitespace
2018-11-06 21:34 ` Doug Ledford
@ 2019-08-02 18:09 ` Joe Perches
2019-08-02 18:32 ` Saeed Mahameed
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2019-08-02 18:09 UTC (permalink / raw)
To: Doug Ledford, Leon Romanovsky
Cc: Saeed Mahameed, David S. Miller, netdev, linux-rdma, linux-kernel
On Tue, 2018-11-06 at 16:34 -0500, Doug Ledford wrote:
> On Thu, 2018-11-01 at 09:34 +0200, Leon Romanovsky wrote:
> > On Thu, Nov 01, 2018 at 12:24:08AM -0700, Joe Perches wrote:
> > > The line continuations unintentionally add whitespace so
> > > instead use coalesced formats to remove the whitespace.
> > >
> > > Signed-off-by: Joe Perches <joe@perches.com>
> > > ---
> > >
> > > v2: Remove excess space after %u
> > >
> > > drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++----
> > > 1 file changed, 2 insertions(+), 4 deletions(-)
> > >
> >
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
>
> Applied, thanks.
Still not upstream. How long does it take?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] mlx5: Fix formats with line continuation whitespace
2019-08-02 18:09 ` Joe Perches
@ 2019-08-02 18:32 ` Saeed Mahameed
2019-08-02 19:08 ` Doug Ledford
0 siblings, 1 reply; 6+ messages in thread
From: Saeed Mahameed @ 2019-08-02 18:32 UTC (permalink / raw)
To: joe, dledford, leon; +Cc: davem, netdev, linux-rdma, linux-kernel
On Fri, 2019-08-02 at 11:09 -0700, Joe Perches wrote:
> On Tue, 2018-11-06 at 16:34 -0500, Doug Ledford wrote:
> > On Thu, 2018-11-01 at 09:34 +0200, Leon Romanovsky wrote:
> > > On Thu, Nov 01, 2018 at 12:24:08AM -0700, Joe Perches wrote:
> > > > The line continuations unintentionally add whitespace so
> > > > instead use coalesced formats to remove the whitespace.
> > > >
> > > > Signed-off-by: Joe Perches <joe@perches.com>
> > > > ---
> > > >
> > > > v2: Remove excess space after %u
> > > >
> > > > drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++----
> > > > 1 file changed, 2 insertions(+), 4 deletions(-)
> > > >
> > >
> > > Thanks,
> > > Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> >
> > Applied, thanks.
>
> Still not upstream. How long does it take?
>
Doug, Leon, this patch still apply, let me know what happened here ?
and if you want me to apply it to one of my branches.
Thanks,
Saeed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] mlx5: Fix formats with line continuation whitespace
2019-08-02 18:32 ` Saeed Mahameed
@ 2019-08-02 19:08 ` Doug Ledford
0 siblings, 0 replies; 6+ messages in thread
From: Doug Ledford @ 2019-08-02 19:08 UTC (permalink / raw)
To: Saeed Mahameed, joe, leon; +Cc: davem, netdev, linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]
On Fri, 2019-08-02 at 18:32 +0000, Saeed Mahameed wrote:
> On Fri, 2019-08-02 at 11:09 -0700, Joe Perches wrote:
> > On Tue, 2018-11-06 at 16:34 -0500, Doug Ledford wrote:
> > > On Thu, 2018-11-01 at 09:34 +0200, Leon Romanovsky wrote:
> > > > On Thu, Nov 01, 2018 at 12:24:08AM -0700, Joe Perches wrote:
> > > > > The line continuations unintentionally add whitespace so
> > > > > instead use coalesced formats to remove the whitespace.
> > > > >
> > > > > Signed-off-by: Joe Perches <joe@perches.com>
> > > > > ---
> > > > >
> > > > > v2: Remove excess space after %u
> > > > >
> > > > > drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++----
> > > > > 1 file changed, 2 insertions(+), 4 deletions(-)
> > > > >
> > > >
> > > > Thanks,
> > > > Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> > >
> > > Applied, thanks.
> >
> > Still not upstream. How long does it take?
> >
>
> Doug, Leon, this patch still apply, let me know what happened here ?
> and if you want me to apply it to one of my branches.
I'm not entirely sure what happened here. Obviously I said I had taken
it, which I don't do under my normal workflow until I've actually
applied and build tested the patch. For it to not make it into the tree
means that I probably applied it to my wip/dl-for-next branch, but prior
to moving it to for-next, I might have had a rebase and it got lost in
the shuffle or something like that. My apologies for letting it slip
through the cracks. Anyway, I pulled the patch from patchworks, applied
it, and pushed it to k.o.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-02 19:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 7:24 [PATCH V2] mlx5: Fix formats with line continuation whitespace Joe Perches
2018-11-01 7:34 ` Leon Romanovsky
2018-11-06 21:34 ` Doug Ledford
2019-08-02 18:09 ` Joe Perches
2019-08-02 18:32 ` Saeed Mahameed
2019-08-02 19:08 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).