* 2.5.14+ ALSA OSS emulation
@ 2002-05-20 0:56 Bob_Tracy
2002-05-20 17:59 ` Linus Torvalds
0 siblings, 1 reply; 2+ messages in thread
From: Bob_Tracy @ 2002-05-20 0:56 UTC (permalink / raw)
To: perex; +Cc: linux-kernel
In the 2.5.14 patchset, the following change was made in
linux/sound/core/Config.in:
-bool ' OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
+dep_bool ' OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
This breaks the OSS API emulation for people building their ALSA sound
drivers as modules (CONFIG_SND == "m"). The following patch applied
against the 2.5.16 kernel accomplishes what I think the author intended:
--- linux/sound/core/Config.in.orig Sun May 19 18:44:34 2002
+++ linux/sound/core/Config.in Sun May 19 18:45:30 2002
@@ -13,7 +13,9 @@
if [ "$CONFIG_SND_SEQUENCER" != "n" ]; then
dep_tristate ' Sequencer dummy client' CONFIG_SND_SEQ_DUMMY $CONFIG_SND_SEQUENCER
fi
-dep_bool ' OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
+if [ "$CONFIG_SND" != "n" ]; then
+ bool ' OSS API emulation' CONFIG_SND_OSSEMUL
+fi
if [ "$CONFIG_SND_OSSEMUL" = "y" ]; then
dep_tristate ' OSS Mixer API' CONFIG_SND_MIXER_OSS $CONFIG_SND
dep_tristate ' OSS PCM API' CONFIG_SND_PCM_OSS $CONFIG_SND
Please apply.
--
-----------------------------------------------------------------------
Bob Tracy WTO + WIPO = DMCA? http://www.anti-dmca.org
rct@frus.com
-----------------------------------------------------------------------
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.5.14+ ALSA OSS emulation
2002-05-20 0:56 2.5.14+ ALSA OSS emulation Bob_Tracy
@ 2002-05-20 17:59 ` Linus Torvalds
0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2002-05-20 17:59 UTC (permalink / raw)
To: linux-kernel
In article <m179bTr-0005khC@gherkin.frus.com>,
Bob_Tracy <rct@gherkin.frus.com> wrote:
>In the 2.5.14 patchset, the following change was made in
>linux/sound/core/Config.in:
>
>-bool ' OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
>+dep_bool ' OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
>
>This breaks the OSS API emulation for people building their ALSA sound
>drivers as modules (CONFIG_SND == "m"). The following patch applied
>against the 2.5.16 kernel accomplishes what I think the author intended:
Good catch.
However, the simpler fix is to use "dep_mbool", which exists exactly for
this reason.
Linus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-05-20 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-20 0:56 2.5.14+ ALSA OSS emulation Bob_Tracy
2002-05-20 17:59 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).