* [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples
@ 2022-07-15 10:30 AngeloGioacchino Del Regno
2022-07-15 13:42 ` Rob Herring
2022-07-18 13:35 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-15 10:30 UTC (permalink / raw)
To: linus.walleij
Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sean.wang,
angelogioacchino.delregno, nfraprado, linux-gpio, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
The property mediatek,drive-strength-adv was deprecated: change the
example for i2c0-pins to use drive-strength-microamp.
Fixes: b6d9af2c6b69 ("dt-bindings: pinctrl: mt8195: Add and use drive-strength-microamp")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
index 85e96a5e1708..66fe17e9e4d3 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
@@ -281,7 +281,7 @@ examples:
pinmux = <PINMUX_GPIO8__FUNC_SDA0>,
<PINMUX_GPIO9__FUNC_SCL0>;
bias-disable;
- mediatek,drive-strength-adv = <7>;
+ drive-strength-microamp = <1000>;
};
};
};
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples
2022-07-15 10:30 [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples AngeloGioacchino Del Regno
@ 2022-07-15 13:42 ` Rob Herring
2022-07-15 23:20 ` Rob Herring
2022-07-18 13:35 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2022-07-15 13:42 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: devicetree, krzysztof.kozlowski+dt, robh+dt, linus.walleij,
linux-arm-kernel, linux-mediatek, sean.wang, matthias.bgg,
nfraprado, linux-gpio, linux-kernel
On Fri, 15 Jul 2022 12:30:29 +0200, AngeloGioacchino Del Regno wrote:
> The property mediatek,drive-strength-adv was deprecated: change the
> example for i2c0-pins to use drive-strength-microamp.
>
> Fixes: b6d9af2c6b69 ("dt-bindings: pinctrl: mt8195: Add and use drive-strength-microamp")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.example.dtb: pinctrl@10005000: i2c0-pins:pins: 'drive-strength-microamp' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples
2022-07-15 13:42 ` Rob Herring
@ 2022-07-15 23:20 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-07-15 23:20 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: devicetree, krzysztof.kozlowski+dt, linus.walleij,
linux-arm-kernel, linux-mediatek, sean.wang, matthias.bgg,
nfraprado, linux-gpio, linux-kernel
On Fri, Jul 15, 2022 at 07:42:55AM -0600, Rob Herring wrote:
> On Fri, 15 Jul 2022 12:30:29 +0200, AngeloGioacchino Del Regno wrote:
> > The property mediatek,drive-strength-adv was deprecated: change the
> > example for i2c0-pins to use drive-strength-microamp.
> >
> > Fixes: b6d9af2c6b69 ("dt-bindings: pinctrl: mt8195: Add and use drive-strength-microamp")
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> > Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.example.dtb: pinctrl@10005000: i2c0-pins:pins: 'drive-strength-microamp' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
Seems to be a false positive since commit b6d9af2c6b69 was not present
in the test.
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples
2022-07-15 10:30 [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples AngeloGioacchino Del Regno
2022-07-15 13:42 ` Rob Herring
@ 2022-07-18 13:35 ` Linus Walleij
2022-07-18 13:46 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2022-07-18 13:35 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sean.wang,
nfraprado, linux-gpio, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
On Fri, Jul 15, 2022 at 12:30 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
> The property mediatek,drive-strength-adv was deprecated: change the
> example for i2c0-pins to use drive-strength-microamp.
>
> Fixes: b6d9af2c6b69 ("dt-bindings: pinctrl: mt8195: Add and use drive-strength-microamp")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
After finding this in my Inbox, drop my own uglyfix and apply this instead.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples
2022-07-18 13:35 ` Linus Walleij
@ 2022-07-18 13:46 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-18 13:46 UTC (permalink / raw)
To: Linus Walleij
Cc: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, sean.wang,
nfraprado, linux-gpio, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
Il 18/07/22 15:35, Linus Walleij ha scritto:
> On Fri, Jul 15, 2022 at 12:30 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>
>> The property mediatek,drive-strength-adv was deprecated: change the
>> example for i2c0-pins to use drive-strength-microamp.
>>
>> Fixes: b6d9af2c6b69 ("dt-bindings: pinctrl: mt8195: Add and use drive-strength-microamp")
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> After finding this in my Inbox, drop my own uglyfix and apply this instead.
>
> Yours,
> Linus Walleij
Thank you!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-18 13:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-15 10:30 [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples AngeloGioacchino Del Regno
2022-07-15 13:42 ` Rob Herring
2022-07-15 23:20 ` Rob Herring
2022-07-18 13:35 ` Linus Walleij
2022-07-18 13:46 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).