From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jonathan Marek <jonathan@marek.ca>, linux-arm-msm@vger.kernel.org
Cc: "moderated list:SOUNDWIRE SUBSYSTEM"
<alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>,
Sanyog Kale <sanyog.r.kale@intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Subject: Re: [PATCH v2 3/4] soundwire: qcom: add support for mmio soundwire master devices
Date: Tue, 8 Sep 2020 08:56:25 -0500 [thread overview]
Message-ID: <ad39f109-bfc9-332e-adc2-355499db1ab7@linux.intel.com> (raw)
In-Reply-To: <20200905173905.16541-4-jonathan@marek.ca>
> @@ -764,8 +786,11 @@ static int qcom_swrm_probe(struct platform_device *pdev)
> if (!ctrl->regmap)
> return -EINVAL;
> } else {
> - /* Only WCD based SoundWire controller is supported */
> - return -ENOTSUPP;
> + ctrl->reg_read = qcom_swrm_cpu_reg_read;
> + ctrl->reg_write = qcom_swrm_cpu_reg_write;
> + ctrl->mmio = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(ctrl->mmio))
> + return PTR_ERR(ctrl->mmio);
Shouldn't this be conditional on SLIMBUS being enabled, as done in your
patch2?
> }
>
> ctrl->irq = of_irq_get(dev->of_node, 0);
>
next prev parent reply other threads:[~2020-09-08 14:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 17:39 [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master Jonathan Marek
2020-09-05 17:39 ` [PATCH v2 1/4] soundwire: qcom: fix abh/ahb typo Jonathan Marek
2020-09-05 17:39 ` [PATCH v2 2/4] soundwire: qcom: avoid dependency on CONFIG_SLIMBUS Jonathan Marek
2020-09-08 13:53 ` Pierre-Louis Bossart
2020-09-05 17:39 ` [PATCH v2 3/4] soundwire: qcom: add support for mmio soundwire master devices Jonathan Marek
2020-09-08 13:56 ` Pierre-Louis Bossart [this message]
2020-09-08 13:57 ` Jonathan Marek
2020-09-05 17:39 ` [PATCH v2 4/4] soundwire: qcom: add v1.5.1 compatible Jonathan Marek
2020-09-07 8:17 ` [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master Srinivas Kandagatla
2020-09-07 14:17 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad39f109-bfc9-332e-adc2-355499db1ab7@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bjorn.andersson@linaro.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).