From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Jonathan Marek <jonathan@marek.ca>, linux-arm-msm@vger.kernel.org
Cc: "moderated list:SOUNDWIRE SUBSYSTEM"
<alsa-devel@alsa-project.org>, Andy Gross <agross@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>,
Sanyog Kale <sanyog.r.kale@intel.com>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master
Date: Mon, 7 Sep 2020 09:17:21 +0100 [thread overview]
Message-ID: <ec241abf-c1e1-8b2d-a0bb-93a60241330c@linaro.org> (raw)
In-Reply-To: <20200905173905.16541-1-jonathan@marek.ca>
On 05/09/2020 18:39, Jonathan Marek wrote:
> This adds initial support for soundwire device on sm8250.
>
> Tested with the "wsa" sdw device, which is simpler than the others.
>
> v2 addresses some feedback, but I kept this series as simple as possible.
> In particular, I didn't implement CMD_NACKED from FIFO_STATUS, because
> the downstream driver doesn't define this bit, so I can't implement it.
> Soundwire works without it and It shouldn't be difficult to implement later.
>
> Jonathan Marek (4):
> soundwire: qcom: fix abh/ahb typo
> soundwire: qcom: avoid dependency on CONFIG_SLIMBUS
> soundwire: qcom: add support for mmio soundwire master devices
> soundwire: qcom: add v1.5.1 compatible
>
Hi Jonathan,
I have tested these patches on RB5 with WSA8810 and they work fine.
I can try to add support to command ignored in future, but for now these
look good to me!
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Thanks,
srini
> .../bindings/soundwire/qcom,sdw.txt | 1 +
> drivers/soundwire/Kconfig | 2 +-
> drivers/soundwire/qcom.c | 38 +++++++++++++++++--
> 3 files changed, 36 insertions(+), 5 deletions(-)
>
next prev parent reply other threads:[~2020-09-07 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 17:39 [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master Jonathan Marek
2020-09-05 17:39 ` [PATCH v2 1/4] soundwire: qcom: fix abh/ahb typo Jonathan Marek
2020-09-05 17:39 ` [PATCH v2 2/4] soundwire: qcom: avoid dependency on CONFIG_SLIMBUS Jonathan Marek
2020-09-08 13:53 ` Pierre-Louis Bossart
2020-09-05 17:39 ` [PATCH v2 3/4] soundwire: qcom: add support for mmio soundwire master devices Jonathan Marek
2020-09-08 13:56 ` Pierre-Louis Bossart
2020-09-08 13:57 ` Jonathan Marek
2020-09-05 17:39 ` [PATCH v2 4/4] soundwire: qcom: add v1.5.1 compatible Jonathan Marek
2020-09-07 8:17 ` Srinivas Kandagatla [this message]
2020-09-07 14:17 ` [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec241abf-c1e1-8b2d-a0bb-93a60241330c@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).