From: Helen Koike <helen.koike@collabora.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-rockchip@lists.infradead.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, eddie.cai.linux@gmail.com,
mchehab@kernel.org, heiko@sntech.de, gregkh@linuxfoundation.org,
andrey.konovalov@linaro.org, linux-kernel@vger.kernel.org,
tfiga@chromium.org, robh+dt@kernel.org, hans.verkuil@cisco.com,
laurent.pinchart@ideasonboard.com, joacim.zetterling@gmail.com,
kernel@collabora.com, ezequiel@collabora.com,
linux-media@vger.kernel.org, jacob-chen@iotwrt.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v12 08/11] media: staging: dt-bindings: add Rockchip ISP1 yaml bindings
Date: Wed, 8 Jan 2020 13:50:38 -0300 [thread overview]
Message-ID: <ad9d8ef7-5b52-d27e-ac95-db07dc1d443c@collabora.com> (raw)
In-Reply-To: <20200107140115.GQ19828@paasikivi.fi.intel.com>
Hi,
Thank you for your review.
On 1/7/20 12:01 PM, Sakari Ailus wrote:
> Hi Helen,
>
> On Fri, Dec 27, 2019 at 05:01:13PM -0300, Helen Koike wrote:
>> Add yaml DT bindings for Rockchip ISP1.
>>
>> This was tested and verified with:
>> mv drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml Documentation/devicetree/bindings/media/
>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
>>
>> Signed-off-by: Helen Koike <helen.koike@collabora.com>
>>
>> ---
>>
>> Changes in v12:
>> - The commit replaces the following commit in previous series named
>> media: staging: dt-bindings: Document the Rockchip ISP1 bindings
>> This new patch adds yaml binding and was verified with
>> make dtbs_check and make dt_binding_check
>>
>> Changes in v11:
>> - add clock-names values
>>
>> Changes in v10:
>> - unsquash
>>
>> Changes in v9:
>> - squash
>> - move to staging
>>
>> Changes in v8:
>> - fix title division style
>>
>> Changes in v7:
>> - update document with new design and tested example
>>
>> .../bindings/media/rockchip-isp1.yaml | 193 ++++++++++++++++++
>> 1 file changed, 193 insertions(+)
>> create mode 100644 drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
>>
>> diff --git a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
>> new file mode 100644
>> index 000000000000..4d1b2c67a4cd
>> --- /dev/null
>> +++ b/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
>> @@ -0,0 +1,193 @@
>> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/rockchip-isp1.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Rockchip SoC Image Signal Processing unit v1
>> +
>> +maintainers:
>> + - Helen Koike <helen.koike@collabora.com>
>> +
>> +description: |
>> + Rockchip ISP1 is the Camera interface for the Rockchip series of SoCs
>> + which contains image processing, scaling, and compression funcitons.
>
> "functions"
>
>> +
>> +properties:
>> + compatible:
>> + const: rockchip,rk3399-cif-isp
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + iommus:
>> + maxItems: 1
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + phys:
>> + maxItems: 1
>> + description: phandle for the PHY port
>> +
>> + phy-names:
>> + const: dphy
>> +
>> + clocks:
>> + items:
>> + - description: ISP clock
>> + - description: ISP aclk clock
>> + - description: ISP aclk wrapper clock
>> + - description: ISP hclk clock
>> + - description: ISP hclk wrapper clock
>> +
>> + clock-names:
>> + items:
>> + - const: clk_isp
>> + - const: aclk_isp
>> + - const: aclk_isp_wrap
>> + - const: hclk_isp
>> + - const: hclk_isp_wrap
>> +
>> + # See ./video-interfaces.txt for details
>> + ports:
>> + type: object
>> + additionalProperties: false
>> +
>> + properties:
>> + "#address-cells":
>> + const: 1
>> +
>> + "#size-cells":
>> + const: 0
>> +
>> + port@0:
>
> If you only have a single port node, you could drop reg as well as @0 on
> the port node.
After the discussions, we have a single port for now, but we might have port@1
for tx1rx1 in the future.
Helen
>
>> + type: object
>> + additionalProperties: false
>> +
>> + properties:
>> + "#address-cells":
>> + const: 1
>> +
>> + "#size-cells":
>> + const: 0
>> +
>> + reg:
>> + const: 0
>> + description: port identifier.
>> +
>> + patternProperties:
>> + endpoint:
>> + type: object
>> + additionalProperties: false
>> +
>> + properties:
>> + reg:
>> + maxItems: 1
>> + description: endpoint identifier.
>> +
>> + data-lanes:
>> + minItems: 1
>> + maxItems: 4
>> +
>> + remote-endpoint: true
>> +
>> + required:
>> + - port@0
>> +
>> +required:
>> + - compatible
>> + - interrupts
>> + - clocks
>> + - clock-names
>> + - power-domains
>> + - iommus
>> + - phys
>> + - phy-names
>> + - ports
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> +
>> + #include <dt-bindings/clock/rk3399-cru.h>
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + #include <dt-bindings/power/rk3399-power.h>
>> +
>> + parent0: parent@0 {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + isp0: isp0@ff910000 {
>> + compatible = "rockchip,rk3399-cif-isp";
>> + reg = <0x0 0xff910000 0x0 0x4000>;
>> + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH 0>;
>> + clocks = <&cru SCLK_ISP0>,
>> + <&cru ACLK_ISP0>, <&cru ACLK_ISP0_WRAPPER>,
>> + <&cru HCLK_ISP0>, <&cru HCLK_ISP0_WRAPPER>;
>> + clock-names = "clk_isp",
>> + "aclk_isp", "aclk_isp_wrap",
>> + "hclk_isp", "hclk_isp_wrap";
>> + power-domains = <&power RK3399_PD_ISP0>;
>> + iommus = <&isp0_mmu>;
>> + phys = <&dphy>;
>> + phy-names = "dphy";
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0>;
>> +
>> + mipi_in_wcam: endpoint@0 {
>> + reg = <0>;
>> + remote-endpoint = <&wcam_out>;
>> + data-lanes = <1 2>;
>> + };
>> +
>> + mipi_in_ucam: endpoint@1 {
>> + reg = <1>;
>> + remote-endpoint = <&ucam_out>;
>> + data-lanes = <1>;
>> + };
>> + };
>> + };
>> + };
>> +
>> + i2c7: i2c@ff160000 {
>> + clock-frequency = <400000>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + wcam: camera@36 {
>> + compatible = "ovti,ov5695";
>> + reg = <0x36>;
>> +
>> + port {
>> + wcam_out: endpoint {
>> + remote-endpoint = <&mipi_in_wcam>;
>> + data-lanes = <1 2>;
>> + };
>> + };
>> + };
>> +
>> + ucam: camera@3c {
>> + compatible = "ovti,ov2685";
>> + reg = <0x3c>;
>> +
>> + port {
>> + ucam_out: endpoint {
>> + remote-endpoint = <&mipi_in_ucam>;
>> + data-lanes = <1>;
>> + };
>> + };
>> + };
>> + };
>> + };
>
next prev parent reply other threads:[~2020-01-08 16:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 20:01 [PATCH v12 00/11] Rockchip ISP Driver Helen Koike
2019-12-27 20:01 ` [PATCH v12 01/11] media: staging: phy-rockchip-dphy: add Rockchip MIPI Synopsys DPHY driver Helen Koike
2019-12-30 18:25 ` Ezequiel Garcia
2020-01-07 1:11 ` Laurent Pinchart
2020-01-07 15:58 ` Ezequiel Garcia
2020-01-07 16:18 ` Laurent Pinchart
2019-12-27 20:01 ` [PATCH v12 02/11] media: staging: rkisp1: add Rockchip ISP1 base driver Helen Koike
2019-12-30 18:13 ` Ezequiel Garcia
2019-12-27 20:01 ` [PATCH v12 03/11] media: staging: rkisp1: add streaming paths Helen Koike
2019-12-27 20:01 ` [PATCH v12 04/11] media: staging: rkisp1: add user space ABI definitions Helen Koike
2019-12-27 20:01 ` [PATCH v12 05/11] media: staging: rkisp1: add capture device for statistics Helen Koike
2019-12-27 20:01 ` [PATCH v12 06/11] media: staging: rkisp1: add output device for parameters Helen Koike
2019-12-27 20:01 ` [PATCH v12 07/11] media: staging: rkisp1: add document for rkisp1 meta buffer format Helen Koike
2019-12-27 20:01 ` [PATCH v12 08/11] media: staging: dt-bindings: add Rockchip ISP1 yaml bindings Helen Koike
2020-01-06 22:27 ` Rob Herring
2020-01-06 23:59 ` Laurent Pinchart
2020-01-07 13:45 ` Ezequiel Garcia
2020-01-07 16:19 ` Laurent Pinchart
2020-01-07 14:01 ` Sakari Ailus
2020-01-08 16:50 ` Helen Koike [this message]
2020-01-08 18:08 ` Sakari Ailus
2019-12-27 20:01 ` [PATCH v12 09/11] media: staging: dt-bindings: add Rockchip MIPI RX D-PHY " Helen Koike
2020-01-06 22:29 ` Rob Herring
2020-01-07 0:10 ` Laurent Pinchart
2020-01-07 2:06 ` Ezequiel Garcia
2020-01-07 2:37 ` Laurent Pinchart
2020-01-07 9:28 ` Heiko Stübner
2020-01-07 13:20 ` Ezequiel Garcia
2020-01-07 21:30 ` Heiko Stübner
2020-01-07 21:57 ` Laurent Pinchart
2020-01-07 22:12 ` Heiko Stuebner
2020-01-07 22:03 ` Ezequiel Garcia
2020-01-07 22:25 ` Heiko Stuebner
2020-01-07 22:41 ` Ezequiel Garcia
2019-12-27 20:01 ` [PATCH v12 10/11] media: staging: rkisp1: add TODO file for staging Helen Koike
2019-12-27 20:01 ` [PATCH v12 11/11] MAINTAINERS: add entry for Rockchip ISP1 driver Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad9d8ef7-5b52-d27e-ac95-db07dc1d443c@collabora.com \
--to=helen.koike@collabora.com \
--cc=andrey.konovalov@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=ezequiel@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=joacim.zetterling@gmail.com \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).