From: Ezequiel Garcia <ezequiel@collabora.com>
To: Helen Koike <helen.koike@collabora.com>,
linux-rockchip@lists.infradead.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
eddie.cai.linux@gmail.com, mchehab@kernel.org, heiko@sntech.de,
gregkh@linuxfoundation.org, andrey.konovalov@linaro.org,
linux-kernel@vger.kernel.org, tfiga@chromium.org,
robh+dt@kernel.org, hans.verkuil@cisco.com,
laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com,
joacim.zetterling@gmail.com, kernel@collabora.com,
linux-media@vger.kernel.org, jacob-chen@iotwrt.com,
linux-arm-kernel@lists.infradead.org,
Jacob Chen <jacob2.chen@rock-chips.com>,
Shunqian Zheng <zhengsq@rock-chips.com>,
Yichong Zhong <zyc@rock-chips.com>,
Jacob Chen <cc@rock-chips.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Allon Huang <allon.huang@rock-chips.com>
Subject: Re: [PATCH v12 02/11] media: staging: rkisp1: add Rockchip ISP1 base driver
Date: Mon, 30 Dec 2019 15:13:41 -0300 [thread overview]
Message-ID: <f5e8afbbd46a25b752890880621be95971023f2e.camel@collabora.com> (raw)
In-Reply-To: <20191227200116.2612137-3-helen.koike@collabora.com>
Hi Helen,
Just spotted a small thing.
On Fri, 2019-12-27 at 17:01 -0300, Helen Koike wrote:
[..]
> +static int rkisp1_probe(struct platform_device *pdev)
> +{
> + struct device_node *node = pdev->dev.of_node;
> + const struct rkisp1_match_data *clk_data;
> + const struct of_device_id *match;
> + struct device *dev = &pdev->dev;
> + struct rkisp1_device *rkisp1;
> + struct v4l2_device *v4l2_dev;
> + unsigned int i;
> + int ret, irq;
> +
> + match = of_match_node(rkisp1_of_match, node);
> + rkisp1 = devm_kzalloc(dev, sizeof(*rkisp1), GFP_KERNEL);
> + if (!rkisp1)
> + return -ENOMEM;
> +
> + dev_set_drvdata(dev, rkisp1);
> + rkisp1->dev = dev;
> +
> + rkisp1_debug_init(rkisp1);
> +
> + rkisp1->base_addr = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(rkisp1->base_addr))
> + return PTR_ERR(rkisp1->base_addr);
> +
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0)
> + return irq;
> +
> + ret = devm_request_irq(dev, irq, rkisp1_isr, IRQF_SHARED,
> + dev_driver_string(dev), dev);
> + if (ret) {
> + dev_err(dev, "request irq failed: %d\n", ret);
> + return ret;
> + }
> +
> + rkisp1->irq = irq;
> + clk_data = match->data;
> +
> + for (i = 0; i < clk_data->size; i++)
> + rkisp1->clks[i].id = clk_data->clks[i];
> + ret = devm_clk_bulk_get(dev, clk_data->size, rkisp1->clks);
> + if (ret)
> + return ret;
> + rkisp1->clk_size = clk_data->size;
> +
> + pm_runtime_enable(&pdev->dev);
> +
> + strscpy(rkisp1->media_dev.model, RKISP1_DRIVER_NAME,
> + sizeof(rkisp1->media_dev.model));
> + rkisp1->media_dev.dev = &pdev->dev;
> + strscpy(rkisp1->media_dev.bus_info,
> + "platform: " RKISP1_DRIVER_NAME,
> + sizeof(rkisp1->media_dev.bus_info));
> + media_device_init(&rkisp1->media_dev);
> +
> + v4l2_dev = &rkisp1->v4l2_dev;
> + v4l2_dev->mdev = &rkisp1->media_dev;
> + strscpy(v4l2_dev->name, RKISP1_DRIVER_NAME, sizeof(v4l2_dev->name));
> +
> + ret = v4l2_device_register(rkisp1->dev, &rkisp1->v4l2_dev);
> + if (ret)
> + return ret;
> +
> + ret = media_device_register(&rkisp1->media_dev);
> + if (ret) {
> + dev_err(dev, "Failed to register media device: %d\n", ret);
> + goto err_unreg_v4l2_dev;
> + }
> +
> + ret = rkisp1_entities_register(rkisp1);
> + if (ret)
> + goto err_unreg_media_dev;
> +
> + return 0;
> +
> +err_unreg_media_dev:
> + media_device_unregister(&rkisp1->media_dev);
> +err_unreg_v4l2_dev:
> + v4l2_device_unregister(&rkisp1->v4l2_dev);
> + pm_runtime_disable(&pdev->dev);
There's a missing call to debugfs_remove_recursive here.
> + return ret;
> +}
> +
> +static int rkisp1_remove(struct platform_device *pdev)
> +{
> + struct rkisp1_device *rkisp1 = platform_get_drvdata(pdev);
> +
> + v4l2_async_notifier_unregister(&rkisp1->notifier);
> + v4l2_async_notifier_cleanup(&rkisp1->notifier);
> +
> + rkisp1_isp_unregister(rkisp1);
> +
> + media_device_unregister(&rkisp1->media_dev);
> + v4l2_device_unregister(&rkisp1->v4l2_dev);
> +
> + pm_runtime_disable(&pdev->dev);
> +
> + debugfs_remove_recursive(rkisp1->debug.debugfs_dir);
> + return 0;
> +}
> +
Thanks,
Ezequiel
next prev parent reply other threads:[~2019-12-30 18:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 20:01 [PATCH v12 00/11] Rockchip ISP Driver Helen Koike
2019-12-27 20:01 ` [PATCH v12 01/11] media: staging: phy-rockchip-dphy: add Rockchip MIPI Synopsys DPHY driver Helen Koike
2019-12-30 18:25 ` Ezequiel Garcia
2020-01-07 1:11 ` Laurent Pinchart
2020-01-07 15:58 ` Ezequiel Garcia
2020-01-07 16:18 ` Laurent Pinchart
2019-12-27 20:01 ` [PATCH v12 02/11] media: staging: rkisp1: add Rockchip ISP1 base driver Helen Koike
2019-12-30 18:13 ` Ezequiel Garcia [this message]
2019-12-27 20:01 ` [PATCH v12 03/11] media: staging: rkisp1: add streaming paths Helen Koike
2019-12-27 20:01 ` [PATCH v12 04/11] media: staging: rkisp1: add user space ABI definitions Helen Koike
2019-12-27 20:01 ` [PATCH v12 05/11] media: staging: rkisp1: add capture device for statistics Helen Koike
2019-12-27 20:01 ` [PATCH v12 06/11] media: staging: rkisp1: add output device for parameters Helen Koike
2019-12-27 20:01 ` [PATCH v12 07/11] media: staging: rkisp1: add document for rkisp1 meta buffer format Helen Koike
2019-12-27 20:01 ` [PATCH v12 08/11] media: staging: dt-bindings: add Rockchip ISP1 yaml bindings Helen Koike
2020-01-06 22:27 ` Rob Herring
2020-01-06 23:59 ` Laurent Pinchart
2020-01-07 13:45 ` Ezequiel Garcia
2020-01-07 16:19 ` Laurent Pinchart
2020-01-07 14:01 ` Sakari Ailus
2020-01-08 16:50 ` Helen Koike
2020-01-08 18:08 ` Sakari Ailus
2019-12-27 20:01 ` [PATCH v12 09/11] media: staging: dt-bindings: add Rockchip MIPI RX D-PHY " Helen Koike
2020-01-06 22:29 ` Rob Herring
2020-01-07 0:10 ` Laurent Pinchart
2020-01-07 2:06 ` Ezequiel Garcia
2020-01-07 2:37 ` Laurent Pinchart
2020-01-07 9:28 ` Heiko Stübner
2020-01-07 13:20 ` Ezequiel Garcia
2020-01-07 21:30 ` Heiko Stübner
2020-01-07 21:57 ` Laurent Pinchart
2020-01-07 22:12 ` Heiko Stuebner
2020-01-07 22:03 ` Ezequiel Garcia
2020-01-07 22:25 ` Heiko Stuebner
2020-01-07 22:41 ` Ezequiel Garcia
2019-12-27 20:01 ` [PATCH v12 10/11] media: staging: rkisp1: add TODO file for staging Helen Koike
2019-12-27 20:01 ` [PATCH v12 11/11] MAINTAINERS: add entry for Rockchip ISP1 driver Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5e8afbbd46a25b752890880621be95971023f2e.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=allon.huang@rock-chips.com \
--cc=andrey.konovalov@linaro.org \
--cc=cc@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=jacob-chen@iotwrt.com \
--cc=jacob2.chen@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=joacim.zetterling@gmail.com \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=zhengsq@rock-chips.com \
--cc=zyc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).