From: Thara Gopinath <thara.gopinath@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 6/9] drivers: thermal: tsens: Replace custom 8960 apis with generic apis
Date: Fri, 19 Mar 2021 09:12:09 -0400 [thread overview]
Message-ID: <adc9dfb1-1667-a012-68aa-3bd4d91387bb@linaro.org> (raw)
In-Reply-To: <20210319005228.1250-7-ansuelsmth@gmail.com>
On 3/18/21 8:52 PM, Ansuel Smith wrote:
> Rework calibrate function to use common function. Derive the offset from
> a missing hardcoded slope table and the data from the nvmem calib
> efuses.
> Drop custom get_temp function and use generic api.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
> drivers/thermal/qcom/tsens-8960.c | 56 +++++++++----------------------
> 1 file changed, 15 insertions(+), 41 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-8960.c b/drivers/thermal/qcom/tsens-8960.c
> index bdc64d4188bf..8c523b764862 100644
> --- a/drivers/thermal/qcom/tsens-8960.c
> +++ b/drivers/thermal/qcom/tsens-8960.c
> @@ -67,6 +67,13 @@
> #define S9_STATUS_OFF 0x3674
> #define S10_STATUS_OFF 0x3678
>
> +/* Original slope - 200 to compensate mC to C inaccuracy */
> +u32 tsens_msm8960_slope[] = {
> + 976, 976, 954, 976,
> + 911, 932, 932, 999,
> + 932, 999, 932
> + };
make -C1 throws a warning for this. You have to make the table static.
You can keep my Acked-by once it is fixed.
Warm Regards
Thara
next prev parent reply other threads:[~2021-03-19 13:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 0:52 [PATCH v11 0/9] Add support for ipq8064 tsens Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 1/9] drivers: thermal: tsens: Add VER_0 tsens version Ansuel Smith
2021-03-19 13:11 ` Thara Gopinath
2021-03-19 13:28 ` Ansuel Smith
2021-03-19 14:11 ` Thara Gopinath
2021-03-19 0:52 ` [PATCH v11 2/9] drivers: thermal: tsens: Don't hardcode sensor slope Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 3/9] drivers: thermal: tsens: Convert msm8960 to reg_field Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 4/9] drivers: thermal: tsens: Use init_common for msm8960 Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 5/9] drivers: thermal: tsens: Fix bug in sensor enable " Ansuel Smith
2021-03-19 13:11 ` Thara Gopinath
2021-03-22 10:47 ` Marc Gonzalez
2021-03-19 0:52 ` [PATCH v11 6/9] drivers: thermal: tsens: Replace custom 8960 apis with generic apis Ansuel Smith
2021-03-19 13:12 ` Thara Gopinath [this message]
2021-03-19 0:52 ` [PATCH v11 7/9] drivers: thermal: tsens: Drop unused define for msm8960 Ansuel Smith
2021-03-19 13:12 ` Thara Gopinath
2021-03-19 0:52 ` [PATCH v11 8/9] drivers: thermal: tsens: Add support for ipq8064-tsens Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 9/9] dt-bindings: thermal: tsens: Document ipq8064 bindings Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adc9dfb1-1667-a012-68aa-3bd4d91387bb@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).