* [PATCH 1/4] net: stmmac: Combine three seq_printf() calls into a seq_puts() in stmmac_sysfs_dma_cap_read()
2017-05-09 11:51 [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations SF Markus Elfring
@ 2017-05-09 11:52 ` SF Markus Elfring
2017-05-09 11:53 ` [PATCH 2/4] net: stmmac: Replace five seq_printf() calls by seq_puts() SF Markus Elfring
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2017-05-09 11:52 UTC (permalink / raw)
To: netdev, Alexandre Torgue, Giuseppe Cavallaro; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 9 May 2017 13:10:28 +0200
A bit of text was put into a sequence by three separate function calls.
Print the same data by a single function call instead.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index cd8c60132390..2949c9fc18fa 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -3802,10 +3802,10 @@ static int stmmac_sysfs_dma_cap_read(struct seq_file *seq, void *v)
return 0;
}
- seq_printf(seq, "==============================\n");
- seq_printf(seq, "\tDMA HW features\n");
- seq_printf(seq, "==============================\n");
-
+ seq_puts(seq,
+ "==============================\n"
+ "\tDMA HW features\n"
+ "==============================\n");
seq_printf(seq, "\t10/100 Mbps: %s\n",
(priv->dma_cap.mbps_10_100) ? "Y" : "N");
seq_printf(seq, "\t1000 Mbps: %s\n",
--
2.12.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/4] net: stmmac: Replace five seq_printf() calls by seq_puts()
2017-05-09 11:51 [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations SF Markus Elfring
2017-05-09 11:52 ` [PATCH 1/4] net: stmmac: Combine three seq_printf() calls into a seq_puts() in stmmac_sysfs_dma_cap_read() SF Markus Elfring
@ 2017-05-09 11:53 ` SF Markus Elfring
2017-05-09 11:54 ` [PATCH 3/4] net: stmmac: Use seq_putc() in sysfs_display_ring() SF Markus Elfring
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2017-05-09 11:53 UTC (permalink / raw)
To: netdev, Alexandre Torgue, Giuseppe Cavallaro; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 9 May 2017 13:20:03 +0200
Five strings which did not contain data format specifications should be put
into a sequence. Thus use the corresponding function "seq_puts".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 2949c9fc18fa..1f7022ce78b7 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -3748,11 +3748,11 @@ static int stmmac_sysfs_ring_read(struct seq_file *seq, void *v)
seq_printf(seq, "RX Queue %d:\n", queue);
if (priv->extend_desc) {
- seq_printf(seq, "Extended descriptor ring:\n");
+ seq_puts(seq, "Extended descriptor ring:\n");
sysfs_display_ring((void *)rx_q->dma_erx,
DMA_RX_SIZE, 1, seq);
} else {
- seq_printf(seq, "Descriptor ring:\n");
+ seq_puts(seq, "Descriptor ring:\n");
sysfs_display_ring((void *)rx_q->dma_rx,
DMA_RX_SIZE, 0, seq);
}
@@ -3764,11 +3764,11 @@ static int stmmac_sysfs_ring_read(struct seq_file *seq, void *v)
seq_printf(seq, "TX Queue %d:\n", queue);
if (priv->extend_desc) {
- seq_printf(seq, "Extended descriptor ring:\n");
+ seq_puts(seq, "Extended descriptor ring:\n");
sysfs_display_ring((void *)tx_q->dma_etx,
DMA_TX_SIZE, 1, seq);
} else {
- seq_printf(seq, "Descriptor ring:\n");
+ seq_puts(seq, "Descriptor ring:\n");
sysfs_display_ring((void *)tx_q->dma_tx,
DMA_TX_SIZE, 0, seq);
}
@@ -3798,7 +3798,7 @@ static int stmmac_sysfs_dma_cap_read(struct seq_file *seq, void *v)
struct stmmac_priv *priv = netdev_priv(dev);
if (!priv->hw_cap_support) {
- seq_printf(seq, "DMA HW features not supported\n");
+ seq_puts(seq, "DMA HW features not supported\n");
return 0;
}
--
2.12.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] net: stmmac: Use seq_putc() in sysfs_display_ring()
2017-05-09 11:51 [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations SF Markus Elfring
2017-05-09 11:52 ` [PATCH 1/4] net: stmmac: Combine three seq_printf() calls into a seq_puts() in stmmac_sysfs_dma_cap_read() SF Markus Elfring
2017-05-09 11:53 ` [PATCH 2/4] net: stmmac: Replace five seq_printf() calls by seq_puts() SF Markus Elfring
@ 2017-05-09 11:54 ` SF Markus Elfring
2017-05-09 11:55 ` [PATCH 4/4] net: stmmac: Delete an unnecessary return statement in stmmac_get_tx_hwtstamp() SF Markus Elfring
2017-05-10 6:56 ` [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations Giuseppe CAVALLARO
4 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2017-05-09 11:54 UTC (permalink / raw)
To: netdev, Alexandre Torgue, Giuseppe Cavallaro; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 9 May 2017 13:24:27 +0200
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 1f7022ce78b7..4fa95234978c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -3730,7 +3730,7 @@ static void sysfs_display_ring(void *head, int size, int extend_desc,
le32_to_cpu(p->des2), le32_to_cpu(p->des3));
p++;
}
- seq_printf(seq, "\n");
+ seq_putc(seq, '\n');
}
}
--
2.12.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] net: stmmac: Delete an unnecessary return statement in stmmac_get_tx_hwtstamp()
2017-05-09 11:51 [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations SF Markus Elfring
` (2 preceding siblings ...)
2017-05-09 11:54 ` [PATCH 3/4] net: stmmac: Use seq_putc() in sysfs_display_ring() SF Markus Elfring
@ 2017-05-09 11:55 ` SF Markus Elfring
2017-05-10 6:56 ` [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations Giuseppe CAVALLARO
4 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2017-05-09 11:55 UTC (permalink / raw)
To: netdev, Alexandre Torgue, Giuseppe Cavallaro; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 9 May 2017 13:36:04 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 4fa95234978c..9ab4cbfa67f1 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -445,8 +445,6 @@ static void stmmac_get_tx_hwtstamp(struct stmmac_priv *priv,
/* pass tstamp to stack */
skb_tstamp_tx(skb, &shhwtstamp);
}
-
- return;
}
/* stmmac_get_rx_hwtstamp - get HW RX timestamps
--
2.12.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations
2017-05-09 11:51 [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations SF Markus Elfring
` (3 preceding siblings ...)
2017-05-09 11:55 ` [PATCH 4/4] net: stmmac: Delete an unnecessary return statement in stmmac_get_tx_hwtstamp() SF Markus Elfring
@ 2017-05-10 6:56 ` Giuseppe CAVALLARO
4 siblings, 0 replies; 6+ messages in thread
From: Giuseppe CAVALLARO @ 2017-05-10 6:56 UTC (permalink / raw)
To: SF Markus Elfring, netdev, Alexandre Torgue; +Cc: LKML, kernel-janitors
Hello Markus
Thanks a lot for your effort on stmmac
On 5/9/2017 1:51 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 9 May 2017 13:48:03 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (4):
> Combine three seq_printf() calls into a seq_puts() in stmmac_sysfs_dma_cap_read()
> Replace five seq_printf() calls by seq_puts()
> Use seq_putc() in sysfs_display_ring()
> Delete an unnecessary return statement in stmmac_get_tx_hwtstamp()
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 22 ++++++++++------------
> 1 file changed, 10 insertions(+), 12 deletions(-)
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
^ permalink raw reply [flat|nested] 6+ messages in thread