* [PATCH] of: property: fix #nvmem-cell-cells parsing
@ 2023-01-10 23:30 Michael Walle
2023-01-11 2:45 ` Peng Fan
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Michael Walle @ 2023-01-10 23:30 UTC (permalink / raw)
To: Rob Herring, Frank Rowand, Srinivas Kandagatla, Robert Marko,
Alexander Stein, Peng Fan, Miquel Raynal
Cc: devicetree, linux-kernel, Aisheng Dong, Michael Walle
Commit 67b8497f005f ("of: property: make #.*-cells optional for simple
props") claims to make the cells-name property optional for simple
properties, but changed the code for the wrong property, i.e. for
DEFINE_SUFFIX_PROP(). Fix that.
Fixes: 67b8497f005f ("of: property: make #.*-cells optional for simple props")
Reported-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Michael Walle <michael@walle.cc>
Tested-by: Robert Marko <robimarko@gmail.com>
---
drivers/of/property.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/of/property.c b/drivers/of/property.c
index 8d9ba20a8f90..95b838185b2f 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1202,8 +1202,8 @@ static struct device_node *parse_prop_cells(struct device_node *np,
if (strcmp(prop_name, list_name))
return NULL;
- if (of_parse_phandle_with_args(np, list_name, cells_name, index,
- &sup_args))
+ if (__of_parse_phandle_with_args(np, list_name, cells_name, 0, index,
+ &sup_args))
return NULL;
return sup_args.np;
@@ -1256,8 +1256,8 @@ static struct device_node *parse_suffix_prop_cells(struct device_node *np,
if (strcmp_suffix(prop_name, suffix))
return NULL;
- if (__of_parse_phandle_with_args(np, prop_name, cells_name, 0, index,
- &sup_args))
+ if (of_parse_phandle_with_args(np, prop_name, cells_name, index,
+ &sup_args))
return NULL;
return sup_args.np;
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] of: property: fix #nvmem-cell-cells parsing
2023-01-10 23:30 [PATCH] of: property: fix #nvmem-cell-cells parsing Michael Walle
@ 2023-01-11 2:45 ` Peng Fan
2023-01-13 1:32 ` Rob Herring
2023-01-20 17:48 ` Srinivas Kandagatla
2 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2023-01-11 2:45 UTC (permalink / raw)
To: Michael Walle, Rob Herring, Frank Rowand, Srinivas Kandagatla,
Robert Marko, Alexander Stein, Miquel Raynal
Cc: devicetree, linux-kernel, Aisheng Dong
> Subject: [PATCH] of: property: fix #nvmem-cell-cells parsing
>
> Commit 67b8497f005f ("of: property: make #.*-cells optional for simple
> props") claims to make the cells-name property optional for simple
> properties, but changed the code for the wrong property, i.e. for
> DEFINE_SUFFIX_PROP(). Fix that.
>
> Fixes: 67b8497f005f ("of: property: make #.*-cells optional for simple
> props")
> Reported-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
> Tested-by: Robert Marko <robimarko@gmail.com>
Tested-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/of/property.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c index
> 8d9ba20a8f90..95b838185b2f 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1202,8 +1202,8 @@ static struct device_node
> *parse_prop_cells(struct device_node *np,
> if (strcmp(prop_name, list_name))
> return NULL;
>
> - if (of_parse_phandle_with_args(np, list_name, cells_name, index,
> - &sup_args))
> + if (__of_parse_phandle_with_args(np, list_name, cells_name, 0,
> index,
> + &sup_args))
> return NULL;
>
> return sup_args.np;
> @@ -1256,8 +1256,8 @@ static struct device_node
> *parse_suffix_prop_cells(struct device_node *np,
> if (strcmp_suffix(prop_name, suffix))
> return NULL;
>
> - if (__of_parse_phandle_with_args(np, prop_name, cells_name, 0,
> index,
> - &sup_args))
> + if (of_parse_phandle_with_args(np, prop_name, cells_name, index,
> + &sup_args))
> return NULL;
>
> return sup_args.np;
> --
> 2.30.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] of: property: fix #nvmem-cell-cells parsing
2023-01-10 23:30 [PATCH] of: property: fix #nvmem-cell-cells parsing Michael Walle
2023-01-11 2:45 ` Peng Fan
@ 2023-01-13 1:32 ` Rob Herring
2023-01-13 1:33 ` Rob Herring
2023-01-20 17:48 ` Srinivas Kandagatla
2 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2023-01-13 1:32 UTC (permalink / raw)
To: Michael Walle
Cc: Robert Marko, Frank Rowand, Peng Fan, Miquel Raynal,
Alexander Stein, devicetree, Srinivas Kandagatla, linux-kernel,
Rob Herring, Aisheng Dong
On Wed, 11 Jan 2023 00:30:56 +0100, Michael Walle wrote:
> Commit 67b8497f005f ("of: property: make #.*-cells optional for simple
> props") claims to make the cells-name property optional for simple
> properties, but changed the code for the wrong property, i.e. for
> DEFINE_SUFFIX_PROP(). Fix that.
>
> Fixes: 67b8497f005f ("of: property: make #.*-cells optional for simple props")
> Reported-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
> Tested-by: Robert Marko <robimarko@gmail.com>
> ---
> drivers/of/property.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] of: property: fix #nvmem-cell-cells parsing
2023-01-13 1:32 ` Rob Herring
@ 2023-01-13 1:33 ` Rob Herring
2023-01-13 10:20 ` Michael Walle
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2023-01-13 1:33 UTC (permalink / raw)
To: Michael Walle
Cc: Robert Marko, Frank Rowand, Peng Fan, Miquel Raynal,
Alexander Stein, devicetree, Srinivas Kandagatla, linux-kernel,
Aisheng Dong
On Thu, Jan 12, 2023 at 7:32 PM Rob Herring <robh@kernel.org> wrote:
>
>
> On Wed, 11 Jan 2023 00:30:56 +0100, Michael Walle wrote:
> > Commit 67b8497f005f ("of: property: make #.*-cells optional for simple
> > props") claims to make the cells-name property optional for simple
> > properties, but changed the code for the wrong property, i.e. for
> > DEFINE_SUFFIX_PROP(). Fix that.
> >
> > Fixes: 67b8497f005f ("of: property: make #.*-cells optional for simple props")
> > Reported-by: Peng Fan <peng.fan@nxp.com>
> > Signed-off-by: Michael Walle <michael@walle.cc>
> > Tested-by: Robert Marko <robimarko@gmail.com>
> > ---
> > drivers/of/property.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
>
> Applied, thanks!
Or not. 67b8497f005f is not in my tree, so
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] of: property: fix #nvmem-cell-cells parsing
2023-01-13 1:33 ` Rob Herring
@ 2023-01-13 10:20 ` Michael Walle
0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2023-01-13 10:20 UTC (permalink / raw)
To: Rob Herring
Cc: Robert Marko, Frank Rowand, Peng Fan, Miquel Raynal,
Alexander Stein, devicetree, Srinivas Kandagatla, linux-kernel,
Aisheng Dong
>> > Commit 67b8497f005f ("of: property: make #.*-cells optional for simple
>> > props") claims to make the cells-name property optional for simple
>> > properties, but changed the code for the wrong property, i.e. for
>> > DEFINE_SUFFIX_PROP(). Fix that.
>> >
>> > Fixes: 67b8497f005f ("of: property: make #.*-cells optional for simple props")
>> > Reported-by: Peng Fan <peng.fan@nxp.com>
>> > Signed-off-by: Michael Walle <michael@walle.cc>
>> > Tested-by: Robert Marko <robimarko@gmail.com>
>> > ---
>> > drivers/of/property.c | 8 ++++----
>> > 1 file changed, 4 insertions(+), 4 deletions(-)
>> >
>>
>> Applied, thanks!
>
> Or not. 67b8497f005f is not in my tree, so
>
> Acked-by: Rob Herring <robh@kernel.org>
Thanks! Srinivas, can you pick it up to get rid of the errors/warnings
in linux-next?
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] of: property: fix #nvmem-cell-cells parsing
2023-01-10 23:30 [PATCH] of: property: fix #nvmem-cell-cells parsing Michael Walle
2023-01-11 2:45 ` Peng Fan
2023-01-13 1:32 ` Rob Herring
@ 2023-01-20 17:48 ` Srinivas Kandagatla
2 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2023-01-20 17:48 UTC (permalink / raw)
To: Michael Walle, Rob Herring, Frank Rowand, Robert Marko,
Alexander Stein, Peng Fan, Miquel Raynal
Cc: devicetree, linux-kernel, Aisheng Dong
On 10/01/2023 23:30, Michael Walle wrote:
> Commit 67b8497f005f ("of: property: make #.*-cells optional for simple
> props") claims to make the cells-name property optional for simple
> properties, but changed the code for the wrong property, i.e. for
> DEFINE_SUFFIX_PROP(). Fix that.
>
> Fixes: 67b8497f005f ("of: property: make #.*-cells optional for simple props")
> Reported-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
> Tested-by: Robert Marko <robimarko@gmail.com>
> ---
Applied thanks,
--srini
> drivers/of/property.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index 8d9ba20a8f90..95b838185b2f 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1202,8 +1202,8 @@ static struct device_node *parse_prop_cells(struct device_node *np,
> if (strcmp(prop_name, list_name))
> return NULL;
>
> - if (of_parse_phandle_with_args(np, list_name, cells_name, index,
> - &sup_args))
> + if (__of_parse_phandle_with_args(np, list_name, cells_name, 0, index,
> + &sup_args))
> return NULL;
>
> return sup_args.np;
> @@ -1256,8 +1256,8 @@ static struct device_node *parse_suffix_prop_cells(struct device_node *np,
> if (strcmp_suffix(prop_name, suffix))
> return NULL;
>
> - if (__of_parse_phandle_with_args(np, prop_name, cells_name, 0, index,
> - &sup_args))
> + if (of_parse_phandle_with_args(np, prop_name, cells_name, index,
> + &sup_args))
> return NULL;
>
> return sup_args.np;
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-20 17:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10 23:30 [PATCH] of: property: fix #nvmem-cell-cells parsing Michael Walle
2023-01-11 2:45 ` Peng Fan
2023-01-13 1:32 ` Rob Herring
2023-01-13 1:33 ` Rob Herring
2023-01-13 10:20 ` Michael Walle
2023-01-20 17:48 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).