From: houlong wei <firstname.lastname@example.org> To: Eizan Miyamoto <email@example.com>, "firstname.lastname@example.org" <email@example.com> Cc: "firstname.lastname@example.org" <email@example.com>, "Yong Wu (吴勇)" <Yong.Wu@mediatek.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "Andrew-CT Chen (陳智迪)" <Andrew-CT.Chen@mediatek.com>, "Matthias Brugger" <firstname.lastname@example.org>, "Mauro Carvalho Chehab" <email@example.com>, "Minghsiu Tsai (蔡明修)" <Minghsiu.Tsai@mediatek.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH v6 2/9] mtk-mdp: add driver to probe mdp components Date: Mon, 16 Aug 2021 09:05:54 +0800 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20210802220943.v6.2.Ie6d1e6e39cf9b5d6b2108ae1096af34c3d55880b@changeid> On Mon, 2021-08-02 at 20:12 +0800, Eizan Miyamoto wrote: > Broadly, this patch (1) adds a driver for various MTK MDP components > to > go alongside the main MTK MDP driver, and (2) hooks them all together > using the component framework. > > (1) Up until now, the MTK MDP driver controls 8 devices in the device > tree on its own. When running tests for the hardware video decoder, > we > found that the iommus and LARBs were not being properly configured. > To > configure them, a driver for each be added to mtk_mdp_comp so that > mtk_iommu_add_device() can (eventually) be called from > dma_configure() > inside really_probe(). > > (2) The integration into the component framework allows us to defer > the > registration with the v4l2 subsystem until all the MDP-related > devices > have been probed, so that the relevant device node does not become > available until initialization of all the components is complete. > > Some notes about how the component framework has been integrated: > > - The driver for the rdma0 component serves double duty as the > "master" > (aggregate) driver as well as a component driver. This is a non- > ideal > compromise until a better solution is developed. This device is > differentiated from the rest by checking for a "mediatek,vpu" > property > in the device node. > > - The list of mdp components remains hard-coded as > mtk_mdp_comp_dt_ids > in mtk_mdp_core.c, and as mtk_mdp_comp_driver_dt_match in > mtk_mdp_comp.c. This unfortunate duplication of information is > addressed in a following patch in this series. > > - The component driver calls component_add() for each device that is > probed. > > - In mtk_mdp_probe (the "master" device), we scan the device tree for > any matching nodes against mtk_mdp_comp_dt_ids, and add component > matches for them. The match criteria is a matching device node > pointer. > > - When the set of components devices that have been probed > corresponds > with the list that is generated by the "master", the callback to > mtk_mdp_master_bind() is made, which then calls the component bind > functions. > > - Inside mtk_mdp_master_bind(), once all the component bind functions > have been called, we can then register our device to the v4l2 > subsystem. > > - The call to pm_runtime_enable() in the master device is called > after > all the components have been registered by their bind() functions > called by mtk_mtp_master_bind(). As a result, the list of > components > will not change while power management callbacks mtk_mdp_suspend()/ > resume() are accessing the list of components. > > Signed-off-by: Eizan Miyamoto <firstname.lastname@example.org> > --- > Reviewed-by: Houlong Wei <email@example.com> > (no changes since v1) > [...]
next prev parent reply other threads:[~2021-08-16 1:06 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-02 12:12 [PATCH v6 0/9] Refactor MTK MDP driver into core/components Eizan Miyamoto 2021-08-02 12:12 ` [PATCH v6 1/9] mtk-mdp: propagate errors from clock_on Eizan Miyamoto 2021-08-03 10:26 ` Enric Balletbo Serra 2021-08-05 6:06 ` Dafna Hirschfeld 2021-08-09 3:23 ` Eizan Miyamoto 2021-08-09 7:42 ` Dafna Hirschfeld 2021-08-16 0:46 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 2/9] mtk-mdp: add driver to probe mdp components Eizan Miyamoto 2021-08-03 10:26 ` Enric Balletbo Serra 2021-08-05 6:40 ` Dafna Hirschfeld 2021-08-09 3:23 ` Eizan Miyamoto 2021-08-09 7:53 ` Dafna Hirschfeld 2021-08-11 11:15 ` Eizan Miyamoto 2021-08-16 1:05 ` houlong wei [this message] 2021-08-02 12:12 ` [PATCH v6 3/9] mtk-mdp: use pm_runtime in MDP component driver Eizan Miyamoto 2021-08-03 10:26 ` Enric Balletbo Serra 2021-08-16 1:07 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 4/9] media: mtk-mdp: don't pm_run_time_get/put for master comp in clock_on Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-16 1:10 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 5/9] mtk-mdp: make mdp driver to be loadable by platform_device_register*() Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-16 1:15 ` houlong wei 2021-08-16 3:37 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 6/9] soc: mediatek: mmsys: instantiate mdp virtual device from mmsys Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-16 1:18 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 7/9] media: mtk-mdp: use mdp-rdma0 alias to point to MDP master Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-03 11:46 ` Eizan Miyamoto 2021-08-16 3:00 ` houlong wei 2021-08-16 4:52 ` houlong wei 2021-08-18 7:50 ` Eizan Miyamoto 2021-08-18 15:42 ` houlong wei 2021-08-18 7:43 ` Eizan Miyamoto 2021-08-18 15:34 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 8/9] dts: mtk-mdp: remove mediatek,vpu property from primary MDP device Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-02 12:12 ` [PATCH v6 9/9] dt-bindings: mediatek: remove vpu requirement from mtk-mdp Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-06 21:47 ` Rob Herring 2021-08-03 10:29 ` [PATCH v6 0/9] Refactor MTK MDP driver into core/components Enric Balletbo Serra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Andrew-CT.Chen@mediatek.com \ --cc=Minghsiu.Tsai@mediatek.com \ --cc=Yong.Wu@mediatek.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v6 2/9] mtk-mdp: add driver to probe mdp components' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).