From: pnagar@codeaurora.org
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
jmorris@namei.org, serge@hallyn.com, paul@paul-moore.com,
stephen.smalley.work@gmail.com, eparis@parisplace.org,
linux-security-module <linux-security-module@vger.kernel.org>,
selinux@vger.kernel.org, linux-arch <linux-arch@vger.kernel.org>,
psodagud@codeaurora.org, nmardana@codeaurora.org,
dsule@codeaurora.org, Joe Perches <joe@perches.com>,
Miguel Ojeda <ojeda@kernel.org>,
Nick Desaulniers <ndesaulniers@gooogle.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2] selinux: security: Move selinux_state to a separate page
Date: Mon, 11 Jan 2021 11:55:28 +0530 [thread overview]
Message-ID: <afa0b8674f87c3cac17bf725c826d37e@codeaurora.org> (raw)
In-Reply-To: <CANiq72=y7gapKpVKFwu30jDpv4qswgo5K3+u5QMOY4dtacKX=Q@mail.gmail.com>
On 2021-01-08 20:55, Miguel Ojeda wrote:
> On Fri, Jan 8, 2021 at 10:52 AM Preeti Nagar <pnagar@codeaurora.org>
> wrote:
>>
>> We want to seek your suggestions and comments on the idea and the
>> changes
>> in the patch.
>
> Not sure why I was Cc'd, but I have a quick comment nevertheless.
>
>> +#ifdef CONFIG_SECURITY_RTIC
>> +struct selinux_state selinux_state __rticdata;
>> +#else
>> struct selinux_state selinux_state;
>> +#endif
>
> If you define an empty __rticdata for the !CONFIG case, then we don't
> need #ifdefs for uses like this.
>
> Cheers,
> Miguel
Thank you for the review! Will update this change in the next version of
the patch soon.
Thanks,
Preeti
next prev parent reply other threads:[~2021-01-11 6:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 9:49 [RFC PATCH v2] selinux: security: Move selinux_state to a separate page Preeti Nagar
2021-01-08 15:25 ` Miguel Ojeda
2021-01-11 6:25 ` pnagar [this message]
2021-01-08 15:28 ` Miguel Ojeda
2021-01-08 17:11 ` Casey Schaufler
2021-01-12 9:36 ` pnagar
2021-01-12 17:06 ` Casey Schaufler
2021-01-13 10:56 ` David Howells
2021-01-18 6:15 ` pnagar
2021-01-09 1:01 ` Nick Desaulniers
2021-01-11 9:51 ` pnagar
2021-01-18 5:56 pnagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afa0b8674f87c3cac17bf725c826d37e@codeaurora.org \
--to=pnagar@codeaurora.org \
--cc=arnd@arndb.de \
--cc=dsule@codeaurora.org \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ndesaulniers@gooogle.com \
--cc=nmardana@codeaurora.org \
--cc=ojeda@kernel.org \
--cc=paul@paul-moore.com \
--cc=psodagud@codeaurora.org \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).