* [PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control whitelist
@ 2020-06-21 4:27 Jeffrey Lin
2020-06-21 4:52 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Jeffrey Lin @ 2020-06-21 4:27 UTC (permalink / raw)
To: Jean Delvare
Cc: Guenter Roeck, linux-hwmon, linux-kernel, Jeffrey Lin, Pali Rohár
This allows manual PWM control without the BIOS fighting back on Dell
Latitude 5480.
Signed-off-by: Jeffrey Lin <jeffrey@icurse.nl>
Acked-by: Pali Rohár <pali@kernel.org>
---
drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 16be012a95ed..ec448f5f2dc3 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1187,6 +1187,14 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = {
},
.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
},
+ {
+ .ident = "Dell Latitude 5480",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5480"),
+ },
+ .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+ },
{
.ident = "Dell Latitude E6440",
.matches = {
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control whitelist
2020-06-21 4:27 [PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control whitelist Jeffrey Lin
@ 2020-06-21 4:52 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2020-06-21 4:52 UTC (permalink / raw)
To: Jeffrey Lin, Jean Delvare; +Cc: linux-hwmon, linux-kernel, Pali Rohár
On 6/20/20 9:27 PM, Jeffrey Lin wrote:
> This allows manual PWM control without the BIOS fighting back on Dell
> Latitude 5480.
>
> Signed-off-by: Jeffrey Lin <jeffrey@icurse.nl>
> Acked-by: Pali Rohár <pali@kernel.org>
Is this a resend of v1, or is it different ? If it is different, what changed ?
Guenter
> ---
> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 16be012a95ed..ec448f5f2dc3 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1187,6 +1187,14 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> },
> + {
> + .ident = "Dell Latitude 5480",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5480"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> + },
> {
> .ident = "Dell Latitude E6440",
> .matches = {
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control whitelist
2020-06-19 12:18 ` Pali Rohár
@ 2020-06-20 3:09 ` Jeffrey Lin
0 siblings, 0 replies; 5+ messages in thread
From: Jeffrey Lin @ 2020-06-20 3:09 UTC (permalink / raw)
To: Pali Rohár; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]
On Fri, 19 Jun 2020 14:18:21 +0200
Pali Rohár <pali@kernel.org> wrote:
>On Thursday 18 June 2020 21:55:29 Jeffrey Lin wrote:
>> This allows manual PWM control without the BIOS fighting back on Dell
>> Latitude 5480.
>>
>> Signed-off-by: Jeffrey Lin <jeffrey@icurse.nl>
>
>If it is working fine on your machine, you can add my:
Yes, the below patch works on my machine. dmesg reports "dell_smm_hwmon:
enabling support for setting automatic/manual fan control" and writing 1 to
/sys/class/hwmon/hwmon4/pwm1_enable allows pwmconfig/fancontrol full control.
>
>Acked-by: Pali Rohár <pali@kernel.org>
>
>> ---
>> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
>> index 16be012a95ed..ec448f5f2dc3 100644
>> --- a/drivers/hwmon/dell-smm-hwmon.c
>> +++ b/drivers/hwmon/dell-smm-hwmon.c
>> @@ -1187,6 +1187,14 @@ static struct dmi_system_id
>> i8k_whitelist_fan_control[] __initdata = { },
>> .driver_data = (void
>> *)&i8k_fan_control_data[I8K_FAN_34A3_35A3], },
>> + {
>> + .ident = "Dell Latitude 5480",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5480"),
>> + },
>> + .driver_data = (void
>> *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>> + },
>> {
>> .ident = "Dell Latitude E6440",
>> .matches = {
>> --
>> 2.27.0
>>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control whitelist
2020-06-19 1:55 Jeffrey Lin
@ 2020-06-19 12:18 ` Pali Rohár
2020-06-20 3:09 ` Jeffrey Lin
0 siblings, 1 reply; 5+ messages in thread
From: Pali Rohár @ 2020-06-19 12:18 UTC (permalink / raw)
To: Jeffrey Lin; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
On Thursday 18 June 2020 21:55:29 Jeffrey Lin wrote:
> This allows manual PWM control without the BIOS fighting back on Dell
> Latitude 5480.
>
> Signed-off-by: Jeffrey Lin <jeffrey@icurse.nl>
If it is working fine on your machine, you can add my:
Acked-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 16be012a95ed..ec448f5f2dc3 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1187,6 +1187,14 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> },
> + {
> + .ident = "Dell Latitude 5480",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5480"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> + },
> {
> .ident = "Dell Latitude E6440",
> .matches = {
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control whitelist
@ 2020-06-19 1:55 Jeffrey Lin
2020-06-19 12:18 ` Pali Rohár
0 siblings, 1 reply; 5+ messages in thread
From: Jeffrey Lin @ 2020-06-19 1:55 UTC (permalink / raw)
To: pali; +Cc: jdelvare, linux, linux-hwmon, linux-kernel, Jeffrey Lin
This allows manual PWM control without the BIOS fighting back on Dell
Latitude 5480.
Signed-off-by: Jeffrey Lin <jeffrey@icurse.nl>
---
drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 16be012a95ed..ec448f5f2dc3 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1187,6 +1187,14 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = {
},
.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
},
+ {
+ .ident = "Dell Latitude 5480",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5480"),
+ },
+ .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+ },
{
.ident = "Dell Latitude E6440",
.matches = {
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-21 4:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-21 4:27 [PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control whitelist Jeffrey Lin
2020-06-21 4:52 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2020-06-19 1:55 Jeffrey Lin
2020-06-19 12:18 ` Pali Rohár
2020-06-20 3:09 ` Jeffrey Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).