* [PATCH] x86,edac: fix for compiler error in traps.c
[not found] <alpine.DEB.2.00.0904081954530.16430@gandalf.stny.rr.com>
@ 2009-04-09 0:06 ` Steven Rostedt
2009-04-09 0:48 ` Andrew Morton
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Steven Rostedt @ 2009-04-09 0:06 UTC (permalink / raw)
To: Ingo Molnar; +Cc: LKML, Andrew Morton
Impact: compile fix
I got this compile failure on both tip/tracing/core as well as on
v2.6.30-rc1.
LD .tmp_vmlinux1
arch/x86/kernel/built-in.o: In function `do_nmi':
(.text+0x3c18): undefined reference to `edac_handler_set'
arch/x86/kernel/built-in.o: In function `do_nmi':
(.text+0x3c48): undefined reference to `edac_atomic_assert_error'
make: *** [.tmp_vmlinux1] Error 1
[root@bxrhel51 linux-trace.git]# grep edac_handler_set
[root@bxrhel51 linux-trace.git]# Grep edac_handler_set '*.[ch]'
find . -name "*.[ch]" ! -type d | xargs grep "edac_handler_set"
./arch/x86/kernel/traps.c: if (edac_handler_set()) {
./include/linux/edac.h:extern int edac_handler_set(void);
./drivers/edac/edac_stub.c:int edac_handler_set(void)
./drivers/edac/edac_stub.c:EXPORT_SYMBOL_GPL(edac_handler_set);
This patch seems to fix it.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
index a5fdcf0..cc2bcb4 100644
--- a/drivers/edac/Makefile
+++ b/drivers/edac/Makefile
@@ -7,7 +7,7 @@
#
-obj-$(CONFIG_EDAC) := edac_stub.o
+obj-$(CONFIG_EDAC) += edac_stub.o
obj-$(CONFIG_EDAC_MM_EDAC) += edac_core.o
edac_core-objs := edac_mc.o edac_device.o edac_mc_sysfs.o edac_pci_sysfs.o
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] x86,edac: fix for compiler error in traps.c
2009-04-09 0:06 ` [PATCH] x86,edac: fix for compiler error in traps.c Steven Rostedt
@ 2009-04-09 0:48 ` Andrew Morton
2009-04-09 15:07 ` Steven Rostedt
2009-04-09 0:52 ` Andrew Morton
2009-04-09 3:58 ` Ingo Molnar
2 siblings, 1 reply; 7+ messages in thread
From: Andrew Morton @ 2009-04-09 0:48 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Ingo Molnar, LKML, Doug Thompson
On Wed, 8 Apr 2009 20:06:53 -0400 (EDT) Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Impact: compile fix
>
> I got this compile failure on both tip/tracing/core as well as on
> v2.6.30-rc1.
>
> LD .tmp_vmlinux1
> arch/x86/kernel/built-in.o: In function `do_nmi':
> (.text+0x3c18): undefined reference to `edac_handler_set'
> arch/x86/kernel/built-in.o: In function `do_nmi':
> (.text+0x3c48): undefined reference to `edac_atomic_assert_error'
> make: *** [.tmp_vmlinux1] Error 1
> [root@bxrhel51 linux-trace.git]# grep edac_handler_set
> [root@bxrhel51 linux-trace.git]# Grep edac_handler_set '*.[ch]'
> find . -name "*.[ch]" ! -type d | xargs grep "edac_handler_set"
> ./arch/x86/kernel/traps.c: if (edac_handler_set()) {
> ./include/linux/edac.h:extern int edac_handler_set(void);
> ./drivers/edac/edac_stub.c:int edac_handler_set(void)
> ./drivers/edac/edac_stub.c:EXPORT_SYMBOL_GPL(edac_handler_set);
>
> This patch seems to fix it.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
> index a5fdcf0..cc2bcb4 100644
> --- a/drivers/edac/Makefile
> +++ b/drivers/edac/Makefile
> @@ -7,7 +7,7 @@
> #
>
>
> -obj-$(CONFIG_EDAC) := edac_stub.o
> +obj-$(CONFIG_EDAC) += edac_stub.o
> obj-$(CONFIG_EDAC_MM_EDAC) += edac_core.o
>
> edac_core-objs := edac_mc.o edac_device.o edac_mc_sysfs.o edac_pci_sysfs.o
OK, thanks, I'll send that Linuswards asap.
I guess it could/should be
obj-y += edac_stub.o
because CONFIG_EDAC is known to be true in drivers/edac/. But that's
just a consistency/style thing for Doug to scratch his head over ;)
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] x86,edac: fix for compiler error in traps.c
2009-04-09 0:48 ` Andrew Morton
@ 2009-04-09 15:07 ` Steven Rostedt
0 siblings, 0 replies; 7+ messages in thread
From: Steven Rostedt @ 2009-04-09 15:07 UTC (permalink / raw)
To: Andrew Morton; +Cc: Ingo Molnar, LKML, Doug Thompson
Andrew, I guess this change is not needed. Ingo was correct, there must
have been something wrong with my build environment. Not sure what
happened, but I had this failure right after updating my git repo. I did
not do a make clean, so my build environment was not pristine. After doing
a make clean, I no longer have this error.
Sorry for the noise.
-- Steve
On Wed, 8 Apr 2009, Andrew Morton wrote:
> On Wed, 8 Apr 2009 20:06:53 -0400 (EDT) Steven Rostedt <rostedt@goodmis.org> wrote:
>
> >
> > Impact: compile fix
> >
> > I got this compile failure on both tip/tracing/core as well as on
> > v2.6.30-rc1.
> >
> > LD .tmp_vmlinux1
> > arch/x86/kernel/built-in.o: In function `do_nmi':
> > (.text+0x3c18): undefined reference to `edac_handler_set'
> > arch/x86/kernel/built-in.o: In function `do_nmi':
> > (.text+0x3c48): undefined reference to `edac_atomic_assert_error'
> > make: *** [.tmp_vmlinux1] Error 1
> > [root@bxrhel51 linux-trace.git]# grep edac_handler_set
> > [root@bxrhel51 linux-trace.git]# Grep edac_handler_set '*.[ch]'
> > find . -name "*.[ch]" ! -type d | xargs grep "edac_handler_set"
> > ./arch/x86/kernel/traps.c: if (edac_handler_set()) {
> > ./include/linux/edac.h:extern int edac_handler_set(void);
> > ./drivers/edac/edac_stub.c:int edac_handler_set(void)
> > ./drivers/edac/edac_stub.c:EXPORT_SYMBOL_GPL(edac_handler_set);
> >
> > This patch seems to fix it.
> >
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> >
> > diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
> > index a5fdcf0..cc2bcb4 100644
> > --- a/drivers/edac/Makefile
> > +++ b/drivers/edac/Makefile
> > @@ -7,7 +7,7 @@
> > #
> >
> >
> > -obj-$(CONFIG_EDAC) := edac_stub.o
> > +obj-$(CONFIG_EDAC) += edac_stub.o
> > obj-$(CONFIG_EDAC_MM_EDAC) += edac_core.o
> >
> > edac_core-objs := edac_mc.o edac_device.o edac_mc_sysfs.o edac_pci_sysfs.o
>
> OK, thanks, I'll send that Linuswards asap.
>
> I guess it could/should be
>
> obj-y += edac_stub.o
>
> because CONFIG_EDAC is known to be true in drivers/edac/. But that's
> just a consistency/style thing for Doug to scratch his head over ;)
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] x86,edac: fix for compiler error in traps.c
2009-04-09 0:06 ` [PATCH] x86,edac: fix for compiler error in traps.c Steven Rostedt
2009-04-09 0:48 ` Andrew Morton
@ 2009-04-09 0:52 ` Andrew Morton
2009-04-09 3:58 ` Ingo Molnar
2 siblings, 0 replies; 7+ messages in thread
From: Andrew Morton @ 2009-04-09 0:52 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Ingo Molnar, LKML
On Wed, 8 Apr 2009 20:06:53 -0400 (EDT) Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Impact: compile fix
>
> I got this compile failure on both tip/tracing/core as well as on
> v2.6.30-rc1.
>
> LD .tmp_vmlinux1
> arch/x86/kernel/built-in.o: In function `do_nmi':
> (.text+0x3c18): undefined reference to `edac_handler_set'
> arch/x86/kernel/built-in.o: In function `do_nmi':
> (.text+0x3c48): undefined reference to `edac_atomic_assert_error'
> make: *** [.tmp_vmlinux1] Error 1
> [root@bxrhel51 linux-trace.git]# grep edac_handler_set
> [root@bxrhel51 linux-trace.git]# Grep edac_handler_set '*.[ch]'
> find . -name "*.[ch]" ! -type d | xargs grep "edac_handler_set"
> ./arch/x86/kernel/traps.c: if (edac_handler_set()) {
> ./include/linux/edac.h:extern int edac_handler_set(void);
> ./drivers/edac/edac_stub.c:int edac_handler_set(void)
> ./drivers/edac/edac_stub.c:EXPORT_SYMBOL_GPL(edac_handler_set);
>
> This patch seems to fix it.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
> index a5fdcf0..cc2bcb4 100644
> --- a/drivers/edac/Makefile
> +++ b/drivers/edac/Makefile
> @@ -7,7 +7,7 @@
> #
>
>
> -obj-$(CONFIG_EDAC) := edac_stub.o
> +obj-$(CONFIG_EDAC) += edac_stub.o
> obj-$(CONFIG_EDAC_MM_EDAC) += edac_core.o
>
> edac_core-objs := edac_mc.o edac_device.o edac_mc_sysfs.o edac_pci_sysfs.o
Confused. Why didn't 2.6.29 break?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] x86,edac: fix for compiler error in traps.c
2009-04-09 0:06 ` [PATCH] x86,edac: fix for compiler error in traps.c Steven Rostedt
2009-04-09 0:48 ` Andrew Morton
2009-04-09 0:52 ` Andrew Morton
@ 2009-04-09 3:58 ` Ingo Molnar
2009-04-09 14:51 ` Steven Rostedt
2 siblings, 1 reply; 7+ messages in thread
From: Ingo Molnar @ 2009-04-09 3:58 UTC (permalink / raw)
To: Steven Rostedt, Sam Ravnborg; +Cc: LKML, Andrew Morton
* Steven Rostedt <rostedt@goodmis.org> wrote:
> Impact: compile fix
>
> I got this compile failure on both tip/tracing/core as well as on
> v2.6.30-rc1.
>
> LD .tmp_vmlinux1
> arch/x86/kernel/built-in.o: In function `do_nmi':
> (.text+0x3c18): undefined reference to `edac_handler_set'
> arch/x86/kernel/built-in.o: In function `do_nmi':
> (.text+0x3c48): undefined reference to `edac_atomic_assert_error'
> make: *** [.tmp_vmlinux1] Error 1
> [root@bxrhel51 linux-trace.git]# grep edac_handler_set
> [root@bxrhel51 linux-trace.git]# Grep edac_handler_set '*.[ch]'
> find . -name "*.[ch]" ! -type d | xargs grep "edac_handler_set"
> ./arch/x86/kernel/traps.c: if (edac_handler_set()) {
> ./include/linux/edac.h:extern int edac_handler_set(void);
> ./drivers/edac/edac_stub.c:int edac_handler_set(void)
> ./drivers/edac/edac_stub.c:EXPORT_SYMBOL_GPL(edac_handler_set);
>
> This patch seems to fix it.
> -obj-$(CONFIG_EDAC) := edac_stub.o
> +obj-$(CONFIG_EDAC) += edac_stub.o
> obj-$(CONFIG_EDAC_MM_EDAC) += edac_core.o
It's weird that this breaks for you. What other bit of the kernel
introduces CONFIG_EDAC rules?
And it's clean to start driver rules with the := assignment and then
append to them via +=. The initial += should not be needed.
Are you sure you have a pristine build environment?
Ingo
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] x86,edac: fix for compiler error in traps.c
2009-04-09 3:58 ` Ingo Molnar
@ 2009-04-09 14:51 ` Steven Rostedt
0 siblings, 0 replies; 7+ messages in thread
From: Steven Rostedt @ 2009-04-09 14:51 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Sam Ravnborg, LKML, Andrew Morton
On Thu, 9 Apr 2009, Ingo Molnar wrote:
>
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > Impact: compile fix
> >
> > I got this compile failure on both tip/tracing/core as well as on
> > v2.6.30-rc1.
> >
> > LD .tmp_vmlinux1
> > arch/x86/kernel/built-in.o: In function `do_nmi':
> > (.text+0x3c18): undefined reference to `edac_handler_set'
> > arch/x86/kernel/built-in.o: In function `do_nmi':
> > (.text+0x3c48): undefined reference to `edac_atomic_assert_error'
> > make: *** [.tmp_vmlinux1] Error 1
> > [root@bxrhel51 linux-trace.git]# grep edac_handler_set
> > [root@bxrhel51 linux-trace.git]# Grep edac_handler_set '*.[ch]'
> > find . -name "*.[ch]" ! -type d | xargs grep "edac_handler_set"
> > ./arch/x86/kernel/traps.c: if (edac_handler_set()) {
> > ./include/linux/edac.h:extern int edac_handler_set(void);
> > ./drivers/edac/edac_stub.c:int edac_handler_set(void)
> > ./drivers/edac/edac_stub.c:EXPORT_SYMBOL_GPL(edac_handler_set);
> >
> > This patch seems to fix it.
>
> > -obj-$(CONFIG_EDAC) := edac_stub.o
> > +obj-$(CONFIG_EDAC) += edac_stub.o
> > obj-$(CONFIG_EDAC_MM_EDAC) += edac_core.o
>
> It's weird that this breaks for you. What other bit of the kernel
> introduces CONFIG_EDAC rules?
>
> And it's clean to start driver rules with the := assignment and then
> append to them via +=. The initial += should not be needed.
>
> Are you sure you have a pristine build environment?
Good question.
I'll do a make clean and try again and let you know.
-- Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] x86,edac: fix for compiler error in traps.c
@ 2009-04-09 18:41 Doug Thompson
0 siblings, 0 replies; 7+ messages in thread
From: Doug Thompson @ 2009-04-09 18:41 UTC (permalink / raw)
To: Steven Rostedt, Andrew Morton; +Cc: Ingo Molnar, LKML
--- On Wed, 4/8/09, Andrew Morton <akpm@linux-foundation.org> wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: Re: [PATCH] x86,edac: fix for compiler error in traps.c
> To: "Steven Rostedt" <rostedt@goodmis.org>
> Cc: "Ingo Molnar" <mingo@elte.hu>, "LKML" <linux-kernel@vger.kernel.org>, "Doug Thompson" <norsk5@yahoo.com>
> Date: Wednesday, April 8, 2009, 6:48 PM
> On Wed, 8 Apr 2009 20:06:53 -0400
> (EDT) Steven Rostedt <rostedt@goodmis.org>
> wrote:
>
> >
> > Impact: compile fix
> >
> > I got this compile failure on both
> tip/tracing/core as well as on
> > v2.6.30-rc1.
> >
> > LD .tmp_vmlinux1
> > arch/x86/kernel/built-in.o: In function
> `do_nmi':
> > (.text+0x3c18): undefined reference to
> `edac_handler_set'
> > arch/x86/kernel/built-in.o: In function
> `do_nmi':
> > (.text+0x3c48): undefined reference to
> `edac_atomic_assert_error'
> > make: *** [.tmp_vmlinux1] Error 1
> > [root@bxrhel51 linux-trace.git]# grep
> edac_handler_set
> > [root@bxrhel51 linux-trace.git]# Grep
> edac_handler_set '*.[ch]'
> > find . -name "*.[ch]" ! -type d |
> xargs grep "edac_handler_set"
> > ./arch/x86/kernel/traps.c: if
> (edac_handler_set()) {
> > ./include/linux/edac.h:extern int
> edac_handler_set(void);
> > ./drivers/edac/edac_stub.c:int
> edac_handler_set(void)
> >
> ./drivers/edac/edac_stub.c:EXPORT_SYMBOL_GPL(edac_handler_set);
> >
> > This patch seems to fix it.
> >
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> >
> > diff --git a/drivers/edac/Makefile
> b/drivers/edac/Makefile
> > index a5fdcf0..cc2bcb4 100644
> > --- a/drivers/edac/Makefile
> > +++ b/drivers/edac/Makefile
> > @@ -7,7 +7,7 @@
> > #
> >
> >
> > -obj-$(CONFIG_EDAC)
> := edac_stub.o
> > +obj-$(CONFIG_EDAC)
> += edac_stub.o
> > obj-$(CONFIG_EDAC_MM_EDAC)
> += edac_core.o
> >
> > edac_core-objs := edac_mc.o
> edac_device.o edac_mc_sysfs.o edac_pci_sysfs.o
>
> OK, thanks, I'll send that Linuswards asap.
>
> I guess it could/should be
>
> obj-y += edac_stub.o
>
> because CONFIG_EDAC is known to be true in
> drivers/edac/. But that's
> just a consistency/style thing for Doug to scratch his head
> over ;)
I had determined (long ago) that := was a first instance initialization. I could be (probably was) wrong on that. I saw that in other files as well as reading the docs (me read em?).
edac_stub.o is targeted to be IN the kernel via the CONFIG_EDAC object file, since that is a boolean switch. It is a different builtin lib from the modules of edac. It is a relay set of functions and interfaces.
thanks for checking up on it
doug t
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-04-09 18:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <alpine.DEB.2.00.0904081954530.16430@gandalf.stny.rr.com>
2009-04-09 0:06 ` [PATCH] x86,edac: fix for compiler error in traps.c Steven Rostedt
2009-04-09 0:48 ` Andrew Morton
2009-04-09 15:07 ` Steven Rostedt
2009-04-09 0:52 ` Andrew Morton
2009-04-09 3:58 ` Ingo Molnar
2009-04-09 14:51 ` Steven Rostedt
2009-04-09 18:41 Doug Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).