linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] testusb: add path /dev/bus/usb to default search paths of usbfs
@ 2012-05-22  6:50 Du, ChangbinX
  2012-05-22 22:42 ` David Rientjes
  2012-06-13 23:15 ` gregkh
  0 siblings, 2 replies; 4+ messages in thread
From: Du, ChangbinX @ 2012-05-22  6:50 UTC (permalink / raw)
  To: gregkh, David Rientjes
  Cc: Sergei Shtylyov, mina86, Fleming, Matt, balbi, hpa, linux-kernel,
	linux-usb

As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
are mostly used today, let testusb tool use that directory as one default
path make tool be more convenient to use.

Signed-off-by: Du Changbin <changbinx.du@intel.com>
---
 tools/usb/testusb.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
index 6e0f567..0aac3ff 100644
--- a/tools/usb/testusb.c
+++ b/tools/usb/testusb.c
@@ -358,9 +358,11 @@ static const char *usbfs_dir_find(void)
 {
 	static char usbfs_path_0[] = "/dev/usb/devices";
 	static char usbfs_path_1[] = "/proc/bus/usb/devices";
+	/* real device-nodes managed by udev */
+	static char udev_usb_path[] = "/dev/bus/usb/";
 
 	static char *const usbfs_paths[] = {
-		usbfs_path_0, usbfs_path_1
+		usbfs_path_0, usbfs_path_1, udev_usb_path,
 	};
 
 	static char *const *
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] testusb: add path /dev/bus/usb to default search paths of usbfs
  2012-05-22  6:50 [PATCH v3] testusb: add path /dev/bus/usb to default search paths of usbfs Du, ChangbinX
@ 2012-05-22 22:42 ` David Rientjes
  2012-06-13 23:15 ` gregkh
  1 sibling, 0 replies; 4+ messages in thread
From: David Rientjes @ 2012-05-22 22:42 UTC (permalink / raw)
  To: Du, ChangbinX
  Cc: gregkh, Sergei Shtylyov, mina86, Fleming, Matt, balbi, hpa,
	linux-kernel, linux-usb

On Tue, 22 May 2012, Du, ChangbinX wrote:

> As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
> are mostly used today, let testusb tool use that directory as one default
> path make tool be more convenient to use.
> 
> Signed-off-by: Du Changbin <changbinx.du@intel.com>

Acked-by: David Rientjes <rientjes@google.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] testusb: add path /dev/bus/usb to default search paths of usbfs
  2012-05-22  6:50 [PATCH v3] testusb: add path /dev/bus/usb to default search paths of usbfs Du, ChangbinX
  2012-05-22 22:42 ` David Rientjes
@ 2012-06-13 23:15 ` gregkh
  2012-06-14  1:57   ` Du, ChangbinX
  1 sibling, 1 reply; 4+ messages in thread
From: gregkh @ 2012-06-13 23:15 UTC (permalink / raw)
  To: Du, ChangbinX
  Cc: David Rientjes, Sergei Shtylyov, mina86, Fleming, Matt, balbi,
	hpa, linux-kernel, linux-usb

On Tue, May 22, 2012 at 06:50:24AM +0000, Du, ChangbinX wrote:
> As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
> are mostly used today, let testusb tool use that directory as one default
> path make tool be more convenient to use.
> 
> Signed-off-by: Du Changbin <changbinx.du@intel.com>

This patch does not apply, what tree did you make it against?  Can you
redo it against the next linux-next release and resend it so I can apply
it?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v3] testusb: add path /dev/bus/usb to default search paths of usbfs
  2012-06-13 23:15 ` gregkh
@ 2012-06-14  1:57   ` Du, ChangbinX
  0 siblings, 0 replies; 4+ messages in thread
From: Du, ChangbinX @ 2012-06-14  1:57 UTC (permalink / raw)
  To: gregkh
  Cc: David Rientjes, Sergei Shtylyov, mina86, Fleming, Matt, balbi,
	hpa, linux-kernel, linux-usb

> On Tue, May 22, 2012 at 06:50:24AM +0000, Du, ChangbinX wrote:
> > As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
> > are mostly used today, let testusb tool use that directory as one
> > default path make tool be more convenient to use.
> >
> > Signed-off-by: Du Changbin <changbinx.du@intel.com>
> 
> This patch does not apply, what tree did you make it against?  Can you redo it
> against the next linux-next release and resend it so I can apply it?

I am very sorry about this. I found this patch has already applied on your tree a 
Month ago. But I had missed the response mail and resent the patch a week later.
I think you could just drop this patch because it has no different with last one.

Thanks!
Changbin

> 
> thanks,
> 
> greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-06-14  1:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-22  6:50 [PATCH v3] testusb: add path /dev/bus/usb to default search paths of usbfs Du, ChangbinX
2012-05-22 22:42 ` David Rientjes
2012-06-13 23:15 ` gregkh
2012-06-14  1:57   ` Du, ChangbinX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).