* [PATCH] irq: Export symbol no_action() @ 2014-03-01 6:45 Alexander Shiyan 2014-03-04 11:05 ` Thomas Gleixner 0 siblings, 1 reply; 6+ messages in thread From: Alexander Shiyan @ 2014-03-01 6:45 UTC (permalink / raw) To: linux-kernel; +Cc: Thomas Gleixner, Mark Brown, Alexander Shiyan This will allow to use dummy IRQ handler no_action() from drivers compiled as module. For example, dummy handler is could be used for drivers that use ARM FIQ interrupts. Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- kernel/irq/handle.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c index bfec453..e8ddcbf 100644 --- a/kernel/irq/handle.c +++ b/kernel/irq/handle.c @@ -41,6 +41,7 @@ irqreturn_t no_action(int cpl, void *dev_id) { return IRQ_NONE; } +EXPORT_SYMBOL(no_action); static void warn_no_thread(unsigned int irq, struct irqaction *action) { -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] irq: Export symbol no_action() 2014-03-01 6:45 [PATCH] irq: Export symbol no_action() Alexander Shiyan @ 2014-03-04 11:05 ` Thomas Gleixner 2014-03-04 11:15 ` Alexander Shiyan 0 siblings, 1 reply; 6+ messages in thread From: Thomas Gleixner @ 2014-03-04 11:05 UTC (permalink / raw) To: Alexander Shiyan; +Cc: linux-kernel, Mark Brown On Sat, 1 Mar 2014, Alexander Shiyan wrote: > This will allow to use dummy IRQ handler no_action() from > drivers compiled as module. For example, dummy handler is could > be used for drivers that use ARM FIQ interrupts. And why exactly requires a driver which uses ARM FIQ interrupts the no_action implementation? > @@ -41,6 +41,7 @@ irqreturn_t no_action(int cpl, void *dev_id) > { > return IRQ_NONE; > } > +EXPORT_SYMBOL(no_action); EXPORT_SYMBOL_GPL if at all. Thanks, tglx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] irq: Export symbol no_action() 2014-03-04 11:05 ` Thomas Gleixner @ 2014-03-04 11:15 ` Alexander Shiyan 2014-03-04 15:46 ` Thomas Gleixner 0 siblings, 1 reply; 6+ messages in thread From: Alexander Shiyan @ 2014-03-04 11:15 UTC (permalink / raw) To: Thomas Gleixner; +Cc: linux-kernel, Mark Brown [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=utf-8, Size: 921 bytes --] Вторник, 4 марта 2014, 12:05 +01:00 от Thomas Gleixner <tglx@linutronix.de>: > On Sat, 1 Mar 2014, Alexander Shiyan wrote: > > > This will allow to use dummy IRQ handler no_action() from > > drivers compiled as module. For example, dummy handler is could > > be used for drivers that use ARM FIQ interrupts. > > And why exactly requires a driver which uses ARM FIQ interrupts the > no_action implementation? FIQ Interrupt handler is not used in this function. In FIQ case this is just a dummy declaration. Real handler is assigned by using the set_fiq_handler(). > > @@ -41,6 +41,7 @@ irqreturn_t no_action(int cpl, void *dev_id) > > { > > return IRQ_NONE; > > } > > +EXPORT_SYMBOL(no_action); > > EXPORT_SYMBOL_GPL if at all. v2? --- ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] irq: Export symbol no_action() 2014-03-04 11:15 ` Alexander Shiyan @ 2014-03-04 15:46 ` Thomas Gleixner 2014-03-04 17:53 ` Alexander Shiyan 0 siblings, 1 reply; 6+ messages in thread From: Thomas Gleixner @ 2014-03-04 15:46 UTC (permalink / raw) To: Alexander Shiyan; +Cc: linux-kernel, Mark Brown [-- Attachment #1: Type: TEXT/PLAIN, Size: 793 bytes --] On Tue, 4 Mar 2014, Alexander Shiyan wrote: > Вторник, 4 марта 2014, 12:05 +01:00 от Thomas Gleixner <tglx@linutronix.de>: > > On Sat, 1 Mar 2014, Alexander Shiyan wrote: > > > > > This will allow to use dummy IRQ handler no_action() from > > > drivers compiled as module. For example, dummy handler is could > > > be used for drivers that use ARM FIQ interrupts. > > > > And why exactly requires a driver which uses ARM FIQ interrupts the > > no_action implementation? > > FIQ Interrupt handler is not used in this function. In FIQ case this > is just a dummy declaration. Real handler is assigned by using the > set_fiq_handler(). Why do you need a dummy declaration at all? set_fiq_handler() is completely detached from the generic interrupt subsystem. Thanks, tglx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] irq: Export symbol no_action() 2014-03-04 15:46 ` Thomas Gleixner @ 2014-03-04 17:53 ` Alexander Shiyan 2014-03-04 18:56 ` Thomas Gleixner 0 siblings, 1 reply; 6+ messages in thread From: Alexander Shiyan @ 2014-03-04 17:53 UTC (permalink / raw) To: Thomas Gleixner; +Cc: linux-kernel, Mark Brown, Arnd Bergmann [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1720 bytes --] +ÑÑ Arnd Bergmann Вторник, 4 марта 2014, 16:46 +01:00 от Thomas Gleixner <tglx@linutronix.de>: > On Tue, 4 Mar 2014, Alexander Shiyan wrote: > > > Вторник, 4 марта 2014, 12:05 +01:00 от Thomas Gleixner <tglx@linutronix.de>: > > > On Sat, 1 Mar 2014, Alexander Shiyan wrote: > > > > > > > This will allow to use dummy IRQ handler no_action() from > > > > drivers compiled as module. For example, dummy handler is could > > > > be used for drivers that use ARM FIQ interrupts. > > > > > > And why exactly requires a driver which uses ARM FIQ interrupts the > > > no_action implementation? > > > > > FIQ Interrupt handler is not used in this function. In FIQ case this > > is just a dummy declaration. Real handler is assigned by using the > > set_fiq_handler(). > > Why do you need a dummy declaration at all? > > set_fiq_handler() is completely detached from the generic interrupt > subsystem. Some limitations of hardware, such as bit interleaving for normal and FIQ interrupts for mask/status registers, led to the implement single driver for interrupt handling. As a result, all interrupts can be described equally, and single mechanism is used for the request/free and enable/disable. Correct me if I'm wrong. Driver that implements it, resent several times and expect comments within 3 months [1], you are the only one person, Thomas, specified as maintainer for this subsystem. I repeat, if I'm wrong in the implementation, let's fix this. [1]: http://marc.info/?l=linux-arm-kernel&m=139132855024699 Thanks. --- ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] irq: Export symbol no_action() 2014-03-04 17:53 ` Alexander Shiyan @ 2014-03-04 18:56 ` Thomas Gleixner 0 siblings, 0 replies; 6+ messages in thread From: Thomas Gleixner @ 2014-03-04 18:56 UTC (permalink / raw) To: Alexander Shiyan; +Cc: linux-kernel, Mark Brown, Arnd Bergmann [-- Attachment #1: Type: TEXT/PLAIN, Size: 1710 bytes --] On Tue, 4 Mar 2014, Alexander Shiyan wrote: > +сс Arnd Bergmann > > Вторник, 4 марта 2014, 16:46 +01:00 от Thomas Gleixner <tglx@linutronix.de>: > > On Tue, 4 Mar 2014, Alexander Shiyan wrote: > > > > > Вторник, 4 марта 2014, 12:05 +01:00 от Thomas Gleixner <tglx@linutronix.de>: > > > > On Sat, 1 Mar 2014, Alexander Shiyan wrote: > > > > > > > > > This will allow to use dummy IRQ handler no_action() from > > > > > drivers compiled as module. For example, dummy handler is could > > > > > be used for drivers that use ARM FIQ interrupts. > > > > > > > > And why exactly requires a driver which uses ARM FIQ interrupts the > > > > no_action implementation? > > > > > > > > FIQ Interrupt handler is not used in this function. In FIQ case this > > > is just a dummy declaration. Real handler is assigned by using the > > > set_fiq_handler(). > > > > Why do you need a dummy declaration at all? > > > > set_fiq_handler() is completely detached from the generic interrupt > > subsystem. > > Some limitations of hardware, such as bit interleaving for normal and > FIQ interrupts for mask/status registers, led to the implement single > driver for interrupt handling. > As a result, all interrupts can be described equally, and single mechanism > is used for the request/free and enable/disable. > Correct me if I'm wrong. Driver that implements it, resent several times > and expect comments within 3 months [1], you are the only one person, > Thomas, specified as maintainer for this subsystem. > I repeat, if I'm wrong in the implementation, let's fix this. > > [1]: http://marc.info/?l=linux-arm-kernel&m=139132855024699 Lemme find this and review it. Thanks, tglx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-04 18:56 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-03-01 6:45 [PATCH] irq: Export symbol no_action() Alexander Shiyan 2014-03-04 11:05 ` Thomas Gleixner 2014-03-04 11:15 ` Alexander Shiyan 2014-03-04 15:46 ` Thomas Gleixner 2014-03-04 17:53 ` Alexander Shiyan 2014-03-04 18:56 ` Thomas Gleixner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).