* [PATCH 1/2] iio: distance: add dt binding for devantech-srf04
@ 2017-01-28 23:58 Andreas Klinger
2017-01-29 9:19 ` Peter Meerwald-Stadler
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Klinger @ 2017-01-28 23:58 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, gregkh, dledford, akpm,
shraddha.6596, w, balbi, mtk.manpages, sjenning,
ksenija.stanojevic, vilhelm.gray, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree, linux-kernel,
linux-iio
Cc: ak
This patch adds dt binding for devantech ultrasonic ranger srf04.
The vendor "devantech" was already added to the vendor list with
"[PATCH v4 1/3] iio: distance: srf08: add trivial DT binding"
Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
.../bindings/iio/proximity/devantech-srf04.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt
diff --git a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt
new file mode 100644
index 000000000000..4ea29ef3ff89
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt
@@ -0,0 +1,17 @@
+* Devantech SRF04 ultrasonic range finder
+ Bit-banging driver
+
+Required properties:
+ - compatible: Should be "devantech,srf04"
+ - trig-gpios: Definition of the GPIO for the triggering input
+ - echo-gpios: Definition of the GPIO for the echo
+ needs to be an interrupt input
+ See Documentation/devicetree/bindings/gpio/gpio.txt
+
+Example:
+srf04@0 {
+ compatible = "devantech,srf04";
+ trig-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
+ echo-gpios = <&gpio2 6 GPIO_ACTIVE_HIGH>;
+};
+
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] iio: distance: add dt binding for devantech-srf04
2017-01-28 23:58 [PATCH 1/2] iio: distance: add dt binding for devantech-srf04 Andreas Klinger
@ 2017-01-29 9:19 ` Peter Meerwald-Stadler
0 siblings, 0 replies; 2+ messages in thread
From: Peter Meerwald-Stadler @ 2017-01-29 9:19 UTC (permalink / raw)
To: Andreas Klinger; +Cc: jic23, devicetree, linux-kernel, linux-iio
On Sun, 29 Jan 2017, Andreas Klinger wrote:
> This patch adds dt binding for devantech ultrasonic ranger srf04.
comments below
> The vendor "devantech" was already added to the vendor list with
> "[PATCH v4 1/3] iio: distance: srf08: add trivial DT binding"
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> .../bindings/iio/proximity/devantech-srf04.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt
> new file mode 100644
> index 000000000000..4ea29ef3ff89
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt
> @@ -0,0 +1,17 @@
> +* Devantech SRF04 ultrasonic range finder
> + Bit-banging driver
> +
> +Required properties:
> + - compatible: Should be "devantech,srf04"
> + - trig-gpios: Definition of the GPIO for the triggering input
> + - echo-gpios: Definition of the GPIO for the echo
"for the echo"
maybe some more explanation? it sounds somewhat incomplete to me
in the driver you have "failed to get echo-gpiod", maybe it should be gpios there?
> + needs to be an interrupt input
> + See Documentation/devicetree/bindings/gpio/gpio.txt
> +
> +Example:
> +srf04@0 {
> + compatible = "devantech,srf04";
> + trig-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
> + echo-gpios = <&gpio2 6 GPIO_ACTIVE_HIGH>;
> +};
> +
>
--
Peter Meerwald-Stadler
+43-664-2444418 (mobile)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-29 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-28 23:58 [PATCH 1/2] iio: distance: add dt binding for devantech-srf04 Andreas Klinger
2017-01-29 9:19 ` Peter Meerwald-Stadler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).