From: Thomas Gleixner <tglx@linutronix.de>
To: Eric Sesterhenn <eric.sesterhenn@lsexperts.de>
Cc: Conrad Kostecki <ck@conrad-kostecki.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>
Subject: Re: AW: AW: AW: [PATCH] x86: HPET force enable for Soekris net6501
Date: Tue, 9 Sep 2014 16:54:39 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1409091649510.11037@nanos> (raw)
In-Reply-To: <540F06F1.1040608@lsexperts.de>
On Tue, 9 Sep 2014, Eric Sesterhenn wrote:
> On 02/14/2014 07:28 PM, Conrad Kostecki wrote:
> This patch enables a quirk for the Soekris net6501 HPET if
> pciquirks=soekris_e6xx" is supplied at the kernel commandline,
> Without these patches the clocksource defaults to jiffies, which
> is unstable.
>
> Signed-off-by: Eric Sesterhenn <eric.sesterhenn@lsexperts.de>
>
> diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
> index ff898bb..7c3faf5 100644
> --- a/arch/x86/kernel/quirks.c
> +++ b/arch/x86/kernel/quirks.c
> @@ -6,6 +6,25 @@
>
> #include <asm/hpet.h>
>
> +static int pciquirk_soekris;
> +
> +static int __init parse_pciquirks(char *str)
> +{
> +
> + while (str) {
> + char *next = strchr(str, ',');
> +
> + if (next)
> + *next++ = 0;
> + if (!strncmp("soekris_e6xx", str, 12))
> + pciquirk_soekris = 1;
> + str = next;
> + }
> + return 1;
> +}
> +__setup("pciquirks=", parse_pciquirks);
Eew. No, we really can do without random new quirk interfaces.
> #if defined(CONFIG_X86_IO_APIC) && defined(CONFIG_SMP) && defined(CONFIG_PCI)
>
> static void quirk_intel_irqbalance(struct pci_dev *dev)
> @@ -498,6 +517,28 @@ void force_hpet_resume(void)
> }
>
> /*
> + * Soekris net6501, based on Atom E6xx series, does not have ACPI.
> + * HPET should be force enabled on such platforms.
> + */
> +static void e6xx_force_enable_hpet(struct pci_dev *dev)
> +{
> + if (hpet_address || force_hpet_address)
> + return;
> +
> + if (pciquirk_soekris != 1)
> + return;
Thinking more about it, this is really not necessary.
@hpa: You asked whether this might affect any other e6xx devices.
According to the atom e6xx-series datasheet the HPET is non optional
and always memory mapped to 0xfed00000. I don't see how that would
harm any machine which has the hpet proper advertised via ACPI.
Thanks,
tglx
> +
> + force_hpet_address = 0xFED00000;
> + force_hpet_resume_type = NONE_FORCE_HPET_RESUME;
> + dev_printk(KERN_DEBUG, &dev->dev, "Force enabled HPET at "
> + "0x%lx\n", force_hpet_address);
> + return;
> +}
> +
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_E6XX_CU,
> + e6xx_force_enable_hpet);
next prev parent reply other threads:[~2014-09-09 14:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 10:23 [PATCH] x86: HPET force enable for Soekris net6501 Conrad Kostecki
2014-02-14 17:46 ` H. Peter Anvin
2014-02-14 18:06 ` AW: " Conrad Kostecki
2014-02-14 18:08 ` H. Peter Anvin
2014-02-14 18:13 ` AW: " Conrad Kostecki
2014-02-14 18:16 ` H. Peter Anvin
2014-02-14 18:21 ` Thomas Gleixner
2014-02-14 18:22 ` H. Peter Anvin
2014-02-14 18:38 ` Thomas Gleixner
2014-02-14 18:39 ` H. Peter Anvin
2014-02-14 19:15 ` Thomas Gleixner
2014-02-14 19:26 ` H. Peter Anvin
2014-02-14 19:59 ` Thomas Gleixner
2014-02-14 20:06 ` H. Peter Anvin
2014-02-14 21:16 ` Thomas Gleixner
2014-02-14 21:18 ` H. Peter Anvin
2014-02-14 21:47 ` Thomas Gleixner
2014-02-14 21:48 ` H. Peter Anvin
2014-02-17 16:28 ` Thomas Renninger
2014-02-17 17:19 ` H. Peter Anvin
2014-02-17 18:23 ` Thomas Renninger
2014-02-17 18:47 ` H. Peter Anvin
2014-02-17 19:25 ` Thomas Renninger
2014-02-17 19:40 ` H. Peter Anvin
2014-02-18 18:22 ` ACPI: Also allow ACPI table adding via initrd not only overriding Thomas Renninger
2014-02-18 18:22 ` [PATCH 1/4] ACPI: Provide support for ACPI table adding via OS Thomas Renninger
2014-02-18 18:27 ` H. Peter Anvin
2014-02-18 18:44 ` Thomas Renninger
2014-02-18 20:51 ` H. Peter Anvin
2014-02-19 11:22 ` Thomas Renninger
2014-02-21 7:24 ` [Devel] " Zheng, Lv
2014-02-21 7:28 ` Zheng, Lv
2014-02-18 18:22 ` [PATCH 2/4] ACPICA: Introduce new acpi_os_physical_table_add OS callback Thomas Renninger
2014-02-18 18:22 ` [PATCH 3/4] ACPICA: Add BGRT signature to known signatures Thomas Renninger
2014-02-18 18:22 ` [PATCH 4/4] ACPI: Add new table signatures that can be overridden/added Thomas Renninger
2014-02-18 18:38 ` [Devel] ACPI: Also allow ACPI table adding via initrd not only overriding Moore, Robert
2014-02-18 18:52 ` Thomas Renninger
2014-02-18 19:59 ` Moore, Robert
2014-02-19 11:14 ` Thomas Renninger
2014-02-19 13:03 ` Thomas Gleixner
2014-02-14 18:28 ` AW: AW: AW: [PATCH] x86: HPET force enable for Soekris net6501 Conrad Kostecki
2014-09-09 13:56 ` Eric Sesterhenn
2014-09-09 14:54 ` Thomas Gleixner [this message]
2014-09-09 15:26 ` H. Peter Anvin
2014-09-09 15:41 ` Thomas Gleixner
2014-09-12 9:41 ` Eric Sesterhenn
2014-09-12 10:37 ` Thomas Gleixner
2014-09-12 11:06 ` [PATCH] x86: HPET force enable for e6xx based systems Eric Sesterhenn
2014-09-16 0:58 ` [tip:x86/platform] " tip-bot for Peter Neubauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1409091649510.11037@nanos \
--to=tglx@linutronix.de \
--cc=ck@conrad-kostecki.de \
--cc=eric.sesterhenn@lsexperts.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).