From: Thomas Gleixner <tglx@linutronix.de>
To: Eric Sesterhenn <eric.sesterhenn@lsexperts.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Conrad Kostecki <ck@conrad-kostecki.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Peter Neubauer <pneubauer@bluerwhite.org>
Subject: Re: [PATCH] x86: HPET force enable for Soekris net6501
Date: Fri, 12 Sep 2014 12:37:53 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1409121221580.4178@nanos> (raw)
In-Reply-To: <5412BFAF.7050900@lsexperts.de>
On Fri, 12 Sep 2014, Eric Sesterhenn wrote:
> On 09/09/2014 05:26 PM, H. Peter Anvin wrote:
> > On 09/09/2014 07:54 AM, Thomas Gleixner wrote:
> >>
> >> @hpa: You asked whether this might affect any other e6xx devices.
> >>
> >> According to the atom e6xx-series datasheet the HPET is non optional
> >> and always memory mapped to 0xfed00000. I don't see how that would
> >> harm any machine which has the hpet proper advertised via ACPI.
> >>
> >
> > That seems straightforward then.
>
> this means the original patch written by Conrad is going to be applied?
> Is there anything we can do to help regarding this issue?
Yes, it needs some massaging.
> Subject: [PATCH] x86: HPET force enable for Soekris net6501
This change is not soekris specific. It enables the force mechanism
for all e6xx based systems.
> Original patch by Peter Neubauer, slightly modified by me.
> -> http://www.mail-archive.com/soekris-tech@lists.soekris.com/msg06462.html
> Signed-off-by: Peter Neubauer <pneubauer@bluerwhite.org>
I can't see a SOB from Peter in his post on the soekris list, but he's
clearly the original author. So the patch is missing a From: .... line
at the top of the mail body.
> Signed-off-by: Conrad Kostecki <ck@conrad-kostecki.de>
--- a/arch/x86/kernel/quirks.c 2014-02-14 11:13:27.703432732 +0100
+++ b/arch/x86/kernel/quirks.c 2014-02-14 11:14:32.327496474 +0100
@@ -498,6 +498,25 @@ void force_hpet_resume(void)
}
> /*
> + * Soekris net6501, based on Atom E6xx series, does not have ACPI.
> + * HPET should be force enabled on such platforms.
> + */
Again this is not soekris specific. We rather want an explanation WHY
it is safe to do so, e.g. something like:
/*
* According to datasheet e6xx systems have the HPET hardwired to
* 0xfed00000
*/
That's the information we need and which avoids questions about the
correctness of the approach. Its clear that ACPI did not populate HPET
if hpet_address is 0.
> +static void e6xx_force_enable_hpet(struct pci_dev *dev)
> +{
> + if (hpet_address || force_hpet_address)
> + return;
> +
> + force_hpet_address = 0xFED00000;
> + force_hpet_resume_type = NONE_FORCE_HPET_RESUME;
> + dev_printk(KERN_DEBUG, &dev->dev, "Force enabled HPET at "
> + "0x%lx\n", force_hpet_address);
> + return;
> +}
> +
Remove the new line please.
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_E6XX_CU,
> + e6xx_force_enable_hpet);
Thanks,
tglx
next prev parent reply other threads:[~2014-09-12 10:38 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 10:23 [PATCH] x86: HPET force enable for Soekris net6501 Conrad Kostecki
2014-02-14 17:46 ` H. Peter Anvin
2014-02-14 18:06 ` AW: " Conrad Kostecki
2014-02-14 18:08 ` H. Peter Anvin
2014-02-14 18:13 ` AW: " Conrad Kostecki
2014-02-14 18:16 ` H. Peter Anvin
2014-02-14 18:21 ` Thomas Gleixner
2014-02-14 18:22 ` H. Peter Anvin
2014-02-14 18:38 ` Thomas Gleixner
2014-02-14 18:39 ` H. Peter Anvin
2014-02-14 19:15 ` Thomas Gleixner
2014-02-14 19:26 ` H. Peter Anvin
2014-02-14 19:59 ` Thomas Gleixner
2014-02-14 20:06 ` H. Peter Anvin
2014-02-14 21:16 ` Thomas Gleixner
2014-02-14 21:18 ` H. Peter Anvin
2014-02-14 21:47 ` Thomas Gleixner
2014-02-14 21:48 ` H. Peter Anvin
2014-02-17 16:28 ` Thomas Renninger
2014-02-17 17:19 ` H. Peter Anvin
2014-02-17 18:23 ` Thomas Renninger
2014-02-17 18:47 ` H. Peter Anvin
2014-02-17 19:25 ` Thomas Renninger
2014-02-17 19:40 ` H. Peter Anvin
2014-02-18 18:22 ` ACPI: Also allow ACPI table adding via initrd not only overriding Thomas Renninger
2014-02-18 18:22 ` [PATCH 1/4] ACPI: Provide support for ACPI table adding via OS Thomas Renninger
2014-02-18 18:27 ` H. Peter Anvin
2014-02-18 18:44 ` Thomas Renninger
2014-02-18 20:51 ` H. Peter Anvin
2014-02-19 11:22 ` Thomas Renninger
2014-02-21 7:24 ` [Devel] " Zheng, Lv
2014-02-21 7:28 ` Zheng, Lv
2014-02-18 18:22 ` [PATCH 2/4] ACPICA: Introduce new acpi_os_physical_table_add OS callback Thomas Renninger
2014-02-18 18:22 ` [PATCH 3/4] ACPICA: Add BGRT signature to known signatures Thomas Renninger
2014-02-18 18:22 ` [PATCH 4/4] ACPI: Add new table signatures that can be overridden/added Thomas Renninger
2014-02-18 18:38 ` [Devel] ACPI: Also allow ACPI table adding via initrd not only overriding Moore, Robert
2014-02-18 18:52 ` Thomas Renninger
2014-02-18 19:59 ` Moore, Robert
2014-02-19 11:14 ` Thomas Renninger
2014-02-19 13:03 ` Thomas Gleixner
2014-02-14 18:28 ` AW: AW: AW: [PATCH] x86: HPET force enable for Soekris net6501 Conrad Kostecki
2014-09-09 13:56 ` Eric Sesterhenn
2014-09-09 14:54 ` Thomas Gleixner
2014-09-09 15:26 ` H. Peter Anvin
2014-09-09 15:41 ` Thomas Gleixner
2014-09-12 9:41 ` Eric Sesterhenn
2014-09-12 10:37 ` Thomas Gleixner [this message]
2014-09-12 11:06 ` [PATCH] x86: HPET force enable for e6xx based systems Eric Sesterhenn
2014-09-16 0:58 ` [tip:x86/platform] " tip-bot for Peter Neubauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1409121221580.4178@nanos \
--to=tglx@linutronix.de \
--cc=ck@conrad-kostecki.de \
--cc=eric.sesterhenn@lsexperts.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pneubauer@bluerwhite.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).