[PATCH] slub: fix confusing error messages in check_slab

* [PATCH] slub: fix confusing error messages in check_slab
@ 2014-11-24 15:06 Min-Hua Chen
  2014-11-24 17:17 ` Christoph Lameter
  0 siblings, 1 reply; 4+ messages in thread
From: Min-Hua Chen @ 2014-11-24 15:06 UTC (permalink / raw)
  To: Christoph Lameter, Pekka Enberg, David Rientjes, Joonsoo Kim,
	Andrew Morton
  Cc: linux-kernel, linux-mm

In check_slab, s->name is passed incorrectly to the error
messages. It will cause confusing error messages if the object
check fails. This patch fix this bug by removing s->name.

Signed-off-by: Min-Hua Chen <orca.chen@gmail.com>
---
 mm/slub.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index ae7b9f1..5da9f9f 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -849,12 +849,12 @@ static int check_slab(struct kmem_cache *s,
struct page *page)
     maxobj = order_objects(compound_order(page), s->size, s->reserved);
     if (page->objects > maxobj) {
         slab_err(s, page, "objects %u > max %u",
-            s->name, page->objects, maxobj);
+             page->objects, maxobj);
         return 0;
     }
     if (page->inuse > page->objects) {
         slab_err(s, page, "inuse %u > max %u",
-            s->name, page->inuse, page->objects);
+             page->inuse, page->objects);
         return 0;
     }
     /* Slab_pad_check fixes things up after itself */
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread