From: Vikas Shivappa <vikas.shivappa@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>,
linux-kernel@vger.kernel.org, vikas.shivappa@intel.com,
x86@kernel.org, hpa@zytor.com, mingo@kernel.org, tj@kernel.org,
peterz@infradead.org, matt.fleming@intel.com,
will.auld@intel.com, kanaka.d.juvva@intel.com
Subject: Re: [PATCH 08/10] x86/intel_rdt: Implement scheduling support for Intel RDT
Date: Mon, 8 Jun 2015 09:20:12 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1506080919280.30856@vshiva-Udesk> (raw)
In-Reply-To: <alpine.DEB.2.11.1506081636140.4133@nanos>
On Mon, 8 Jun 2015, Thomas Gleixner wrote:
> On Sat, 6 Jun 2015, Thomas Gleixner wrote:
>
>> On Thu, 4 Jun 2015, Vikas Shivappa wrote:
>>> +static inline void intel_rdt_sched_in(void)
>>> +{
>>> + if (static_key_false(&rdt_enable_key))
>>> + __intel_rdt_sched_in();
>>
>> So if the enable_key is FALSE we call the RDT stuff? I might be
>> missing something important, but this does not make any sense and I
>> have to ask how that whole stuff has been tested.
>
> Bah. That static key API is really designed for maximal confusion. The
> above is correct, but a comment might not be the worst thing.
Ah yes, - its also tested with debug prints. Will add comment.
Thanks,
Vikas
>
> Thanks,
>
> tglx
>
next prev parent reply other threads:[~2015-06-08 16:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 0:01 [PATCH V8 00/10] New cpumask API and Intel Cache Allocation support Vikas Shivappa
2015-06-05 0:01 ` [PATCH 01/10] cpumask: Introduce cpumask_any_online_but Vikas Shivappa
2015-06-05 0:01 ` [PATCH 02/10] x86/intel_cqm: Modify hot cpu notification handling Vikas Shivappa
2015-06-05 0:01 ` [PATCH 03/10] x86/intel_rapl: Modify hot cpu notification handling for RAPL Vikas Shivappa
2015-06-06 0:43 ` Vikas Shivappa
2015-06-05 0:01 ` [PATCH 04/10] x86/intel_rdt: Cache Allocation documentation and cgroup usage guide Vikas Shivappa
2015-06-05 0:01 ` [PATCH 05/10] x86/intel_rdt: Add support for Cache Allocation detection Vikas Shivappa
2015-06-05 0:01 ` [PATCH 06/10] x86/intel_rdt: Add new cgroup and Class of service management Vikas Shivappa
2015-06-05 0:01 ` [PATCH 07/10] x86/intel_rdt: Add support for cache bit mask management Vikas Shivappa
2015-06-05 0:01 ` [PATCH 08/10] x86/intel_rdt: Implement scheduling support for Intel RDT Vikas Shivappa
2015-06-06 9:43 ` Thomas Gleixner
2015-06-08 14:37 ` Thomas Gleixner
2015-06-08 16:20 ` Vikas Shivappa [this message]
2015-06-08 16:30 ` Vikas Shivappa
2015-06-10 23:38 ` Vikas Shivappa
2015-06-05 0:01 ` [PATCH 09/10] x86/intel_rdt: Hot cpu support for Cache Allocation Vikas Shivappa
2015-06-05 0:01 ` [PATCH 10/10] x86/intel_rdt: Intel haswell Cache Allocation enumeration Vikas Shivappa
-- strict thread matches above, loose matches on Subject: below --
2015-06-23 22:56 [PATCH V10 00/10] New cpumask API and Intel Cache Allocation support Vikas Shivappa
2015-06-23 22:56 ` [PATCH 08/10] x86/intel_rdt: Implement scheduling support for Intel RDT Vikas Shivappa
2015-06-12 18:17 [PATCH V9 00/10] New cpumask API and Intel Cache Allocation support Vikas Shivappa
2015-06-12 18:17 ` [PATCH 08/10] x86/intel_rdt: Implement scheduling support for Intel RDT Vikas Shivappa
2015-06-03 19:09 [PATCH V8 00/10] New cpumask API and Intel Cache Allocation support Vikas Shivappa
2015-06-03 19:09 ` [PATCH 08/10] x86/intel_rdt: Implement scheduling support for Intel RDT Vikas Shivappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1506080919280.30856@vshiva-Udesk \
--to=vikas.shivappa@intel.com \
--cc=hpa@zytor.com \
--cc=kanaka.d.juvva@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vikas.shivappa@linux.intel.com \
--cc=will.auld@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).