linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] mm/slub: allow merging when SLAB_DEBUG_FREE is set
@ 2015-07-20 15:29 Konstantin Khlebnikov
  2015-07-20 15:37 ` Christoph Lameter
  2015-07-21 22:31 ` David Rientjes
  0 siblings, 2 replies; 3+ messages in thread
From: Konstantin Khlebnikov @ 2015-07-20 15:29 UTC (permalink / raw)
  To: linux-mm, Christoph Lameter; +Cc: Andrew Morton, linux-kernel

This patch fixes creation of new kmem-caches after enabling sanity_checks
for existing mergeable kmem-caches in runtime: before that patch creation
fails because unique name in sysfs already taken by existing kmem-cache.

Unlike to other debug options this doesn't change object layout and could
be enabled and disabled at any time.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
---
 mm/slab_common.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/slab_common.c b/mm/slab_common.c
index 3e5f8f29c286..86831105a09f 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -37,8 +37,7 @@ struct kmem_cache *kmem_cache;
 		SLAB_TRACE | SLAB_DESTROY_BY_RCU | SLAB_NOLEAKTRACE | \
 		SLAB_FAILSLAB)
 
-#define SLAB_MERGE_SAME (SLAB_DEBUG_FREE | SLAB_RECLAIM_ACCOUNT | \
-		SLAB_CACHE_DMA | SLAB_NOTRACK)
+#define SLAB_MERGE_SAME (SLAB_RECLAIM_ACCOUNT | SLAB_CACHE_DMA | SLAB_NOTRACK)
 
 /*
  * Merge control. If this is set then no merging of slab caches will occur.


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] mm/slub: allow merging when SLAB_DEBUG_FREE is set
  2015-07-20 15:29 [PATCH v2] mm/slub: allow merging when SLAB_DEBUG_FREE is set Konstantin Khlebnikov
@ 2015-07-20 15:37 ` Christoph Lameter
  2015-07-21 22:31 ` David Rientjes
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Lameter @ 2015-07-20 15:37 UTC (permalink / raw)
  To: Konstantin Khlebnikov; +Cc: linux-mm, Andrew Morton, linux-kernel

On Mon, 20 Jul 2015, Konstantin Khlebnikov wrote:

> This patch fixes creation of new kmem-caches after enabling sanity_checks
> for existing mergeable kmem-caches in runtime: before that patch creation
> fails because unique name in sysfs already taken by existing kmem-cache.
>
> Unlike to other debug options this doesn't change object layout and could
> be enabled and disabled at any time.

Acked-by: Christoph Lameter <cl@linux.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] mm/slub: allow merging when SLAB_DEBUG_FREE is set
  2015-07-20 15:29 [PATCH v2] mm/slub: allow merging when SLAB_DEBUG_FREE is set Konstantin Khlebnikov
  2015-07-20 15:37 ` Christoph Lameter
@ 2015-07-21 22:31 ` David Rientjes
  1 sibling, 0 replies; 3+ messages in thread
From: David Rientjes @ 2015-07-21 22:31 UTC (permalink / raw)
  To: Konstantin Khlebnikov
  Cc: linux-mm, Christoph Lameter, Andrew Morton, linux-kernel

On Mon, 20 Jul 2015, Konstantin Khlebnikov wrote:

> This patch fixes creation of new kmem-caches after enabling sanity_checks
> for existing mergeable kmem-caches in runtime: before that patch creation
> fails because unique name in sysfs already taken by existing kmem-cache.
> 
> Unlike to other debug options this doesn't change object layout and could
> be enabled and disabled at any time.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>

Acked-by: David Rientjes <rientjes@google.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-21 22:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-20 15:29 [PATCH v2] mm/slub: allow merging when SLAB_DEBUG_FREE is set Konstantin Khlebnikov
2015-07-20 15:37 ` Christoph Lameter
2015-07-21 22:31 ` David Rientjes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).