From: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Vishwanath Pai <vpai@akamai.com>, Joshua Hunt <johunt@akamai.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] netfilter: ipset: use setup_timer() and mod_timer().
Date: Fri, 20 May 2016 22:40:47 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1605202238420.16031@blackhole.kfki.hu> (raw)
In-Reply-To: <1463173145-16167-1-git-send-email-falakreyaz@gmail.com>
On Sat, 14 May 2016, Muhammad Falak R Wani wrote:
> Use setup_timer() and instead of init_timer(), being the preferred way
> of setting up a timer.
>
> Also, quoting the mod_timer() function comment:
> -> mod_timer() is a more efficient way to update the expire field of an
> active timer (if the timer is inactive it will be activated).
>
> Use setup_timer() and mod_timer() to setup and arm a timer, making the
> code compact and easier to read.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> net/netfilter/ipset/ip_set_bitmap_gen.h | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
The patch and the other too in the series as well are applied in the ipset
git repository and will be submitted for kernel inclusion. Thanks.
Best regards,
Jozsef
-
E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
H-1525 Budapest 114, POB. 49, Hungary
prev parent reply other threads:[~2016-05-20 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 20:58 [PATCH 1/3] netfilter: ipset: use setup_timer() and mod_timer() Muhammad Falak R Wani
2016-05-13 20:58 ` [PATCH 2/3] " Muhammad Falak R Wani
2016-05-13 20:58 ` [PATCH 3/3] " Muhammad Falak R Wani
2016-05-20 20:40 ` Jozsef Kadlecsik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1605202238420.16031@blackhole.kfki.hu \
--to=kadlec@blackhole.kfki.hu \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=falakreyaz@gmail.com \
--cc=johunt@akamai.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=vpai@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).