* [PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets
@ 2016-06-08 5:55 Shrikrishna Khare
2016-06-08 5:59 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Shrikrishna Khare @ 2016-06-08 5:55 UTC (permalink / raw)
To: netdev, linux-kernel, pv-drivers; +Cc: Shrikrishna Khare, Jin Heo
The device emulation may send segCnt of 1 for LRO packets.
Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
Signed-off-by: Jin Heo <heoj@vmware.com>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
drivers/net/vmxnet3/vmxnet3_int.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index db8022a..6f399b2 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1369,7 +1369,7 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,
rcdlro = (struct Vmxnet3_RxCompDescExt *)rcd;
segCnt = rcdlro->segCnt;
- BUG_ON(segCnt <= 1);
+ BUG_ON(segCnt == 0);
mss = rcdlro->mss;
if (unlikely(segCnt <= 1))
segCnt = 0;
diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h
index c482539..3d2b64e 100644
--- a/drivers/net/vmxnet3/vmxnet3_int.h
+++ b/drivers/net/vmxnet3/vmxnet3_int.h
@@ -69,10 +69,10 @@
/*
* Version numbers
*/
-#define VMXNET3_DRIVER_VERSION_STRING "1.4.7.0-k"
+#define VMXNET3_DRIVER_VERSION_STRING "1.4.8.0-k"
/* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */
-#define VMXNET3_DRIVER_VERSION_NUM 0x01040700
+#define VMXNET3_DRIVER_VERSION_NUM 0x01040800
#if defined(CONFIG_PCI_MSI)
/* RSS only makes sense if MSI-X is supported. */
--
2.8.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets
2016-06-08 5:55 [PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets Shrikrishna Khare
@ 2016-06-08 5:59 ` David Miller
2016-06-08 6:16 ` Shrikrishna Khare
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2016-06-08 5:59 UTC (permalink / raw)
To: skhare; +Cc: netdev, linux-kernel, pv-drivers, heoj
From: Shrikrishna Khare <skhare@vmware.com>
Date: Tue, 7 Jun 2016 22:55:17 -0700
> The device emulation may send segCnt of 1 for LRO packets.
>
> Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
> Signed-off-by: Jin Heo <heoj@vmware.com>
Please do not capitalize subsystem prefixes in your Subject line,
and "Driver: " is so generic that it's pointless to use it as a
part of the subsystem prefix. Plain "vmxnet3: " is sufficient.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets
2016-06-08 5:59 ` David Miller
@ 2016-06-08 6:16 ` Shrikrishna Khare
0 siblings, 0 replies; 3+ messages in thread
From: Shrikrishna Khare @ 2016-06-08 6:16 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel, pv-drivers, heoj
On Tue, 7 Jun 2016, David Miller wrote:
> From: Shrikrishna Khare <skhare@vmware.com>
> Date: Tue, 7 Jun 2016 22:55:17 -0700
>
> > The device emulation may send segCnt of 1 for LRO packets.
> >
> > Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
> > Signed-off-by: Jin Heo <heoj@vmware.com>
>
> Please do not capitalize subsystem prefixes in your Subject line,
> and "Driver: " is so generic that it's pointless to use it as a
> part of the subsystem prefix. Plain "vmxnet3: " is sufficient.
>
Ok. Sent v2 of the patch with the subject line fixed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-08 6:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-08 5:55 [PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets Shrikrishna Khare
2016-06-08 5:59 ` David Miller
2016-06-08 6:16 ` Shrikrishna Khare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).