From: Julia Lawall <julia.lawall@lip6.fr>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, mmarek@suse.com,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, markivx@codeaurora.org,
stephen.boyd@linaro.org, zohar@linux.vnet.ibm.com,
broonie@kernel.org, ming.lei@canonical.com, tiwai@suse.de,
johannes@sipsolutions.net, chunkeey@googlemail.com,
hauke@hauke-m.de, jwboyer@fedoraproject.org,
dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com,
torvalds@linux-foundation.org, cocci@systeme.lip6.fr
Subject: Re: [PATCH v2 3/8] coccicheck: add indexing enhancement options
Date: Fri, 17 Jun 2016 17:29:49 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1606171729370.3164@hadrien> (raw)
In-Reply-To: <20160617151229.GO11948@wotan.suse.de>
On Fri, 17 Jun 2016, Luis R. Rodriguez wrote:
> On Fri, Jun 17, 2016 at 11:47:25AM +0200, Julia Lawall wrote:
> >
> >
> > On Thu, 16 Jun 2016, Luis R. Rodriguez wrote:
> >
> > > Coccinelle has support to make use of its own enhanced "grep"
> > > mechanisms instead of using regular grep for searching code,
> > > it calls this 'coccigrep'. In lack of any indexing optimization
> > > information it uses --use-coccigrep by default.
> > >
> > > This patch enable indexing optimizations heuristics so that coccigrep
> > > can automatically detect what indexing options are available and use
> > > them accordinly without any user input.
> > >
> > > Since git has its own index, support for using 'git grep' has been
> > > added to Coccinelle, that should on average perform better than
> > > using the internal coccigrep. Coccinelle has had idutils support
> > > as well for a while now, you however need to refer to the index
> > > file. We support detecting two idutils index files by default,
> > > ID and .id-utils.index, assuming you ran either of:
> > >
> > > # What you might have done:
> > > mkid -s
> > > # as in coccinelle scripts/idutils_index.sh
> > > mkid -i C --output .id-utils.index *
> > >
> > > Lastly, Coccinelle has had support for glimpseindex for a long while,
> > > however the glimpseindex tool, the agrep library were previously closed
> > > source, its all now open sourced, and provides the best performance, so
> > > support that if we can detect you have a glimpse index.
> > >
> > > You can always override the index as follows:
> > >
> > > $ make coccicheck V=1 MODE=report COCCI_INDEX="--use-idutils ID"
> >
> > Why not just have a generic COCCI_ARGS argument?
>
> Actually SPFLAGS exists already so we can just document to
> override using that. Will fix.
That seems like a good solution.
julia
next prev parent reply other threads:[~2016-06-17 15:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 22:31 [PATCH v2 0/8] coccicheck: modernize Luis R. Rodriguez
2016-06-16 22:31 ` [PATCH v2 1/8] coccicheck: move spatch binary check up Luis R. Rodriguez
2016-06-16 22:31 ` [PATCH v2 2/8] coccicheck: enable parmap support Luis R. Rodriguez
2016-06-16 22:31 ` [PATCH v2 3/8] coccicheck: add indexing enhancement options Luis R. Rodriguez
2016-06-17 9:47 ` Julia Lawall
2016-06-17 15:12 ` Luis R. Rodriguez
2016-06-17 15:29 ` Julia Lawall [this message]
2016-06-16 22:31 ` [PATCH v2 4/8] scripts: add glimpse.sh for indexing the kernel Luis R. Rodriguez
2016-06-17 9:44 ` Julia Lawall
2016-06-17 15:10 ` Luis R. Rodriguez
2016-06-17 15:35 ` Julia Lawall
2016-06-18 1:22 ` Luis R. Rodriguez
2016-06-18 5:51 ` Julia Lawall
2016-06-20 19:18 ` Luis R. Rodriguez
2016-06-18 10:37 ` Julia Lawall
2016-06-18 10:38 ` Julia Lawall
2016-06-17 15:18 ` [Cocci] " SF Markus Elfring
2016-06-17 16:11 ` Julia Lawall
2016-06-16 22:31 ` [PATCH v2 5/8] coccicheck: replace --very-quiet with --quit when debugging Luis R. Rodriguez
2016-06-16 22:31 ` [PATCH v2 6/8] coccicheck: add support for requring a coccinelle version Luis R. Rodriguez
2016-06-16 22:31 ` [PATCH v2 7/8] coccicheck: refer to coccicheck bottest wiki for documentation Luis R. Rodriguez
2016-06-16 22:31 ` [PATCH v2 8/8] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1606171729370.3164@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=chunkeey@googlemail.com \
--cc=cocci@systeme.lip6.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hauke@hauke-m.de \
--cc=johannes@sipsolutions.net \
--cc=jslaby@suse.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markivx@codeaurora.org \
--cc=mcgrof@kernel.org \
--cc=ming.lei@canonical.com \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
--cc=stephen.boyd@linaro.org \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).