* [PATCH] i2c: fix device_node_continue.cocci warnings
@ 2016-09-19 9:47 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2016-09-19 9:47 UTC (permalink / raw)
To: Joel Stanley
Cc: kbuild-all, Jeremy Kerr, Milton Miller, Wolfram Sang, linux-i2c,
linux-kernel
Device node iterators put the previous value of the index variable, so an
explicit put causes a double put.
Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
Please take the patch only if it's a positive warning. Thanks!
I haven't checked anything more that what is shown in the patch.
julia
i2c-aspeed.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -862,7 +862,6 @@ static int ast_i2c_probe_controller(stru
continue;
of_platform_device_create(np, bus_id, &pdev->dev);
- of_node_put(np);
}
return 0;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-09-19 9:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-19 9:47 [PATCH] i2c: fix device_node_continue.cocci warnings Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).