[PATCH] xen/9pfs: select CONFIG_XEN_XENBUS_FRONTEND

[PATCH] xen/9pfs: select CONFIG_XEN_XENBUS_FRONTEND

[Arnd Bergmann]

All Xen frontends need to select this symbol to avoid a link error:

net/built-in.o: In function `p9_trans_xen_init':
:(.text+0x149e9c): undefined reference to `__xenbus_register_frontend'

Fixes: d4b40a02f837 ("xen/9pfs: build 9pfs Xen transport driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 net/9p/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/9p/Kconfig b/net/9p/Kconfig
index 3f286f1bd1d3..e6014e0e51f7 100644
--- a/net/9p/Kconfig
+++ b/net/9p/Kconfig
@@ -24,6 +24,7 @@ config NET_9P_VIRTIO
 
 config NET_9P_XEN
 	depends on XEN
+	select XEN_XENBUS_FRONTEND
 	tristate "9P Xen Transport"
 	help
 	  This builds support for a transport for 9pfs between
-- 
2.9.0

Re: [PATCH] xen/9pfs: select CONFIG_XEN_XENBUS_FRONTEND

[Stefano Stabellini]

On Wed, 19 Apr 2017, Arnd Bergmann wrote:
> All Xen frontends need to select this symbol to avoid a link error:
> 
> net/built-in.o: In function `p9_trans_xen_init':
> :(.text+0x149e9c): undefined reference to `__xenbus_register_frontend'
> 
> Fixes: d4b40a02f837 ("xen/9pfs: build 9pfs Xen transport driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thank you for the fix!

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  net/9p/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/9p/Kconfig b/net/9p/Kconfig
> index 3f286f1bd1d3..e6014e0e51f7 100644
> --- a/net/9p/Kconfig
> +++ b/net/9p/Kconfig
> @@ -24,6 +24,7 @@ config NET_9P_VIRTIO
>  
>  config NET_9P_XEN
>  	depends on XEN
> +	select XEN_XENBUS_FRONTEND
>  	tristate "9P Xen Transport"
>  	help
>  	  This builds support for a transport for 9pfs between
> -- 
> 2.9.0
> 

Re: [PATCH] xen/9pfs: select CONFIG_XEN_XENBUS_FRONTEND

[Stefano Stabellini]

Juergen, I have committed this patch to for-linus-4.12 and linux-next, I
hope that's OK.

Og Wed, 19 Apr 2017, Stefano Stabellini wrote:
> On Wed, 19 Apr 2017, Arnd Bergmann wrote:
> > All Xen frontends need to select this symbol to avoid a link error:
> > 
> > net/built-in.o: In function `p9_trans_xen_init':
> > :(.text+0x149e9c): undefined reference to `__xenbus_register_frontend'
> > 
> > Fixes: d4b40a02f837 ("xen/9pfs: build 9pfs Xen transport driver")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Thank you for the fix!
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > ---
> >  net/9p/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/net/9p/Kconfig b/net/9p/Kconfig
> > index 3f286f1bd1d3..e6014e0e51f7 100644
> > --- a/net/9p/Kconfig
> > +++ b/net/9p/Kconfig
> > @@ -24,6 +24,7 @@ config NET_9P_VIRTIO
> >  
> >  config NET_9P_XEN
> >  	depends on XEN
> > +	select XEN_XENBUS_FRONTEND
> >  	tristate "9P Xen Transport"
> >  	help
> >  	  This builds support for a transport for 9pfs between
> > -- 
> > 2.9.0
> > 
> 

Re: [PATCH] xen/9pfs: select CONFIG_XEN_XENBUS_FRONTEND

[Juergen Gross]

On 20/04/17 01:10, Stefano Stabellini wrote:
> Juergen, I have committed this patch to for-linus-4.12 and linux-next, I
> hope that's OK.

Sure.


Juergen

> 
> Og Wed, 19 Apr 2017, Stefano Stabellini wrote:
>> On Wed, 19 Apr 2017, Arnd Bergmann wrote:
>>> All Xen frontends need to select this symbol to avoid a link error:
>>>
>>> net/built-in.o: In function `p9_trans_xen_init':
>>> :(.text+0x149e9c): undefined reference to `__xenbus_register_frontend'
>>>
>>> Fixes: d4b40a02f837 ("xen/9pfs: build 9pfs Xen transport driver")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Thank you for the fix!
>>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>> ---
>>>  net/9p/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/net/9p/Kconfig b/net/9p/Kconfig
>>> index 3f286f1bd1d3..e6014e0e51f7 100644
>>> --- a/net/9p/Kconfig
>>> +++ b/net/9p/Kconfig
>>> @@ -24,6 +24,7 @@ config NET_9P_VIRTIO
>>>  
>>>  config NET_9P_XEN
>>>  	depends on XEN
>>> +	select XEN_XENBUS_FRONTEND
>>>  	tristate "9P Xen Transport"
>>>  	help
>>>  	  This builds support for a transport for 9pfs between
>>> -- 
>>> 2.9.0
>>>
>>
>