* [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform @ 2014-10-15 12:50 Dmitry Eremin-Solenikov 2014-10-15 12:50 ` [PATCH 2/2] ARM: sa1100: use pxa_timer clocksource driver Dmitry Eremin-Solenikov 2014-10-20 19:07 ` [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform Arnd Bergmann 0 siblings, 2 replies; 6+ messages in thread From: Dmitry Eremin-Solenikov @ 2014-10-15 12:50 UTC (permalink / raw) To: linux-kernel, linux-arm-kernel Cc: Russell King, Thomas Gleixner, Daniel Lezcano SA-11x0 platform used the same IP block as was used on PXA. Consequently it makes sense to have only one driver. Enable pxa_timer clocksource for StrongARM platform. Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> --- drivers/clocksource/Kconfig | 6 ++++++ drivers/clocksource/Makefile | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index cfd6519..fd99b08 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -216,4 +216,10 @@ config CLKSRC_VERSATILE ARM Versatile, RealView and Versatile Express reference platforms. +config CLKSRC_PXA + def_bool y if ARCH_PXA || ARCH_SA1100 + help + This enables OST0 support available on PXA and SA-11x0 + platforms. + endmenu diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile index 7fd9fd1..6d9822e 100644 --- a/drivers/clocksource/Makefile +++ b/drivers/clocksource/Makefile @@ -20,7 +20,7 @@ obj-$(CONFIG_ARCH_CLPS711X) += clps711x-timer.o obj-$(CONFIG_ARCH_MARCO) += timer-marco.o obj-$(CONFIG_ARCH_MOXART) += moxart_timer.o obj-$(CONFIG_ARCH_MXS) += mxs_timer.o -obj-$(CONFIG_ARCH_PXA) += pxa_timer.o +obj-$(CONFIG_CLKSRC_PXA) += pxa_timer.o obj-$(CONFIG_ARCH_PRIMA2) += timer-prima2.o obj-$(CONFIG_ARCH_U300) += timer-u300.o obj-$(CONFIG_SUN4I_TIMER) += sun4i_timer.o -- 2.1.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: sa1100: use pxa_timer clocksource driver 2014-10-15 12:50 [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform Dmitry Eremin-Solenikov @ 2014-10-15 12:50 ` Dmitry Eremin-Solenikov 2014-10-20 19:07 ` [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform Arnd Bergmann 1 sibling, 0 replies; 6+ messages in thread From: Dmitry Eremin-Solenikov @ 2014-10-15 12:50 UTC (permalink / raw) To: linux-kernel, linux-arm-kernel Cc: Russell King, Thomas Gleixner, Daniel Lezcano Use pxa_timer clocksource driver. Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> --- arch/arm/mach-sa1100/Makefile | 2 +- arch/arm/mach-sa1100/generic.c | 6 ++ arch/arm/mach-sa1100/time.c | 139 ----------------------------------------- 3 files changed, 7 insertions(+), 140 deletions(-) delete mode 100644 arch/arm/mach-sa1100/time.c diff --git a/arch/arm/mach-sa1100/Makefile b/arch/arm/mach-sa1100/Makefile index 2732eef..8eb9a6f 100644 --- a/arch/arm/mach-sa1100/Makefile +++ b/arch/arm/mach-sa1100/Makefile @@ -3,7 +3,7 @@ # # Common support -obj-y := clock.o generic.o irq.o time.o #nmi-oopser.o +obj-y := clock.o generic.o irq.o #nmi-oopser.o obj-m := obj-n := obj- := diff --git a/arch/arm/mach-sa1100/generic.c b/arch/arm/mach-sa1100/generic.c index d4ea142..40e0d86 100644 --- a/arch/arm/mach-sa1100/generic.c +++ b/arch/arm/mach-sa1100/generic.c @@ -33,6 +33,7 @@ #include <mach/irqs.h> #include "generic.h" +#include <clocksource/pxa.h> unsigned int reset_status; EXPORT_SYMBOL(reset_status); @@ -369,6 +370,11 @@ void __init sa1100_map_io(void) iotable_init(standard_io_desc, ARRAY_SIZE(standard_io_desc)); } +void __init sa1100_timer_init(void) +{ + pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x90000000), 3686400); +} + /* * Disable the memory bus request/grant signals on the SA1110 to * ensure that we don't receive spurious memory requests. We set diff --git a/arch/arm/mach-sa1100/time.c b/arch/arm/mach-sa1100/time.c deleted file mode 100644 index 1dea6cf..0000000 --- a/arch/arm/mach-sa1100/time.c +++ /dev/null @@ -1,139 +0,0 @@ -/* - * linux/arch/arm/mach-sa1100/time.c - * - * Copyright (C) 1998 Deborah Wallach. - * Twiddles (C) 1999 Hugo Fiennes <hugo@empeg.com> - * - * 2000/03/29 (C) Nicolas Pitre <nico@fluxnic.net> - * Rewritten: big cleanup, much simpler, better HZ accuracy. - * - */ -#include <linux/init.h> -#include <linux/kernel.h> -#include <linux/errno.h> -#include <linux/interrupt.h> -#include <linux/irq.h> -#include <linux/timex.h> -#include <linux/clockchips.h> -#include <linux/sched_clock.h> - -#include <asm/mach/time.h> -#include <mach/hardware.h> -#include <mach/irqs.h> - -#define SA1100_CLOCK_FREQ 3686400 -#define SA1100_LATCH DIV_ROUND_CLOSEST(SA1100_CLOCK_FREQ, HZ) - -static u64 notrace sa1100_read_sched_clock(void) -{ - return readl_relaxed(OSCR); -} - -#define MIN_OSCR_DELTA 2 - -static irqreturn_t sa1100_ost0_interrupt(int irq, void *dev_id) -{ - struct clock_event_device *c = dev_id; - - /* Disarm the compare/match, signal the event. */ - writel_relaxed(readl_relaxed(OIER) & ~OIER_E0, OIER); - writel_relaxed(OSSR_M0, OSSR); - c->event_handler(c); - - return IRQ_HANDLED; -} - -static int -sa1100_osmr0_set_next_event(unsigned long delta, struct clock_event_device *c) -{ - unsigned long next, oscr; - - writel_relaxed(readl_relaxed(OIER) | OIER_E0, OIER); - next = readl_relaxed(OSCR) + delta; - writel_relaxed(next, OSMR0); - oscr = readl_relaxed(OSCR); - - return (signed)(next - oscr) <= MIN_OSCR_DELTA ? -ETIME : 0; -} - -static void -sa1100_osmr0_set_mode(enum clock_event_mode mode, struct clock_event_device *c) -{ - switch (mode) { - case CLOCK_EVT_MODE_ONESHOT: - case CLOCK_EVT_MODE_UNUSED: - case CLOCK_EVT_MODE_SHUTDOWN: - writel_relaxed(readl_relaxed(OIER) & ~OIER_E0, OIER); - writel_relaxed(OSSR_M0, OSSR); - break; - - case CLOCK_EVT_MODE_RESUME: - case CLOCK_EVT_MODE_PERIODIC: - break; - } -} - -#ifdef CONFIG_PM -unsigned long osmr[4], oier; - -static void sa1100_timer_suspend(struct clock_event_device *cedev) -{ - osmr[0] = readl_relaxed(OSMR0); - osmr[1] = readl_relaxed(OSMR1); - osmr[2] = readl_relaxed(OSMR2); - osmr[3] = readl_relaxed(OSMR3); - oier = readl_relaxed(OIER); -} - -static void sa1100_timer_resume(struct clock_event_device *cedev) -{ - writel_relaxed(0x0f, OSSR); - writel_relaxed(osmr[0], OSMR0); - writel_relaxed(osmr[1], OSMR1); - writel_relaxed(osmr[2], OSMR2); - writel_relaxed(osmr[3], OSMR3); - writel_relaxed(oier, OIER); - - /* - * OSMR0 is the system timer: make sure OSCR is sufficiently behind - */ - writel_relaxed(OSMR0 - SA1100_LATCH, OSCR); -} -#else -#define sa1100_timer_suspend NULL -#define sa1100_timer_resume NULL -#endif - -static struct clock_event_device ckevt_sa1100_osmr0 = { - .name = "osmr0", - .features = CLOCK_EVT_FEAT_ONESHOT, - .rating = 200, - .set_next_event = sa1100_osmr0_set_next_event, - .set_mode = sa1100_osmr0_set_mode, - .suspend = sa1100_timer_suspend, - .resume = sa1100_timer_resume, -}; - -static struct irqaction sa1100_timer_irq = { - .name = "ost0", - .flags = IRQF_TIMER | IRQF_IRQPOLL, - .handler = sa1100_ost0_interrupt, - .dev_id = &ckevt_sa1100_osmr0, -}; - -void __init sa1100_timer_init(void) -{ - writel_relaxed(0, OIER); - writel_relaxed(OSSR_M0 | OSSR_M1 | OSSR_M2 | OSSR_M3, OSSR); - - sched_clock_register(sa1100_read_sched_clock, 32, 3686400); - - ckevt_sa1100_osmr0.cpumask = cpumask_of(0); - - setup_irq(IRQ_OST0, &sa1100_timer_irq); - - clocksource_mmio_init(OSCR, "oscr", SA1100_CLOCK_FREQ, 200, 32, - clocksource_mmio_readl_up); - clockevents_config_and_register(&ckevt_sa1100_osmr0, 3686400, - MIN_OSCR_DELTA * 2, 0x7fffffff); -} -- 2.1.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform 2014-10-15 12:50 [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform Dmitry Eremin-Solenikov 2014-10-15 12:50 ` [PATCH 2/2] ARM: sa1100: use pxa_timer clocksource driver Dmitry Eremin-Solenikov @ 2014-10-20 19:07 ` Arnd Bergmann 2014-10-23 13:14 ` Dmitry Eremin-Solenikov ` (2 more replies) 1 sibling, 3 replies; 6+ messages in thread From: Arnd Bergmann @ 2014-10-20 19:07 UTC (permalink / raw) To: linux-arm-kernel Cc: Dmitry Eremin-Solenikov, linux-kernel, Thomas Gleixner, Daniel Lezcano, Russell King On Wednesday 15 October 2014 16:50:04 Dmitry Eremin-Solenikov wrote: > SA-11x0 platform used the same IP block as was used on PXA. Consequently > it makes sense to have only one driver. Enable pxa_timer clocksource for > StrongARM platform. > > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Both patches look good to me. Acked-by: Arnd Bergmann <arnd@arndb.de> Should we merge them through arm-soc or through the clocksource tree? Arnd ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform 2014-10-20 19:07 ` [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform Arnd Bergmann @ 2014-10-23 13:14 ` Dmitry Eremin-Solenikov 2014-10-25 9:55 ` Thomas Gleixner 2014-11-06 7:01 ` Dmitry Eremin-Solenikov 2 siblings, 0 replies; 6+ messages in thread From: Dmitry Eremin-Solenikov @ 2014-10-23 13:14 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-arm-kernel, kernel list, Thomas Gleixner, Daniel Lezcano, Russell King 2014-10-20 23:07 GMT+04:00 Arnd Bergmann <arnd@arndb.de>: > On Wednesday 15 October 2014 16:50:04 Dmitry Eremin-Solenikov wrote: >> SA-11x0 platform used the same IP block as was used on PXA. Consequently >> it makes sense to have only one driver. Enable pxa_timer clocksource for >> StrongARM platform. >> >> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > > Both patches look good to me. > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > Should we merge them through arm-soc or through the clocksource tree? I'm fine with any of the approaches. Russell, Daniel, Thomas - any preferences? -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform 2014-10-20 19:07 ` [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform Arnd Bergmann 2014-10-23 13:14 ` Dmitry Eremin-Solenikov @ 2014-10-25 9:55 ` Thomas Gleixner 2014-11-06 7:01 ` Dmitry Eremin-Solenikov 2 siblings, 0 replies; 6+ messages in thread From: Thomas Gleixner @ 2014-10-25 9:55 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-arm-kernel, Dmitry Eremin-Solenikov, linux-kernel, Daniel Lezcano, Russell King On Mon, 20 Oct 2014, Arnd Bergmann wrote: > On Wednesday 15 October 2014 16:50:04 Dmitry Eremin-Solenikov wrote: > > SA-11x0 platform used the same IP block as was used on PXA. Consequently > > it makes sense to have only one driver. Enable pxa_timer clocksource for > > StrongARM platform. > > > > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > > Both patches look good to me. > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > Should we merge them through arm-soc or through the clocksource tree? It touches arm, so please take it through arm-soc with my acked-by. Thanks, tglx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform 2014-10-20 19:07 ` [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform Arnd Bergmann 2014-10-23 13:14 ` Dmitry Eremin-Solenikov 2014-10-25 9:55 ` Thomas Gleixner @ 2014-11-06 7:01 ` Dmitry Eremin-Solenikov 2 siblings, 0 replies; 6+ messages in thread From: Dmitry Eremin-Solenikov @ 2014-11-06 7:01 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-arm-kernel, kernel list, Thomas Gleixner, Daniel Lezcano, Russell King Hello, 2014-10-20 23:07 GMT+04:00 Arnd Bergmann <arnd@arndb.de>: > On Wednesday 15 October 2014 16:50:04 Dmitry Eremin-Solenikov wrote: >> SA-11x0 platform used the same IP block as was used on PXA. Consequently >> it makes sense to have only one driver. Enable pxa_timer clocksource for >> StrongARM platform. >> >> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > > Both patches look good to me. > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > Should we merge them through arm-soc or through the clocksource tree? Thomas added his blessing (and an ack) to merge these patches through arm-soc. Should I gather any additional Acks before it cn hit arm-soc/for-next? -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-06 7:01 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-10-15 12:50 [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform Dmitry Eremin-Solenikov 2014-10-15 12:50 ` [PATCH 2/2] ARM: sa1100: use pxa_timer clocksource driver Dmitry Eremin-Solenikov 2014-10-20 19:07 ` [PATCH 1/2] clocksource: enable pxa_timer for SA-1100 platform Arnd Bergmann 2014-10-23 13:14 ` Dmitry Eremin-Solenikov 2014-10-25 9:55 ` Thomas Gleixner 2014-11-06 7:01 ` Dmitry Eremin-Solenikov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).