linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* input: elantech - force needed quirks on Fujitsu H760
@ 2016-10-03 18:18 Matti Kurkela
  2016-10-04  0:28 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Matti Kurkela @ 2016-10-03 18:18 UTC (permalink / raw)
  To: dmitry.torokhov; +Cc: linux-input, linux-kernel


Just like Fujitsu CELSIUS H730, the H760 also has an Elantech touchpad 
with the same quirks. Without this patch, the touchpad is useless 
out-of-the-box as the mouse pointer won't move.

This patch makes the driver aware of both the crc_enabled=1
requirement and the middle button, making the touchpad fully
functional out-of-the-box.

Signed-off-by: Matti Kurkela <Matti.Kurkela@iki.fi>
---
This patch will also apply without changes to older kernel versions:
I made this originally on 4.4.19 and am currently using it on
my work laptop with 4.4.22.

Backporting to any version that includes commit
f386474e12a560e005ec7899e78f51f6bdc3cf41 should be trivial.

--- linux-4.8/drivers/input/mouse/elantech.c.orig	2016-10-03 02:24:33.000000000 +0300
+++ linux-4.8/drivers/input/mouse/elantech.c	2016-10-03 20:19:17.175141070 +0300
@@ -1159,6 +1159,13 @@ static const struct dmi_system_id elante
  			DMI_MATCH(DMI_PRODUCT_NAME, "CELSIUS H730"),
  		},
  	},
+	{
+		/* Fujitsu H760 also has a middle button */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "CELSIUS H760"),
+		},
+	},
  #endif
  	{ }
  };
@@ -1503,6 +1510,13 @@ static const struct dmi_system_id elante
  		},
  	},
  	{
+		/* Fujitsu H760 does not work with crc_enabled == 0 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "CELSIUS H760"),
+		},
+	},
+	{
  		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
  		.matches = {
  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: input: elantech - force needed quirks on Fujitsu H760
  2016-10-03 18:18 input: elantech - force needed quirks on Fujitsu H760 Matti Kurkela
@ 2016-10-04  0:28 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2016-10-04  0:28 UTC (permalink / raw)
  To: Matti Kurkela; +Cc: linux-input, linux-kernel

On Mon, Oct 03, 2016 at 09:18:28PM +0300, Matti Kurkela wrote:
> 
> Just like Fujitsu CELSIUS H730, the H760 also has an Elantech
> touchpad with the same quirks. Without this patch, the touchpad is
> useless out-of-the-box as the mouse pointer won't move.
> 
> This patch makes the driver aware of both the crc_enabled=1
> requirement and the middle button, making the touchpad fully
> functional out-of-the-box.
> 
> Signed-off-by: Matti Kurkela <Matti.Kurkela@iki.fi>
> ---
> This patch will also apply without changes to older kernel versions:
> I made this originally on 4.4.19 and am currently using it on
> my work laptop with 4.4.22.
> 
> Backporting to any version that includes commit
> f386474e12a560e005ec7899e78f51f6bdc3cf41 should be trivial.

Applied and marked for stable, thank you.

> 
> --- linux-4.8/drivers/input/mouse/elantech.c.orig	2016-10-03 02:24:33.000000000 +0300
> +++ linux-4.8/drivers/input/mouse/elantech.c	2016-10-03 20:19:17.175141070 +0300
> @@ -1159,6 +1159,13 @@ static const struct dmi_system_id elante
>  			DMI_MATCH(DMI_PRODUCT_NAME, "CELSIUS H730"),
>  		},
>  	},
> +	{
> +		/* Fujitsu H760 also has a middle button */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "CELSIUS H760"),
> +		},
> +	},
>  #endif
>  	{ }
>  };
> @@ -1503,6 +1510,13 @@ static const struct dmi_system_id elante
>  		},
>  	},
>  	{
> +		/* Fujitsu H760 does not work with crc_enabled == 0 */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "CELSIUS H760"),
> +		},
> +	},
> +	{
>  		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> 

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-04  0:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-03 18:18 input: elantech - force needed quirks on Fujitsu H760 Matti Kurkela
2016-10-04  0:28 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).